Skip to content

Commit 9cef259

Browse files
committed
OCPBUGS-35752: capi/aws: disable EKS controller in CAPA
The EKS controller feature gate is enabled by default in CAPA, which causes the following lines to show up in the logs: ``` time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613409 349 logger.go:75] \"enabling EKS controllers and webhooks\" logger=\"setup\"" time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613416 349 logger.go:81] \"EKS IAM role creation\" logger=\"setup\" enabled=false" time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613420 349 logger.go:81] \"EKS IAM additional roles\" logger=\"setup\" enabled=false" time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613425 349 logger.go:81] \"enabling EKS control plane controller\" logger=\"setup\"" time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613449 349 logger.go:81] \"enabling EKS bootstrap controller\" logger=\"setup\"" time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613464 349 logger.go:81] \"enabling EKS managed cluster controller\" logger=\"setup\"" time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613496 349 logger.go:81] \"enabling EKS managed machine pool controller\" logger=\"setup\"" ``` Although harmless, they can be confusing for users. This change disables the feature so the lines are gone and we are not running controllers unnecessarily.
1 parent 8a71aec commit 9cef259

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pkg/clusterapi/system.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ func (c *system) Run(ctx context.Context) error {
150150
"--health-addr={{suggestHealthHostPort}}",
151151
"--webhook-port={{.WebhookPort}}",
152152
"--webhook-cert-dir={{.WebhookCertDir}}",
153-
"--feature-gates=BootstrapFormatIgnition=true,ExternalResourceGC=true,TagUnmanagedNetworkResources=false",
153+
"--feature-gates=BootstrapFormatIgnition=true,ExternalResourceGC=true,TagUnmanagedNetworkResources=false,EKS=false",
154154
},
155155
map[string]string{},
156156
)

0 commit comments

Comments
 (0)