additional lint fixes

Author: andfasano

pkg/asset/agent/installconfig.go

@@ -257,6 +257,7 @@ func (a *OptionalInstallConfig) ClusterName() string {
 	return "agent-cluster"
 }
 
+// ClusterName returns the namespace of the cluster.
 func (a *OptionalInstallConfig) ClusterNamespace() string {
 	if a.Config != nil && a.Config.ObjectMeta.Namespace != "" {
 		return a.Config.ObjectMeta.Namespace

pkg/asset/agent/manifests/agentpullsecret.go

@@ -88,7 +88,6 @@ func (a *AgentPullSecret) generateSecret(name, namespace, pullSecret string) {
 		},
 	}
 	a.Config = secret
-
 }
 
 // Files returns the files generated by the asset.

pkg/asset/agent/manifests/clusterimageset.go

@@ -146,7 +146,6 @@ func (a *ClusterImageSet) Load(f asset.FileFetcher) (bool, error) {
 }
 
 func (a *ClusterImageSet) finish(workflowType workflow.AgentWorkflowType) error {
-
 	if a.Config == nil {
 		return errors.New("missing configuration or manifest file")
 	}
@@ -169,7 +168,6 @@ func (a *ClusterImageSet) validateClusterImageSet(workflowType workflow.AgentWor
 }
 
 func (a *ClusterImageSet) validateReleaseVersion(workflowType workflow.AgentWorkflowType) field.ErrorList {
-
 	// skip release version check in case of add nodes workflow
 	if workflowType == workflow.AgentWorkflowTypeAddNodes {
 		return nil

pkg/asset/agent/manifests/infraenv.go

@@ -107,7 +107,7 @@ func (i *InfraEnv) generateManifest(clusterName, clusterNamespace, sshKey, addit
 
 	// Input values (amd64, arm64) must be converted to rpmArch because infraEnv.Spec.CpuArchitecture expects x86_64 or aarch64.
 	if architecture != "" {
-		infraEnv.Spec.CpuArchitecture = arch.RpmArch(string(architecture))
+		infraEnv.Spec.CpuArchitecture = arch.RpmArch(architecture)
 	}
 	if additionalTrustBundle != "" {
 		infraEnv.Spec.AdditionalTrustBundle = additionalTrustBundle

pkg/nodejoiner/addnodes.go

@@ -2,8 +2,8 @@ package nodejoiner
 
 import (
 	"github.com/openshift/installer/pkg/asset"
+	"github.com/openshift/installer/pkg/asset/agent/image"
 	"github.com/openshift/installer/pkg/asset/agent/joiner"
-	"github.com/openshift/installer/pkg/asset/agent/manifests"
 	"github.com/openshift/installer/pkg/asset/agent/workflow"
 	"github.com/openshift/installer/pkg/asset/store"
 )
@@ -23,7 +23,7 @@ func NewAddNodesCommand(directory string, kubeConfig string) error {
 	fetcher := store.NewAssetsFetcher(directory)
 	return fetcher.FetchAndPersist([]asset.WritableAsset{
 		&workflow.AgentWorkflowAddNodes{},
-		&manifests.AgentPullSecret{},
+		&image.AgentImage{},
 		// To be completed
 	})
 }