Skip to content

Commit a45d7a7

Browse files
Merge pull request openshift#7932 from barbacbd/OCPBUGS-27156
OCPBUGS-27156: GCP Destroy cleanup correct zones/records
2 parents dad850d + 184d264 commit a45d7a7

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

pkg/asset/cluster/gcp/gcp.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,16 @@ import (
1010

1111
// Metadata converts an install configuration to GCP metadata.
1212
func Metadata(config *types.InstallConfig) *gcp.Metadata {
13+
// leave the private zone domain blank when not using a pre-created private zone
14+
privateZoneDomain := fmt.Sprintf("%s.", config.ClusterDomain())
15+
if config.GCP.Network == "" || config.GCP.NetworkProjectID == "" {
16+
privateZoneDomain = ""
17+
}
18+
1319
return &gcp.Metadata{
1420
Region: config.Platform.GCP.Region,
1521
ProjectID: config.Platform.GCP.ProjectID,
1622
NetworkProjectID: config.Platform.GCP.NetworkProjectID,
17-
PrivateZoneDomain: fmt.Sprintf("%s.", config.ClusterDomain()),
23+
PrivateZoneDomain: privateZoneDomain,
1824
}
1925
}

0 commit comments

Comments
 (0)