Skip to content

Commit c4c45d0

Browse files
Merge pull request openshift#8667 from rna-afk/capz_fix_accelerated_network
OCPBUGS-35959: azure: Fix Accelerated network enablement
2 parents d22a285 + 8994917 commit c4c45d0

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

pkg/asset/machines/azure/azuremachines.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ func GenerateMachines(platform *azure.Platform, pool *types.MachinePool, userDat
140140
NetworkInterfaces: []capz.NetworkInterface{
141141
{
142142
SubnetName: subnet,
143-
AcceleratedNetworking: ptr.To(mpool.VMNetworkingType == azure.AcceleratedNetworkingEnabled),
143+
AcceleratedNetworking: ptr.To(mpool.VMNetworkingType == string(azure.VMnetworkingTypeAccelerated) || mpool.VMNetworkingType == string(azure.AcceleratedNetworkingEnabled)),
144144
},
145145
},
146146
Identity: capz.VMIdentityUserAssigned,

pkg/asset/machines/clusterapi.go

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -258,13 +258,21 @@ func (c *ClusterAPI) Generate(ctx context.Context, dependencies asset.Parents) e
258258
mpool.OSImage.Publisher = *img.Plan.Publisher
259259
}
260260
}
261-
pool.Platform.Azure = &mpool
262-
subnet := ic.Azure.ControlPlaneSubnet
263-
264261
capabilities, err := client.GetVMCapabilities(ctx, mpool.InstanceType, installConfig.Config.Platform.Azure.Region)
265262
if err != nil {
266263
return err
267264
}
265+
if mpool.VMNetworkingType == "" {
266+
isAccelerated := icazure.GetVMNetworkingCapability(capabilities)
267+
if isAccelerated {
268+
mpool.VMNetworkingType = string(azuretypes.VMnetworkingTypeAccelerated)
269+
} else {
270+
logrus.Infof("Instance type %s does not support Accelerated Networking. Using Basic Networking instead.", mpool.InstanceType)
271+
}
272+
}
273+
pool.Platform.Azure = &mpool
274+
subnet := ic.Azure.ControlPlaneSubnet
275+
268276
hyperVGen, err := icazure.GetHyperVGenerationVersion(capabilities, "")
269277
if err != nil {
270278
return err

0 commit comments

Comments
 (0)