OpenStack: Skip API/Ingress management when using external LB

When using external LB the API and Ingress are managed externally,
so we shouldn't create Neutron Ports with the VIPs for API and
Ingress nor should we set those addresses in the Machines allowed
address pairs.

Author: MaysaMacedo

pkg/asset/machines/openstack/openstackmachines.go

@@ -10,6 +10,7 @@ import (
 	capo "sigs.k8s.io/cluster-api-provider-openstack/api/v1beta1"
 	capi "sigs.k8s.io/cluster-api/api/v1beta1"
 
+	configv1 "github.com/openshift/api/config/v1"
 	machinev1 "github.com/openshift/api/machine/v1"
 	"github.com/openshift/installer/pkg/asset"
 	"github.com/openshift/installer/pkg/asset/manifests/capiutils"
@@ -112,13 +113,7 @@ func GenerateMachines(clusterID string, config *types.InstallConfig, pool *types
 func generateMachineSpec(clusterID string, platform *openstack.Platform, mpool *openstack.MachinePool, osImage string, role string, trunkSupport bool, failureDomain machinev1.OpenStackFailureDomain) (*capo.OpenStackMachineSpec, error) {
 	port := capo.PortOpts{}
 
-	addressPairs := []capo.AddressPair{}
-	for _, apiVIP := range platform.APIVIPs {
-		addressPairs = append(addressPairs, capo.AddressPair{IPAddress: apiVIP})
-	}
-	for _, ingressVIP := range platform.IngressVIPs {
-		addressPairs = append(addressPairs, capo.AddressPair{IPAddress: ingressVIP})
-	}
+	addressPairs := populateAllowedAddressPairs(platform)
 
 	if platform.ControlPlanePort != nil {
 		if networkID := platform.ControlPlanePort.Network.ID; networkID != "" {
@@ -223,3 +218,17 @@ func generateMachineSpec(clusterID string, platform *openstack.Platform, mpool *
 
 	return &spec, nil
 }
+
+func populateAllowedAddressPairs(platform *openstack.Platform) []capo.AddressPair {
+	if lb := platform.LoadBalancer; lb != nil && lb.Type == configv1.LoadBalancerTypeUserManaged {
+		return nil
+	}
+	addressPairs := []capo.AddressPair{}
+	for _, apiVIP := range platform.APIVIPs {
+		addressPairs = append(addressPairs, capo.AddressPair{IPAddress: apiVIP})
+	}
+	for _, ingressVIP := range platform.IngressVIPs {
+		addressPairs = append(addressPairs, capo.AddressPair{IPAddress: ingressVIP})
+	}
+	return addressPairs
+}

pkg/infrastructure/openstack/infraready/floatingips.go

@@ -9,18 +9,22 @@ import (
 	"github.com/gophercloud/gophercloud/openstack/networking/v2/ports"
 	capo "sigs.k8s.io/cluster-api-provider-openstack/api/v1beta1"
 
+	configv1 "github.com/openshift/api/config/v1"
 	"github.com/openshift/installer/pkg/asset/installconfig"
 	openstackdefaults "github.com/openshift/installer/pkg/types/openstack/defaults"
 )
 
 // FloatingIPs creates or gets the API and Ingress ports and attaches the Floating IPs to them.
 func FloatingIPs(cluster *capo.OpenStackCluster, installConfig *installconfig.InstallConfig, infraID string) error {
+	platformOpenstack := installConfig.Config.OpenStack
+	if lb := platformOpenstack.LoadBalancer; lb != nil && lb.Type == configv1.LoadBalancerTypeUserManaged {
+		return nil
+	}
 	networkClient, err := openstackdefaults.NewServiceClient("network", openstackdefaults.DefaultClientOpts(installConfig.Config.Platform.OpenStack.Cloud))
 	if err != nil {
 		return err
 	}
 	var apiPort, ingressPort *ports.Port
-	platformOpenstack := installConfig.Config.OpenStack
 	if platformOpenstack.ControlPlanePort != nil && len(platformOpenstack.ControlPlanePort.FixedIPs) == 2 {
 		// To avoid unnecessary calls to Neutron, let's fetch the Ports in case there is a need to attach FIPs
 		if platformOpenstack.APIFloatingIP != "" {