Merge pull request #10 from r8/fix-crash-on-nil

Fix crashing when URL is empty or nil.

Author: r8

CHANGELOG.md

@@ -1,7 +1,8 @@
 # Change Log
 
 ## [Unreleased]
-### Added
+### Fixed
+- Fix crashing when URL is empty or nil. 
 
 ### Changed
 

lib/oembed.ex

@@ -42,14 +42,16 @@ defmodule OEmbed do
   {:ok, result} = OEmbed.for("https://www.youtube.com/watch?v=dQw4w9WgXcQ")
   ```
   """
-  def for(url) do
+  def for(_url = ""), do: {:error, "Empty URL"}
+  def for(url) when is_binary(url) do
     case Enum.find(get_providers(), fn(provider) -> provider.provides?(url) end) do
       nil ->
         {:error, "oEmbed not found"}
       provider ->
         provider.get(url)
     end
   end
+  def for(_), do: {:error, "Empty URL"}
 
   defp get_providers do
     @core_providers

test/oembed_test.exs

@@ -5,14 +5,22 @@ defmodule OEmbedTest do
   alias OEmbed.Video
   alias OEmbed.Rich
 
+  test "gets error response for nil" do
+    {:error, _} = OEmbed.for(nil)
+  end
+
+  test "gets error response for empty string" do
+    {:error, _} = OEmbed.for("")
+  end
+
   test "gets video oembed for valid youtube url" do
     use_cassette "youtube_valid" do
       {:ok, %Video{} = oembed} = OEmbed.for("https://www.youtube.com/watch?v=dQw4w9WgXcQ")
       assert oembed.html =~ "<iframe"
     end
   end
 
-  test "gets error respone for invalid youtube url" do
+  test "gets error response for invalid youtube url" do
     use_cassette "youtube_invalid" do
       {:error, _} = OEmbed.for("https://www.youtube.com/watch?v=invalid_url")
     end
@@ -32,7 +40,7 @@ defmodule OEmbedTest do
     end
   end
 
-  test "gets error respone for invalid instagram url" do
+  test "gets error response for invalid instagram url" do
     use_cassette "instagram_invalid" do
       {:error, _} = OEmbed.for("https://www.instagram.com/p/invalid_url/")
     end
@@ -45,7 +53,7 @@ defmodule OEmbedTest do
     end
   end
 
-  test "gets error respone for invalid pinterest url" do
+  test "gets error response for invalid pinterest url" do
     use_cassette "pinterest_pin_invalid" do
       {:error, _} = OEmbed.for("https://www.pinterest.com/pin/invalid_url/")
     end