CPython linking issues on Windows

[SeleDreams]

errorlog (1).txt

It seems that when installing pyopenjtalk via pip, the pip install fails when building the C++ code.
I have all the required dependencies, the linking issues seem to be related to the python libraries.

I'm on Windows 11 64-bit using Visual Studio 2022 with MSVC 14.43.34808 and Python 3.10

[SeleDreams]

One guess I have is that it might be trying to build 32-bit binaries with the 64-bit python

[SeleDreams]

I identified the issue !
It seems that by default, it does consider the windows environment to be 32-bit and calls the 32-bit msvc environment !

modifying the setup.py like this

class custom_build_ext(setuptools.command.build_ext.build_ext):
    def initialize_options(self):
        super().initialize_options()
        self.plat_name = 'win-amd64'

Allows it to build without issues and install.
So now, it would only require to add a conditional check so that it only does it on 64-bit windows machine. I'll probably do a pull request once done

[SeleDreams]

A fix without modifying the source is to set the env variable PLAT_NAME before installing the pip package. I think this could be added to the install instructions !

[sabonerune]

@SeleDreams
It looks like you are using Visual Studio Community.
By the way, how did you open that terminal?

If you are using a regular terminal without Visual Studio in your path, Setuptools will automatically find the correct Visual Studio.
However, if you open a shell with the target set to x86, Setuptools seems to build using that environment as is, even if the interpreter is x64.

[SeleDreams]

I'm using powershell 7 with a script that launches the visual studio command prompt. It allows to directly call msbuild etc as it adds everything to the path.

[sabonerune]

@SeleDreams
Are you talking about Launch-VsDevShell.ps1?
This script will default the host and target architecture to x86.

There is no need to call this script when building pyopenjtalk in the first place.
If you do call it, at least make sure the target architecture matches the Python architecture.