Merge pull request #131 from rOpenSpain/mock-httr2

Use `testthat::local_mocked_bindings()` on API error testing.

Author: dieghernan

.vscode/settings.json

@@ -17,6 +17,7 @@
   "better-yaml.flowCollectionPadding": false,
   "better-yaml.lineWidth": 80,
   "positron.r.pipe": "|>",
+  "positron.r.useNativePipe": true,
   "yaml.completion": true,
   "yaml.format.printWidth": 80,
   "yaml.validate": true

NEWS.md

@@ -1,5 +1,7 @@
 # mapSpain (development version)
 
+-   Use `testthat::local_mocked_bindings()` on API error testing.
+
 # mapSpain 1.0.0
 
 This major release introduces a full overhaul of the codebase and test suite.

R/esp-check-access.R

@@ -42,7 +42,7 @@ esp_check_access <- function() {
 #' @noRd
 skip_if_siane_offline <- function() {
   # nocov start
-  test_offline <- getOption("mapspain_test_404", FALSE)
+  test_offline <- is_404()
   if (test_offline) {
     return(invisible(TRUE))
   }
@@ -65,7 +65,7 @@ skip_if_siane_offline <- function() {
 #' @noRd
 skip_if_gisco_offline <- function() {
   # nocov start
-  test_offline <- getOption("gisco_test_404", FALSE)
+  test_offline <- is_404()
   if (test_offline) {
     return(invisible(TRUE))
   }

R/esp-get-munic.R

@@ -104,7 +104,7 @@ esp_get_munic <- function(
   cache_dir <- create_cache_dir(cache_dir)
 
   if (as.character(year) >= "2011") {
-    data_sf <- giscoR::gisco_get_lau(
+    data_sf <- giscor_get_lau(
       year = year,
       epsg = gisco_epsg,
       cache = cache, # Deprecated...
@@ -218,3 +218,10 @@ esp_get_munic <- function(
   data_sf <- sanitize_sf(data_sf)
   data_sf
 }
+
+
+#' Wrap for mocking
+#' @noRd
+giscor_get_lau <- function(...) {
+  giscoR::gisco_get_lau(...)
+}

R/esp-get-nuts.R

@@ -156,7 +156,7 @@ esp_get_nuts <- function(
       "Use {.arg update_cache = TRUE} to re-load from file"
     )
   } else {
-    data_sf <- giscoR::gisco_get_nuts(
+    data_sf <- giscor_get_nuts(
       year = year,
       epsg = gisco_epsg,
       cache = cache,
@@ -210,3 +210,9 @@ esp_get_nuts <- function(
   data_sf <- sanitize_sf(data_sf)
   data_sf
 }
+
+#' Wrapper for mock
+#' @noRd
+giscor_get_nuts <- function(...) {
+  giscoR::gisco_get_nuts(...)
+}

R/utils-url.R

@@ -68,9 +68,7 @@ download_url <- function(
     req <- httr2::req_progress(req)
   }
 
-  test_off <- getOption("mapspain_test_offline", FALSE)
-
-  if (any(!httr2::is_online(), test_off)) {
+  if (!is_online_fun()) {
     cli::cli_alert_danger("Offline")
     cli::cli_alert("Returning {.val NULL}")
     return(NULL)
@@ -92,7 +90,7 @@ download_url <- function(
   }
 
   # Testing
-  test_offline <- getOption("mapspain_test_404", FALSE)
+  test_offline <- is_404()
   if (test_offline) {
     # Modify to redirect to fake url
     req <- httr2::req_url(
@@ -157,3 +155,15 @@ for_import_jsonlite <- function() {
   local <- NULL
   invisible(local)
 }
+
+#' Wrapper is_online for testing
+#' @noRd
+is_online_fun <- function(...) {
+  httr2::is_online()
+}
+
+#' Wrapper is_404 for testing
+#' @noRd
+is_404 <- function(...) {
+  FALSE
+}

README.md

@@ -230,6 +230,7 @@ load it, which speeds up the process.
 ## Citation
 
 <p>
+
 Hernangómez D (2026). <em>mapSpain: Administrative Boundaries of
 Spain</em>.
 <a href="https://doi.org/10.5281/zenodo.5366622">doi:10.5281/zenodo.5366622</a>,

codemeta.json

@@ -296,7 +296,7 @@
   "applicationCategory": "cartography",
   "isPartOf": "https://ropenspain.es/",
   "keywords": ["ropenspain", "tiles", "r", "maps", "spatial", "rstats", "r-package", "municipalities", "spain", "gisco", "provinces", "ign", "administrative-boundaries", "ccaa", "static-tiles", "cran", "ggplot2", "gis"],
-  "fileSize": "1813.341KB",
+  "fileSize": "1811.861KB",
   "citation": [
     {
       "@type": "SoftwareSourceCode",

tests/testthat/test-esp-get-capimun.R

@@ -2,28 +2,36 @@ test_that("Test offline", {
   skip_on_cran()
   skip_if_siane_offline()
 
-  options(mapspain_test_offline = TRUE)
+  local_mocked_bindings(is_online_fun = function(...) {
+    FALSE
+  })
   expect_message(
     n <- esp_get_capimun(update_cache = TRUE),
     "Offline"
   )
   expect_null(n)
 
-  options(mapspain_test_offline = FALSE)
+  local_mocked_bindings(is_online_fun = function(...) {
+    httr2::is_online()
+  })
 })
 
 test_that("Test 404", {
   skip_on_cran()
   skip_if_siane_offline()
 
-  options(mapspain_test_404 = TRUE)
+  local_mocked_bindings(is_404 = function(...) {
+    TRUE
+  })
   expect_message(
     n <- esp_get_capimun(update_cache = TRUE),
     "Error"
   )
   expect_null(n)
 
-  options(mapspain_test_404 = FALSE)
+  local_mocked_bindings(is_404 = function(...) {
+    FALSE
+  })
 })
 
 

tests/testthat/test-esp-get-ccaa-siane.R

@@ -3,33 +3,37 @@ test_that("Test offline", {
   skip_if_siane_offline()
   skip_if_gisco_offline()
 
-  options(gisco_test_offline = TRUE)
-  options(mapspain_test_offline = TRUE)
+  local_mocked_bindings(is_online_fun = function(...) {
+    FALSE
+  })
   expect_message(
     n <- esp_get_ccaa_siane(update_cache = TRUE, verbose = FALSE),
     "Offline"
   )
   expect_null(n)
 
-  options(mapspain_test_offline = FALSE)
-  options(gisco_test_offline = FALSE)
+  local_mocked_bindings(is_online_fun = function(...) {
+    httr2::is_online()
+  })
 })
 
 test_that("Test 404", {
   skip_on_cran()
   skip_if_siane_offline()
   skip_if_gisco_offline()
 
-  options(gisco_test_404 = TRUE)
-  options(mapspain_test_404 = TRUE)
+  local_mocked_bindings(is_404 = function(...) {
+    TRUE
+  })
   expect_message(
     n <- esp_get_ccaa_siane(update_cache = TRUE),
     "Error"
   )
   expect_null(n)
 
-  options(mapspain_test_404 = FALSE)
-  options(gisco_test_404 = FALSE)
+  local_mocked_bindings(is_404 = function(...) {
+    FALSE
+  })
 })
 
 test_that("Cache vs non-cached", {