From 45dc8d4c737a88a2c2925351e40378573326f917 Mon Sep 17 00:00:00 2001 From: Egor Kotov Date: Sat, 12 Apr 2025 20:21:53 +0200 Subject: [PATCH 1/4] let spod_convert accept overwrite = 'update' --- NEWS.md | 4 ++++ tests/testthat/test-convert.R | 3 +++ 2 files changed, 7 insertions(+) create mode 100644 tests/testthat/test-convert.R diff --git a/NEWS.md b/NEWS.md index 1eef6336..6db7391d 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,9 @@ # spanishoddata (development version) +## Bug fixes + +* `spod_convert()` can now accept `overwrite = 'update'` with `save_format = 'parquet'` ([#161]((https://github.com/rOpenSpain/spanishoddata/pulls/161))) previously it failed because of the incorrect check that asserted only `TRUE` or `FALSE` ([#160](https://github.com/rOpenSpain/spanishoddata/issues/160)) + # spanishoddata 0.1.1 ## New features diff --git a/tests/testthat/test-convert.R b/tests/testthat/test-convert.R new file mode 100644 index 00000000..8849056e --- /dev/null +++ b/tests/testthat/test-convert.R @@ -0,0 +1,3 @@ +test_that("multiplication works", { + expect_equal(2 * 2, 4) +}) From b3425b68553f603ef03eaba09ed6e35274b5a5df Mon Sep 17 00:00:00 2001 From: Egor Kotov Date: Sat, 12 Apr 2025 20:23:47 +0200 Subject: [PATCH 2/4] fix news --- NEWS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index 6db7391d..d8355750 100644 --- a/NEWS.md +++ b/NEWS.md @@ -2,7 +2,7 @@ ## Bug fixes -* `spod_convert()` can now accept `overwrite = 'update'` with `save_format = 'parquet'` ([#161]((https://github.com/rOpenSpain/spanishoddata/pulls/161))) previously it failed because of the incorrect check that asserted only `TRUE` or `FALSE` ([#160](https://github.com/rOpenSpain/spanishoddata/issues/160)) +* `spod_convert()` can now accept `overwrite = 'update'` with `save_format = 'parquet'` ([#161](https://github.com/rOpenSpain/spanishoddata/pulls/161)) previously it failed because of the incorrect check that asserted only `TRUE` or `FALSE` ([#160](https://github.com/rOpenSpain/spanishoddata/issues/160)) # spanishoddata 0.1.1 From f72d0f9bb9063eda716b00f2618f87cff1b4a6ea Mon Sep 17 00:00:00 2001 From: Egor Kotov Date: Sat, 12 Apr 2025 20:24:55 +0200 Subject: [PATCH 3/4] fix news --- NEWS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index d8355750..1a547eca 100644 --- a/NEWS.md +++ b/NEWS.md @@ -2,7 +2,7 @@ ## Bug fixes -* `spod_convert()` can now accept `overwrite = 'update'` with `save_format = 'parquet'` ([#161](https://github.com/rOpenSpain/spanishoddata/pulls/161)) previously it failed because of the incorrect check that asserted only `TRUE` or `FALSE` ([#160](https://github.com/rOpenSpain/spanishoddata/issues/160)) +* `spod_convert()` can now accept `overwrite = 'update'` with `save_format = 'parquet'` ([#161](https://github.com/rOpenSpain/spanishoddata/pull/161)) previously it failed because of the incorrect check that asserted only `TRUE` or `FALSE` ([#160](https://github.com/rOpenSpain/spanishoddata/issues/160)) # spanishoddata 0.1.1 From ae2161317b7aedf89f072cac5d291af22b74e812 Mon Sep 17 00:00:00 2001 From: Egor Kotov Date: Sat, 12 Apr 2025 20:31:26 +0200 Subject: [PATCH 4/4] no tests for convert yet --- tests/testthat/test-convert.R | 3 --- 1 file changed, 3 deletions(-) delete mode 100644 tests/testthat/test-convert.R diff --git a/tests/testthat/test-convert.R b/tests/testthat/test-convert.R deleted file mode 100644 index 8849056e..00000000 --- a/tests/testthat/test-convert.R +++ /dev/null @@ -1,3 +0,0 @@ -test_that("multiplication works", { - expect_equal(2 * 2, 4) -})