fix: resolve clippy warnings breaking CI on master (#85)

Author: raaymax

benches/filter.rs

@@ -133,7 +133,7 @@ fn generate_test_file(path: &Path, target_size_mb: usize) -> (u64, usize) {
             line_count % 1000,
         );
 
-        let line = if line_count % 3 == 0 {
+        let line = if line_count.is_multiple_of(3) {
             format!(
                 r#"{{"level":"{}","message":"{}","service":"{}","timestamp":"{}","request_id":"req-{:06}","duration_ms":{},"extra_field_1":"value_{}","extra_field_2":"another_value_{}"}}
 "#,
@@ -206,6 +206,7 @@ fn collect_matches(rx: std::sync::mpsc::Receiver<FilterProgress>) -> (usize, usi
 
 struct FilterBenchCase {
     name: &'static str,
+    #[allow(clippy::type_complexity)]
     run: Box<dyn Fn(&Path) -> (usize, usize)>,
 }
 

benches/render.rs

@@ -148,7 +148,7 @@ fn generate_test_file(path: &Path, target_size_mb: usize) -> (u64, usize) {
         );
 
         // Alternate between JSON and logfmt to test both parsers
-        let line = if line_count % 3 == 0 {
+        let line = if line_count.is_multiple_of(3) {
             format!(
                 r#"{{"level":"{}","message":"{}","service":"{}","timestamp":"{}","request_id":"req-{:06}","duration_ms":{},"extra_field_1":"value_{}","extra_field_2":"another_value_{}"}}
 "#,

examples/bench_compression.rs

@@ -77,7 +77,7 @@ fn main() -> Result<()> {
         frame_buffer.push('\n');
         line_count += 1;
 
-        if line_count % frame_size as u64 == 0 {
+        if line_count.is_multiple_of(frame_size as u64) {
             let original = frame_buffer.len() as u64;
             let compressed = compress_lz4(frame_buffer.as_bytes());
             let compressed_len = compressed.len() as u64;
@@ -87,7 +87,7 @@ fn main() -> Result<()> {
             frame_count += 1;
 
             // Progress every 100 frames
-            if frame_count % 100 == 0 {
+            if frame_count.is_multiple_of(100) {
                 let ratio = total_original as f64 / total_compressed as f64;
                 println!(
                     "  Processed {} frames ({} lines) - Ratio: {:.2}x",

src/filter/query/mod.rs

@@ -24,12 +24,14 @@ mod ast;
 mod filter;
 mod parser;
 
-// Re-export all public types for backward compatibility
-pub use ast::{
-    Aggregation, AggregationType, ExcludePattern, FieldFilter, FilterQuery, Operator, Parser,
-};
+// Re-export public types used outside this module
+pub use ast::{Aggregation, FilterQuery, Parser};
 pub use filter::QueryFilter;
-pub use parser::{parse_query, QueryParseError};
+pub use parser::parse_query;
+
+// Re-export types only used in tests
+#[cfg(test)]
+pub use ast::{AggregationType, ExcludePattern, FieldFilter, Operator};
 
 // Re-export from shared parsing module
 pub use crate::parsing::{extract_json_field, parse_logfmt};

src/history.rs

@@ -17,7 +17,7 @@ fn history_file_path() -> Option<PathBuf> {
 pub fn load_history() -> Vec<FilterHistoryEntry> {
     #[cfg(test)]
     {
-        return Vec::new();
+        Vec::new()
     }
 
     #[cfg(not(test))]
@@ -37,7 +37,6 @@ pub fn save_history(history: &[FilterHistoryEntry]) {
     #[cfg(test)]
     {
         let _ = history;
-        return;
     }
 
     #[cfg(not(test))]

src/index/healing_tests.rs

@@ -84,7 +84,7 @@ impl HealingFixture {
     }
 
     fn open_reader(&self) -> FileReader {
-        FileReader::new(&self.log_path()).unwrap()
+        FileReader::new(self.log_path()).unwrap()
     }
 
     fn assert_lines(&self, reader: &mut FileReader, expected: &[String]) {
@@ -378,8 +378,8 @@ fn detect_symlink_retarget() {
     let log2 = dir.path().join("real2.log");
     let link = dir.path().join("current.log");
 
-    fs::write(&log1, &make_lines(10)).unwrap();
-    fs::write(&log2, &make_lines_offset(100, 10)).unwrap();
+    fs::write(&log1, make_lines(10)).unwrap();
+    fs::write(&log2, make_lines_offset(100, 10)).unwrap();
 
     std::os::unix::fs::symlink(&log1, &link).unwrap();
     let idx_dir = index_dir_for_log(&link);
@@ -398,7 +398,7 @@ fn detect_symlink_retarget() {
 #[test]
 fn detect_index_dir_is_regular_file() {
     let fix = HealingFixture::new(&make_lines(5));
-    fs::write(&fix.idx_dir(), "not a directory").unwrap();
+    fs::write(fix.idx_dir(), "not a directory").unwrap();
 
     let reader = fix.open_reader();
     assert!(!reader.has_columnar_offsets());
@@ -1081,7 +1081,7 @@ fn manual_edit_same_length_between_checkpoints_must_be_detected() {
         content.push_str(&format!("line {:04}\n", i)); // fixed-width: "line 0005\n" = 10 bytes
     }
     let fix = HealingFixture::new(&content);
-    let meta = fix.build_index_with_interval(10);
+    let _meta = fix.build_index_with_interval(10);
 
     // Edit line 5: "line 0005" → "LINE 0005" (same length)
     let edited = content.replace("line 0005", "LINE 0005");
@@ -1107,7 +1107,7 @@ fn manual_edit_same_length_between_checkpoints_must_be_detected() {
 #[test]
 fn manual_edit_changes_line_length_must_invalidate_index() {
     let fix = HealingFixture::new(&make_lines(20));
-    let meta = fix.build_index_with_interval(10);
+    let _meta = fix.build_index_with_interval(10);
 
     // Replace line 5 with a longer version
     let original = fs::read_to_string(fix.log_path()).unwrap();
@@ -1143,7 +1143,7 @@ fn manual_edit_changes_line_length_must_invalidate_index() {
 #[test]
 fn manual_insert_lines_in_middle_must_invalidate_index() {
     let fix = HealingFixture::new(&make_lines(20));
-    let meta = fix.build_index_with_interval(10);
+    let _meta = fix.build_index_with_interval(10);
 
     // Insert 3 lines after line 5
     let original = fs::read_to_string(fix.log_path()).unwrap();
@@ -1333,8 +1333,8 @@ fn overwrite_beginning_same_size_must_be_detected() {
 
     // Overwrite first 20 bytes with zeros (corrupts first two lines)
     let mut data = fs::read(fix.log_path()).unwrap();
-    for i in 0..20 {
-        data[i] = 0;
+    for byte in data.iter_mut().take(20) {
+        *byte = 0;
     }
     fs::write(fix.log_path(), &data).unwrap();
 
@@ -1345,7 +1345,7 @@ fn overwrite_beginning_same_size_must_be_detected() {
     );
 
     // Reader must not return garbage via columnar path
-    let mut reader = fix.open_reader();
+    let reader = fix.open_reader();
     assert!(
         !reader.has_columnar_offsets(),
         "reader must fall back to sparse after detecting corruption"

src/index/meta.rs

@@ -234,7 +234,7 @@ mod tests {
         let path = dir.path().join("truncated_meta");
 
         // Write only 32 bytes (less than META_SIZE)
-        std::fs::write(&path, &[0u8; 32]).unwrap();
+        std::fs::write(&path, [0u8; 32]).unwrap();
         let err = IndexMeta::read_from(&path).unwrap_err();
         assert!(err.to_string().contains("too small"));
     }

src/index/reader.rs

@@ -446,9 +446,9 @@ mod tests {
         // Write offsets column
         let mut offsets = ColumnWriter::<u64>::create(idx_dir.join("offsets")).unwrap();
         let mut offset = 0u64;
-        for i in 0..line_count {
+        for line in lines.iter().take(line_count) {
             offsets.push(offset).unwrap();
-            offset += lines[i].len() as u64 + 1; // +1 for newline
+            offset += line.len() as u64 + 1; // +1 for newline
         }
         drop(offsets);
 
@@ -521,7 +521,7 @@ mod tests {
             .append(true)
             .open(&log_path)
             .unwrap();
-        write!(f, "line four\n").unwrap();
+        writeln!(f, "line four").unwrap();
         drop(f);
 
         let stats = IndexReader::stats(&log_path);

src/reader/file_reader.rs

@@ -376,12 +376,14 @@ impl FileReader {
 
     /// Whether this reader has loaded columnar offsets for O(1) line access.
     #[cfg(test)]
+    #[allow(dead_code)] // Used by lib tests (healing_tests), not bin tests
     pub(crate) fn has_columnar_offsets(&self) -> bool {
         self.columnar_offsets.is_some()
     }
 
     /// Number of lines covered by the columnar index.
     #[cfg(test)]
+    #[allow(dead_code)] // Used by lib tests (healing_tests), not bin tests
     pub(crate) fn columnar_line_count(&self) -> usize {
         self.indexed_lines
     }

src/session.rs

@@ -41,7 +41,7 @@ pub fn load_last_source(project_root: Option<&Path>) -> Option<String> {
     #[cfg(test)]
     {
         let _ = project_root;
-        return None;
+        None
     }
 
     #[cfg(not(test))]
@@ -59,7 +59,6 @@ pub fn save_last_source(project_root: Option<&Path>, name: &str) {
     #[cfg(test)]
     {
         let _ = (project_root, name);
-        return;
     }
 
     #[cfg(not(test))]