Formal changes / fixed spelling errors

rabanti-github · rabanti-github · commit 27adb8099b21 · 2025-11-30T20:58:47.000+01:00
diff --git a/Docs.IndexGenerator/Program.cs b/Docs.IndexGenerator/Program.cs
@@ -195,7 +195,7 @@ static string GenerateListItems(PluginConfig cfg)
             var sb = new System.Text.StringBuilder();
             foreach (var e in cfg.Entries)
             {
-                string href = $"{Uri.EscapeUriString(e.Path)}/index.html";
+                string href = $"{Uri.EscapeDataString(e.Path)}/index.html";
                 sb.AppendLine($"        <li><a href=\"{href}\"><strong>{EscapeHtml(e.Title)}</strong></a> — {EscapeHtml(e.Description ?? "")}</li>");
             }
             return sb.ToString();
diff --git a/NanoXLSX.Core/AssemblyInfo.cs b/NanoXLSX.Core/AssemblyInfo.cs
@@ -7,10 +7,23 @@
 // Core packages
 [assembly: InternalsVisibleTo("NanoXLSX.Writer")]
 [assembly: InternalsVisibleTo("NanoXLSX.Reader")]
-// Test packages
+// Included test packages
 [assembly: InternalsVisibleTo("NanoXLSX.Core.Test")]
 [assembly: InternalsVisibleTo("NanoXLSX.Writer-Reader.Test")]
 // Plug-ins (backlog / reserved)
 [assembly: InternalsVisibleTo("NanoXLSX.Formula")]
 [assembly: InternalsVisibleTo("NanoXLSX.Security")]
 [assembly: InternalsVisibleTo("NanoXLSX.Formatting")]
+[assembly: InternalsVisibleTo("NanoXLSX.Data")]
+[assembly: InternalsVisibleTo("NanoXLSX.Essentials")]
+[assembly: InternalsVisibleTo("NanoXLSX.Automatization")]
+[assembly: InternalsVisibleTo("NanoXLSX.Chart")]
+[assembly: InternalsVisibleTo("NanoXLSX.Compatibility")]
+// Plug-in Tests (backlog / reserved)
+[assembly: InternalsVisibleTo("NanoXLSX.Formula.Test")]
+[assembly: InternalsVisibleTo("NanoXLSX.Security.Test")]
+[assembly: InternalsVisibleTo("NanoXLSX.Formatting.Test")]
+[assembly: InternalsVisibleTo("NanoXLSX.Essentials.Test")]
+[assembly: InternalsVisibleTo("NanoXLSX.Automatization.Test")]
+[assembly: InternalsVisibleTo("NanoXLSX.Chart.Test")]
+[assembly: InternalsVisibleTo("NanoXLSX.Compatibility.Test")]
diff --git a/NanoXLSX.Core/Shortener.cs b/NanoXLSX.Core/Shortener.cs
@@ -11,9 +11,10 @@
 namespace NanoXLSX
 {
     /// <summary>
-    /// Class to provide access to the current worksheet with a shortened syntax. Note: The WS object can be null if the workbook was created without a worksheet. 
-    /// The object will be available as soon as the current worksheet is defined
+    /// Class to provide access to the current worksheet with a shortened syntax.
     /// </summary>
+    /// \remark <remarks>Note: The WS object can be null if the workbook was created without a worksheet. 
+    /// The object will be available as soon as the current worksheet is defined.</remarks> 
     public class Shortener
     {
         private Worksheet currentWorksheet;
diff --git a/NanoXLSX.Core/Worksheet.cs b/NanoXLSX.Core/Worksheet.cs
@@ -2771,7 +2771,7 @@ private static string GetUnusedWorksheetName(string name, Workbook workbook)
             if (match.Groups.Count > 1)
             {
                 prefix = match.Groups[1].Value;
-                int.TryParse(match.Groups[2].Value, out number);
+                _ = int.TryParse(match.Groups[2].Value, out number);
                 // if this failed, the start number is 0 (parsed number was >max. int32)
             }
             while (true)
diff --git a/NanoXLSX.Writer-Reader.Test/Style/WriteRead/FontWriteReadTest.cs b/NanoXLSX.Writer-Reader.Test/Style/WriteRead/FontWriteReadTest.cs
@@ -141,12 +141,12 @@ public void NameFontTest(string styleValue, object value)
         [InlineData(FontFamilyValue.Reserved7, uint.MaxValue, uint.MaxValue)]
         [InlineData(FontFamilyValue.Reserved8, ulong.MaxValue, ulong.MaxValue)]
         [InlineData(FontFamilyValue.Reserved9, SByte.MaxValue, 127)]
-        public void FamilyFontTest(FontFamilyValue styleValue, object givenValue, object expectdValue)
+        public void FamilyFontTest(FontFamilyValue styleValue, object givenValue, object expectedValue)
         {
             Style style = new Style();
 
             style.CurrentFont.Family = styleValue;
-            Cell cell = TestUtils.SaveAndReadStyledCell(givenValue, expectdValue, style, "A1");
+            Cell cell = TestUtils.SaveAndReadStyledCell(givenValue, expectedValue, style, "A1");
             Assert.Equal(styleValue, cell.CellStyle.CurrentFont.Family);
         }
 
diff --git a/NanoXlsx.Core.Test/Cells/CellTest.cs b/NanoXlsx.Core.Test/Cells/CellTest.cs
@@ -346,11 +346,11 @@ public void EqualsFailTest4()
         [InlineData("=A2", CellType.Default, CellType.String)]
         [InlineData("", CellType.Default, CellType.String)]
         [InlineData(null, CellType.Default, CellType.Empty)]
-        public void ResolveCellTypeTest(object givenValue, CellType givenCellType, CellType expectedCllType)
+        public void ResolveCellTypeTest(object givenValue, CellType givenCellType, CellType expectedCellType)
         {
             Cell cell = new Cell(givenValue, givenCellType, this.cellAddress);
             cell.ResolveCellType();
-            Assert.Equal(expectedCllType, cell.DataType);
+            Assert.Equal(expectedCellType, cell.DataType);
         }
 
         [Fact(DisplayName = "Test of the CompareTo method for dates and times")]
diff --git a/NanoXlsx.Core.Test/Cells/Types/ConvertArrayTest.cs b/NanoXlsx.Core.Test/Cells/Types/ConvertArrayTest.cs
@@ -29,7 +29,7 @@ public void ConvertSByteArrayTest()
         }
 
         [Fact(DisplayName = "Test of the ConvertArray method on decimal")]
-        public void ConvertDecimaleArrayTest()
+        public void ConvertDecimalArrayTest()
         {
             decimal[] array = new decimal[] { 0, 11.7m, 0.00001m, -22.5m, 100, -99, decimal.MinValue, decimal.MaxValue };
             AssertArray<decimal>(array, typeof(decimal));
diff --git a/NanoXlsx.Core.Test/Misc/LegacyPasswordTest.cs b/NanoXlsx.Core.Test/Misc/LegacyPasswordTest.cs
@@ -57,12 +57,12 @@ public void PasswordHashTest(string passwordHash)
         [InlineData(" ", " ")]
         [InlineData(null, null)]
         [InlineData("", null)]
-        public void GetAndSetPasswordTest(string givenPassword, string expectedpassword)
+        public void GetAndSetPasswordTest(string givenPassword, string expectedPassword)
         {
             LegacyPassword password = new LegacyPassword(LegacyPassword.PasswordType.WorkbookProtection);
             Assert.Null(password.GetPassword());
             password.SetPassword(givenPassword);
-            Assert.Equal(expectedpassword, password.GetPassword());
+            Assert.Equal(expectedPassword, password.GetPassword());
         }
 
         [Theory(DisplayName = "Test of the UnsetPassword function (legacy)")]
diff --git a/NanoXlsx.Core.Test/Styles/FontTest.cs b/NanoXlsx.Core.Test/Styles/FontTest.cs
@@ -256,7 +256,7 @@ public void ColorValueFailTest(string value)
         [InlineData(SchemeValue.Major)]
         [InlineData(SchemeValue.Minor)]
         [InlineData(SchemeValue.None)]
-        public void SchmeTest(SchemeValue value)
+        public void SchemeTest(SchemeValue value)
         {
             Font font = new Font();
             Assert.Equal(Font.DefaultFontScheme, font.Scheme); // default is minor
diff --git a/NanoXlsx.Core.Test/Utils/ComparatorsTest.cs b/NanoXlsx.Core.Test/Utils/ComparatorsTest.cs
@@ -20,14 +20,14 @@ public class ComparatorsTest
         [InlineData(null, "", true)] // Exception
         [InlineData(null, " ", false)]
         [InlineData(null, "ABC", false)]
-        public void CompareSecureStringsTest(string plaintext1, string plaintext2, bool excpectedEqual)
+        public void CompareSecureStringsTest(string plainText1, string plainText2, bool expectedEqual)
         {
-            SecureString sstr1 = GetSecureString(plaintext1);
-            SecureString sstr2 = GetSecureString(plaintext2);
+            SecureString sstr1 = GetSecureString(plainText1);
+            SecureString sstr2 = GetSecureString(plainText2);
             bool isEqual = Comparators.CompareSecureStrings(sstr1, sstr2);
-            Assert.Equal(excpectedEqual, isEqual);
+            Assert.Equal(expectedEqual, isEqual);
             isEqual = Comparators.CompareSecureStrings(sstr2, sstr1); // reverse
-            Assert.Equal(excpectedEqual, isEqual);
+            Assert.Equal(expectedEqual, isEqual);
         }
 
         [Theory(DisplayName = "Test of the comparator function CompareDiomensions")]
diff --git a/NanoXlsx.Core.Test/Workbooks/ShortenerTest.cs b/NanoXlsx.Core.Test/Workbooks/ShortenerTest.cs
@@ -136,10 +136,10 @@ public void DownTest2(int startColumn, int startRow, int number, int expectedCol
         [InlineData("F5", -3, true, "F2")]
         [InlineData("F5", -4, false, "A1")]
         [InlineData("F5", -4, true, "F1")]
-        public void DownTest3(string initialAddress, int number, bool keepColumn, string expectedAdrress)
+        public void DownTest3(string initialAddress, int number, bool keepColumn, string expectedAddress)
         {
             Workbook workbook = new Workbook("Sheet1");
-            AssertJumpKeep(workbook, workbook.WS.Down, initialAddress, number, keepColumn, expectedAdrress);
+            AssertJumpKeep(workbook, workbook.WS.Down, initialAddress, number, keepColumn, expectedAddress);
         }
 
         [Fact(DisplayName = "Test of the failing Down function with a negative row number")]
@@ -188,10 +188,10 @@ public void UpTest2(int startColumn, int startRow, int number, int expectedColum
         [InlineData("F5", -3, true, "F8")]
         [InlineData("F5", 4, false, "A1")]
         [InlineData("F5", 4, true, "F1")]
-        public void UpTest3(string initialAddress, int number, bool keepColumn, string expectedAdrress)
+        public void UpTest3(string initialAddress, int number, bool keepColumn, string expectedAddress)
         {
             Workbook workbook = new Workbook("Sheet1");
-            AssertJumpKeep(workbook, workbook.WS.Up, initialAddress, number, keepColumn, expectedAdrress);
+            AssertJumpKeep(workbook, workbook.WS.Up, initialAddress, number, keepColumn, expectedAddress);
         }
 
         [Fact(DisplayName = "Test of the failing Up function with a negative row number")]
@@ -239,10 +239,10 @@ public void RightTest2(int startColumn, int startRow, int number, int expectedCo
         [InlineData("F5", -3, true, "C5")]
         [InlineData("F5", -5, false, "A1")]
         [InlineData("F5", -5, true, "A5")]
-        public void RightTest3(string initialAddress, int number, bool keepColumn, string expectedAdrress)
+        public void RightTest3(string initialAddress, int number, bool keepColumn, string expectedAddress)
         {
             Workbook workbook = new Workbook("Sheet1");
-            AssertJumpKeep(workbook, workbook.WS.Right, initialAddress, number, keepColumn, expectedAdrress);
+            AssertJumpKeep(workbook, workbook.WS.Right, initialAddress, number, keepColumn, expectedAddress);
         }
 
         [Fact(DisplayName = "Test of the failing Right function with a negative row number")]
@@ -291,10 +291,10 @@ public void LeftTest2(int startColumn, int startRow, int number, int expectedCol
         [InlineData("F5", -3, true, "I5")]
         [InlineData("F5", 5, false, "A1")]
         [InlineData("F5", 5, true, "A5")]
-        public void LeftTest3(string initialAddress, int number, bool keepColumn, string expectedAdrress)
+        public void LeftTest3(string initialAddress, int number, bool keepColumn, string expectedAddress)
         {
             Workbook workbook = new Workbook("Sheet1");
-            AssertJumpKeep(workbook, workbook.WS.Left, initialAddress, number, keepColumn, expectedAdrress);
+            AssertJumpKeep(workbook, workbook.WS.Left, initialAddress, number, keepColumn, expectedAddress);
         }
 
         [Fact(DisplayName = "Test of the failing Left function with a negative row number")]
diff --git a/NanoXlsx.Core.Test/Worksheets/GetRowBoundariesTest.cs b/NanoXlsx.Core.Test/Worksheets/GetRowBoundariesTest.cs
@@ -206,7 +206,7 @@ public void GetFirstRowNumberTest()
         [Theory(DisplayName = "Test of the GetFirstRowNumber function with defined rows on an empty worksheet")]
         [InlineData(RowProperty.Height)]
         [InlineData(RowProperty.Hidden)]
-        public void GetFisrtRowNumberTest2(RowProperty rowProperty)
+        public void GetFirstRowNumberTest2(RowProperty rowProperty)
         {
             Worksheet worksheet = new Worksheet();
             if (rowProperty == RowProperty.Hidden)
@@ -363,7 +363,7 @@ public void GetFirstDataRowNumberTest3(RowProperty rowProperty)
         [Theory(DisplayName = "Test of the GetFirstDataRowNumber function with defined rows where cells are defined above the last row")]
         [InlineData(RowProperty.Height)]
         [InlineData(RowProperty.Hidden)]
-        public void GetfirstDataRowNumberTest4(RowProperty rowProperty)
+        public void GetFirstDataRowNumberTest4(RowProperty rowProperty)
         {
             Worksheet worksheet = new Worksheet();
             if (rowProperty == RowProperty.Hidden)

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ static string GenerateListItems(PluginConfig cfg)`
`195`	`195`	`var sb = new System.Text.StringBuilder();`
`196`	`196`	`foreach (var e in cfg.Entries)`
`197`	`197`	`{`
`198`		`- string href = $"{Uri.EscapeUriString(e.Path)}/index.html";`
	`198`	`+ string href = $"{Uri.EscapeDataString(e.Path)}/index.html";`
`199`	`199`	`sb.AppendLine($" <li><a href=\"{href}\"><strong>{EscapeHtml(e.Title)}</strong></a> — {EscapeHtml(e.Description ?? "")}</li>");`
`200`	`200`	`}`
`201`	`201`	`return sb.ToString();`
Original file line number	Diff line number	Diff line change
`@@ -11,9 +11,10 @@`
`11`	`11`	`namespace NanoXLSX`
`12`	`12`	`{`
`13`	`13`	`/// <summary>`
`14`		`- /// Class to provide access to the current worksheet with a shortened syntax. Note: The WS object can be null if the workbook was created without a worksheet.`
`15`		`- /// The object will be available as soon as the current worksheet is defined`
	`14`	`+ /// Class to provide access to the current worksheet with a shortened syntax.`
`16`	`15`	`/// </summary>`
	`16`	`+ /// \remark <remarks>Note: The WS object can be null if the workbook was created without a worksheet.`
	`17`	`+ /// The object will be available as soon as the current worksheet is defined.</remarks>`
`17`	`18`	`public class Shortener`
`18`	`19`	`{`
`19`	`20`	`private Worksheet currentWorksheet;`
Original file line number	Diff line number	Diff line change
`@@ -2771,7 +2771,7 @@ private static string GetUnusedWorksheetName(string name, Workbook workbook)`
`2771`	`2771`	`if (match.Groups.Count > 1)`
`2772`	`2772`	`{`
`2773`	`2773`	`prefix = match.Groups[1].Value;`
`2774`		`- int.TryParse(match.Groups[2].Value, out number);`
	`2774`	`+ _ = int.TryParse(match.Groups[2].Value, out number);`
`2775`	`2775`	`// if this failed, the start number is 0 (parsed number was >max. int32)`
`2776`	`2776`	`}`
`2777`	`2777`	`while (true)`
Original file line number	Diff line number	Diff line change
`@@ -141,12 +141,12 @@ public void NameFontTest(string styleValue, object value)`
`141`	`141`	`[InlineData(FontFamilyValue.Reserved7, uint.MaxValue, uint.MaxValue)]`
`142`	`142`	`[InlineData(FontFamilyValue.Reserved8, ulong.MaxValue, ulong.MaxValue)]`
`143`	`143`	`[InlineData(FontFamilyValue.Reserved9, SByte.MaxValue, 127)]`
`144`		`- public void FamilyFontTest(FontFamilyValue styleValue, object givenValue, object expectdValue)`
	`144`	`+ public void FamilyFontTest(FontFamilyValue styleValue, object givenValue, object expectedValue)`
`145`	`145`	`{`
`146`	`146`	`Style style = new Style();`
`147`	`147`
`148`	`148`	`style.CurrentFont.Family = styleValue;`
`149`		`- Cell cell = TestUtils.SaveAndReadStyledCell(givenValue, expectdValue, style, "A1");`
	`149`	`+ Cell cell = TestUtils.SaveAndReadStyledCell(givenValue, expectedValue, style, "A1");`
`150`	`150`	`Assert.Equal(styleValue, cell.CellStyle.CurrentFont.Family);`
`151`	`151`	`}`
`152`	`152`
Original file line number	Diff line number	Diff line change
`@@ -346,11 +346,11 @@ public void EqualsFailTest4()`
`346`	`346`	`[InlineData("=A2", CellType.Default, CellType.String)]`
`347`	`347`	`[InlineData("", CellType.Default, CellType.String)]`
`348`	`348`	`[InlineData(null, CellType.Default, CellType.Empty)]`
`349`		`- public void ResolveCellTypeTest(object givenValue, CellType givenCellType, CellType expectedCllType)`
	`349`	`+ public void ResolveCellTypeTest(object givenValue, CellType givenCellType, CellType expectedCellType)`
`350`	`350`	`{`
`351`	`351`	`Cell cell = new Cell(givenValue, givenCellType, this.cellAddress);`
`352`	`352`	`cell.ResolveCellType();`
`353`		`- Assert.Equal(expectedCllType, cell.DataType);`
	`353`	`+ Assert.Equal(expectedCellType, cell.DataType);`
`354`	`354`	`}`
`355`	`355`
`356`	`356`	`[Fact(DisplayName = "Test of the CompareTo method for dates and times")]`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public void ConvertSByteArrayTest()`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`[Fact(DisplayName = "Test of the ConvertArray method on decimal")]`
`32`		`- public void ConvertDecimaleArrayTest()`
	`32`	`+ public void ConvertDecimalArrayTest()`
`33`	`33`	`{`
`34`	`34`	`decimal[] array = new decimal[] { 0, 11.7m, 0.00001m, -22.5m, 100, -99, decimal.MinValue, decimal.MaxValue };`
`35`	`35`	`AssertArray<decimal>(array, typeof(decimal));`
Original file line number	Diff line number	Diff line change
`@@ -57,12 +57,12 @@ public void PasswordHashTest(string passwordHash)`
`57`	`57`	`[InlineData(" ", " ")]`
`58`	`58`	`[InlineData(null, null)]`
`59`	`59`	`[InlineData("", null)]`
`60`		`- public void GetAndSetPasswordTest(string givenPassword, string expectedpassword)`
	`60`	`+ public void GetAndSetPasswordTest(string givenPassword, string expectedPassword)`
`61`	`61`	`{`
`62`	`62`	`LegacyPassword password = new LegacyPassword(LegacyPassword.PasswordType.WorkbookProtection);`
`63`	`63`	`Assert.Null(password.GetPassword());`
`64`	`64`	`password.SetPassword(givenPassword);`
`65`		`- Assert.Equal(expectedpassword, password.GetPassword());`
	`65`	`+ Assert.Equal(expectedPassword, password.GetPassword());`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`[Theory(DisplayName = "Test of the UnsetPassword function (legacy)")]`
Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,7 @@ public void ColorValueFailTest(string value)`
`256`	`256`	`[InlineData(SchemeValue.Major)]`
`257`	`257`	`[InlineData(SchemeValue.Minor)]`
`258`	`258`	`[InlineData(SchemeValue.None)]`
`259`		`- public void SchmeTest(SchemeValue value)`
	`259`	`+ public void SchemeTest(SchemeValue value)`
`260`	`260`	`{`
`261`	`261`	`Font font = new Font();`
`262`	`262`	`Assert.Equal(Font.DefaultFontScheme, font.Scheme); // default is minor`