NPE in Page.getItemsAsList()

[jrabun]

I noticed a NullPointerException in my application's logs, and it was coming from the Page.getItemsAsList() method. As discussed in #271 , the Client's HTTP layer returns null in the case of a 404 error (which may occur for various reasons). This means the T[] items array created by a call to Client.getQueues() may end up null. However, Page.getItemsAsList() calls Arrays.asList(items) without checking to see if items is null, which may result in an NPE.

I wasn't sure if this behavior is a bug or a "feature", so I thought I'd ask here first before opening an issue. I can of course check to see whether items is null myself before attempting to convert it to a list, so this isn't a deal-breaker. However, I would have expected this method to return null, or perhaps an empty list, rather than throwing an NPE.

[michaelklishin]

@jrabun it's not a feature, please submit a PR so that an empty list.

[michaelklishin]

Contributed by @jrabun in #544.