Use RabbitMQ 4 in system tests

Author: Zerpet

.github/workflows/build-test-publish.yml

@@ -138,6 +138,7 @@ jobs:
     - name: Build manifest
       env:
         RELEASE_VERSION: ${{ steps.meta.outputs.version }}
+      shell: bash # important: because it sets pipefail, so that the job fails if there are failures in the command pipe
       run: |
         make install-tools
         pushd config/installation

.github/workflows/testing-and-publishing-OLM-bundle.yml renamed to .github/workflows/olm.yml

@@ -107,6 +107,7 @@ jobs:
     - name: System tests
       env:
         IMG: local/rabbitmq-topology-operator:pr
+      shell: bash # important: because it sets pipefail, so that the job fails if there are failures in the command pipe
       run: |
         kind load image-archive /tmp/operator.tar --name topology-operator-testing
         make cert-manager cmctl

.github/workflows/pr.yml

@@ -11,6 +11,7 @@ resources:
 patches:
 - path: manager_webhook_patch.yaml
 - path: webhookcainjection_patch.yaml
+# TODO: remove webhook ca injection? we remove it using sed in Makefile
 
 images:
 - name: controller

config/default/base/kustomization.yaml

@@ -184,7 +184,7 @@ func basicTestRabbitmqCluster(name, namespace string) *rabbitmqv1beta1.RabbitmqC
 		},
 		Spec: rabbitmqv1beta1.RabbitmqClusterSpec{
 			Replicas: ptr.To(int32(1)),
-			Image:    "rabbitmq:3-management",
+			Image:    "rabbitmq:4-management",
 			Resources: &corev1.ResourceRequirements{
 				Requests: corev1.ResourceList{
 					corev1.ResourceMemory: resource.MustParse("100Mi"),