Update system_tests/federation_system_test.go

Co-authored-by: Aitor Pérez Cedres <[email protected]>

Author: aawoznia26

system_tests/federation_system_test.go

@@ -126,42 +126,44 @@ var _ = Describe("federation", func() {
 		Expect(err.Error()).To(ContainSubstring("Object Not Found"))
 	})
 
-	It("with DeletionPolicy=retain, deletes k8s resource but keeps the federation in RabbitMQ", func() {
-		federationWithRetain := &topology.Federation{
-			ObjectMeta: metav1.ObjectMeta{
-				Name:      "retain-policy-test",
-				Namespace: namespace,
-			},
-			Spec: topology.FederationSpec{
-				Name:           "retain-policy-test",
-				UriSecret:      &corev1.LocalObjectReference{Name: federationUriSecret.Name},
-				DeletionPolicy: "retain",
-				RabbitmqClusterReference: topology.RabbitmqClusterReference{
-					Name: rmq.Name,
+	When("deletion policy is retain", func() {
+		It("deletes k8s resource but keeps the federation in RabbitMQ", func() {
+			federationWithRetain := &topology.Federation{
+				ObjectMeta: metav1.ObjectMeta{
+					Name:      "retain-policy-test",
+					Namespace: namespace,
 				},
-			},
-		}
+				Spec: topology.FederationSpec{
+					Name:           "retain-policy-test",
+					UriSecret:      &corev1.LocalObjectReference{Name: federationUriSecret.Name},
+					DeletionPolicy: "retain",
+					RabbitmqClusterReference: topology.RabbitmqClusterReference{
+						Name: rmq.Name,
+					},
+				},
+			}
 
-		By("creating a federation with retain policy")
-		Expect(k8sClient.Create(ctx, federationWithRetain, &client.CreateOptions{})).To(Succeed())
+			By("creating a federation with retain policy")
+			Expect(k8sClient.Create(ctx, federationWithRetain, &client.CreateOptions{})).To(Succeed())
 
-		By("waiting for the federation to be created in RabbitMQ")
-		Eventually(func() error {
-			_, err := rabbitClient.GetFederationUpstream("/", federationWithRetain.Spec.Name)
-			return err
-		}, 30, 2).ShouldNot(HaveOccurred())
+			By("waiting for the federation to be created in RabbitMQ")
+			Eventually(func() error {
+				_, err := rabbitClient.GetFederationUpstream("/", federationWithRetain.Spec.Name)
+				return err
+			}, 30, 2).ShouldNot(HaveOccurred())
 
-		By("deleting the k8s resource")
-		Expect(k8sClient.Delete(ctx, federationWithRetain)).To(Succeed())
+			By("deleting the k8s resource")
+			Expect(k8sClient.Delete(ctx, federationWithRetain)).To(Succeed())
 
-		By("verifying k8s resource is gone")
-		Eventually(func() bool {
-			err := k8sClient.Get(ctx, types.NamespacedName{Name: federationWithRetain.Name, Namespace: federationWithRetain.Namespace}, &topology.Federation{})
-			return apierrors.IsNotFound(err)
-		}, 30, 2).Should(BeTrue())
+			By("verifying k8s resource is gone")
+			Eventually(func() bool {
+				err := k8sClient.Get(ctx, types.NamespacedName{Name: federationWithRetain.Name, Namespace: federationWithRetain.Namespace}, &topology.Federation{})
+				return apierrors.IsNotFound(err)
+			}, 30, 2).Should(BeTrue())
 
-		By("verifying federation still exists in RabbitMQ")
-		_, err := rabbitClient.GetFederationUpstream("/", federationWithRetain.Spec.Name)
-		Expect(err).NotTo(HaveOccurred())
+			By("verifying federation still exists in RabbitMQ")
+			_, err := rabbitClient.GetFederationUpstream("/", federationWithRetain.Spec.Name)
+			Expect(err).NotTo(HaveOccurred())
+		})
 	})
 })