From 8e99e1c9ca9fdd0268fd27735fcdf2cb56c43ebe Mon Sep 17 00:00:00 2001 From: Aitor Perez <1515757+Zerpet@users.noreply.github.com> Date: Wed, 22 Jan 2025 13:04:32 +0000 Subject: [PATCH 1/2] Fix build-test-publish workflow As part of 8d0cc5ea2bcff109f49fddcdb1b0e206ac9052e6 to remove old code, a line too much was pruned. This workflow still requires manifest generation for system tests. The job to build the operator image was not alerting on failure, and this failure went unnoticed. --- .github/workflows/build-test-publish.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/build-test-publish.yml b/.github/workflows/build-test-publish.yml index 1030cb36..f6922e40 100644 --- a/.github/workflows/build-test-publish.yml +++ b/.github/workflows/build-test-publish.yml @@ -138,6 +138,7 @@ jobs: kustomize edit set image \ rabbitmqoperator/messaging-topology-operator-dev=rabbitmqoperator/messaging-topology-operator:"${RELEASE_VERSION}" popd + make generate-manifests - name: Upload operator manifests uses: actions/upload-artifact@v4 @@ -147,6 +148,14 @@ jobs: retention-days: 2 if-no-files-found: error + - name: Notify Google Chat + if: failure() + uses: SimonScholz/google-chat-action@main + with: + webhookUrl: '${{ secrets.GOOGLE_CHAT_WEBHOOK_URL }}' + jobStatus: ${{ job.status }} + title: Messaging Topology Operator - Build Operator + system_tests: name: Local system tests (stable k8s) runs-on: ubuntu-latest From 6c0c2c4dfd4ec36795a9c56d4e3d356634e643ad Mon Sep 17 00:00:00 2001 From: Aitor Perez <1515757+Zerpet@users.noreply.github.com> Date: Wed, 22 Jan 2025 13:10:16 +0000 Subject: [PATCH 2/2] Use the runner temp folder GitHub runners don't necessary use /tmp as their temporary folder --- .github/workflows/build-test-publish.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-test-publish.yml b/.github/workflows/build-test-publish.yml index f6922e40..8b344904 100644 --- a/.github/workflows/build-test-publish.yml +++ b/.github/workflows/build-test-publish.yml @@ -195,7 +195,7 @@ jobs: uses: actions/download-artifact@v4 with: name: operator_image - path: /tmp + path: ${{ runner.temp }}/operator-image - name: Install Carvel uses: carvel-dev/setup-action@v2.0.1 @@ -213,7 +213,7 @@ jobs: - name: Install operator from build run: | - kind load image-archive /tmp/operator.tar --name system-testing + kind load image-archive ${{ runner.temp }}/operator-image/operator.tar --name system-testing ytt -f tmp/messaging-topology-operator-with-certmanager.yaml -f config/ytt_overlays/never_pull.yml | kubectl apply -f- kubectl --namespace=rabbitmq-system wait --for=condition=Available deployment/messaging-topology-operator