dialyzer fixes

Author: kjnilsson

src/ra.erl

@@ -157,14 +157,14 @@ start_in(DataDir) ->
     ra_env:configure_logger(logger),
     LogFile = filename:join(DataDir, "ra.log"),
     SaslFile = filename:join(DataDir, "ra_sasl.log"),
-    logger:remove_handler(ra_handler),
+    _ = logger:remove_handler(ra_handler),
     ok = logger:set_primary_config(level, debug),
     Config = #{config => #{file => LogFile}},
     ok = logger:add_handler(ra_handler, logger_std_h, Config),
-    application:load(sasl),
-    application:set_env(sasl, sasl_error_logger, {file, SaslFile}),
-    application:stop(sasl),
-    application:start(sasl),
+    ok = application:load(sasl),
+    ok = application:set_env(sasl, sasl_error_logger, {file, SaslFile}),
+    ok = application:stop(sasl),
+    ok = application:start(sasl),
     _ = error_logger:tty(false),
     start([{data_dir, DataDir}]).
 

src/ra_kv_harness.erl

@@ -80,11 +80,14 @@ run(NumOperations) ->
     run(NumOperations, #{}).
 
 read_all_keys() ->
-        [_ = ra_kv:get({?CLUSTER_NAME,
+    [begin
+         _ = ra_kv:get({?CLUSTER_NAME,
                         node()},
-                       <<"key_",(integer_to_binary(N))/binary>>, 1000)
-         || N <- lists:seq(1, ?MAX_KEY)],
-        ok.
+                       <<"key_",(integer_to_binary(N))/binary>>, 1000),
+         ok
+     end
+     || N <- lists:seq(1, ?MAX_KEY)],
+    ok.
 
 read_all_keys_loop(Members0) when is_list(Members0) ->
     receive
@@ -114,9 +117,9 @@ read_all_keys_loop(Members0) when is_list(Members0) ->
 run(NumOperations, Options) when NumOperations > 0 ->
     % Start with a random number of nodes between 1 and 7
     NumNodes = rand:uniform(7),
-    logger:set_primary_config(level, warning),
-    application:set_env(sasl, sasl_error_logger, false),
-    application:stop(sasl),
+    ok = logger:set_primary_config(level, warning),
+    ok = application:set_env(sasl, sasl_error_logger, false),
+    ok = application:stop(sasl),
     log("~s Starting cluster with ~p nodes~n", [timestamp(), NumNodes]),
     case setup_cluster(NumNodes, Options) of
         {ok, Members, PeerNodes} ->
@@ -705,8 +708,9 @@ execute_operation(State, {network_partition}) ->
                     % Block communication between partitioned node and other nodes
                     % The harness node (current node) maintains access to all nodes
                     [begin
-                         erpc:call(NodeToPartitionName, inet_tcp_proxy_dist, block, [OtherNode]),
-                         erpc:call(OtherNode, inet_tcp_proxy_dist, block, [NodeToPartitionName])
+                         _ = erpc:call(NodeToPartitionName, inet_tcp_proxy_dist, block, [OtherNode]),
+                         _ = erpc:call(OtherNode, inet_tcp_proxy_dist, block, [NodeToPartitionName]),
+                         ok
                      end || OtherNode <- OtherNodes],
 
             State#{operations_count => OpCount + 1,
@@ -799,7 +803,7 @@ perform_consistency_check(State, MembersToValidate) ->
 
             % Write full details to log file with difference analysis
             LogEntry = format_consistency_failure(MembersToValidate, ValidationResults),
-            file:write_file("ra_kv_harness.log", LogEntry, [append]),
+            ok = file:write_file("ra_kv_harness.log", LogEntry, [append]),
 
             FailedOps = maps:get(failed_ops, State),
             State#{failed_ops => FailedOps + 1, remaining_ops => 0, consistency_failed => true}

src/ra_log.erl

@@ -262,7 +262,8 @@ init(#{uid := UId,
     [begin
          ?DEBUG("~ts: deleting overwritten segment ~w",
                 [LogId, SR]),
-         catch prim_file:delete(filename:join(Dir, F))
+         _ = catch prim_file:delete(filename:join(Dir, F)),
+         ok
      end
      || {F, _} = SR <- SegRefs -- ra_log_segments:segment_refs(Reader)],
 
@@ -885,7 +886,8 @@ handle_event({segments, TidSeqs, NewSegs},
                   [begin
                     ?DEBUG("~ts: deleting overwritten segment ~w",
                            [LogId, SR]),
-                    catch prim_file:delete(filename:join(Dir, F))
+                    _ = catch prim_file:delete(filename:join(Dir, F)),
+                    ok
                    end
                    || {F, _} = SR <- OverwrittenSegRefs],
                   ok

src/ra_log_segments.erl

@@ -288,7 +288,7 @@ handle_compaction_result(#compaction_result{unreferenced = Unreferenced,
                                end
                        end, Open0, Unreferenced),
     Fun = fun () ->
-                  [prim_file:delete(filename:join(Dir, F))
+                  [ok = prim_file:delete(filename:join(Dir, F))
                    || F <- Unreferenced],
                   purge_dangling_symlinks(Dir),
                   ok
@@ -318,7 +318,7 @@ handle_compaction_result(#compaction_result{unreferenced = Unreferenced,
                               FilteredRefs, lists:reverse(CompactedSegRefs)),
     Open = ra_flru:evict_all(Open0),
     Fun = fun () ->
-                  [prim_file:delete(filename:join(Dir, F))
+                  [ok = prim_file:delete(filename:join(Dir, F))
                    || F <- Unreferenced],
                   purge_dangling_symlinks(Dir),
                   ok

src/ra_lol.erl

@@ -262,7 +262,8 @@ basic_test() ->
                         end
                 end,
     [begin
-         {T, _} = ?MODULE:search(SearchFun(T), L1)
+         {T, _} = ?MODULE:search(SearchFun(T), L1),
+         ok
      end || T <- Items ++ [101]],
 
     %% test searching with a continuation