Skip to content

Commit 0d0cdf1

Browse files
committed
Use absolute paths for all symlinks.
Hopefully this will work better on windows.
1 parent 2024a18 commit 0d0cdf1

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

src/ra_log_segments.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -873,7 +873,7 @@ make_symlinks(Dir, To, From)
873873
_ = prim_file:delete(SymFn),
874874
%% make a symlink from the compacted target segment to a new .link
875875
%% where the compacted indexes now can be found
876-
ok = prim_file:make_symlink(filename:basename(To), SymFn),
876+
ok = prim_file:make_symlink(To, SymFn),
877877
%% rename to link to replace original segment
878878
ok = prim_file:rename(SymFn, SegFn)
879879
end || FromFn <- From],

test/ra_log_segments_SUITE.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -731,7 +731,7 @@ major_deletes_orphaned_segments(Config) ->
731731
%% Create symlink with a name in the orphaned range (e.g., 0000000000000002.segment)
732732
%% but we'll use a different name to avoid conflicts
733733
SymlinkName = filename:join(Dir, "0000000000000002a.segment"),
734-
ok = prim_file:make_symlink(filename:basename(SymlinkTarget), SymlinkName),
734+
ok = prim_file:make_symlink(SymlinkTarget, SymlinkName),
735735
ct:pal("Created test symlink: ~p -> ~p", [SymlinkName, SymlinkTarget]),
736736

737737
%% Now run major compaction - this should delete the orphaned regular files

test/ra_log_wal_SUITE.erl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ init_per_testcase(TestCase, Config) ->
114114
Names = maps:get(names, Sys),
115115
WalConf = #{dir => Dir,
116116
system => ?SYS,
117-
system => default,
118117
names => Names#{segment_writer => self()},
119118
max_size_bytes => ?MAX_SIZE_BYTES},
120119
_ = ets:new(ra_log_snapshot_state,

0 commit comments

Comments
 (0)