Feedback

Author: mkuratczyk

src/ra_log_wal.erl

@@ -279,7 +279,9 @@ init(#{dir := Dir, system := System} = Conf0) ->
     process_flag(message_queue_data, off_heap),
     process_flag(min_bin_vheap_size, MinBinVheapSize),
     process_flag(min_heap_size, MinHeapSize),
-    CRef = ra_counters:new(WalName, ?COUNTER_FIELDS, #{ra_system => System, module => ?MODULE}),
+    CRef = ra_counters:new(WalName,
+                           ?COUNTER_FIELDS,
+                           #{ra_system => System, module => ?MODULE}),
     Conf = #conf{dir = Dir,
                  segment_writer = SegWriter,
                  compute_checksums = ComputeChecksums,

src/ra_server.hrl

@@ -16,7 +16,7 @@
          uid :: ra_uid(),
          log_id :: unicode:chardata(),
          metrics_key :: term(),
-         metrics_labels :: map(),
+         metrics_labels :: seshat:labels_map(),
          machine :: ra_machine:machine(),
          machine_version :: ra_machine:version(),
          machine_versions :: [{ra_index(), ra_machine:version()}, ...],

src/ra_server_proc.erl

@@ -317,9 +317,9 @@ do_init(#{id := Id,
     true = ets:insert(ra_state, {Key, init, unknown}),
     process_flag(trap_exit, true),
     MetricLabels = maps:get(metrics_labels, Config0, #{}),
-    Config = #{counter := Counter,
-               system_config := #{names := Names} = SysConf} = maps:merge(config_defaults(Id, MetricLabels),
-                                                      Config0),
+    Config = maps:merge(config_defaults(Id, MetricLabels), Config0),
+    #{counter := Counter,
+      system_config := #{names := Names} = SysConf} = Config,
     MsgQData = maps:get(message_queue_data, SysConf, off_heap),
     MinBinVheapSize = maps:get(server_min_bin_vheap_size, SysConf,
                                ?MIN_BIN_VHEAP_SIZE),
@@ -1807,7 +1807,8 @@ config_defaults(ServerId, MetricLabels) ->
     Counter = case ra_counters:fetch(ServerId) of
                   undefined ->
                       ra_counters:new(ServerId,
-                                      {persistent_term, ?FIELDSPEC_KEY}, MetricLabels);
+                                      {persistent_term, ?FIELDSPEC_KEY},
+                                      MetricLabels);
                   C ->
                       C
               end,