* No need to start toxiproxy yet

* Use `uint.MinValue` to mean `unlimited` for max frame size
*

Author: lukebakken

.github/workflows/build-test.yaml

@@ -26,14 +26,17 @@ jobs:
         run: dotnet format ${{ github.workspace }}/Build.csproj --no-restore --verify-no-changes
       - name: Start RabbitMQ
         id: start-rabbitmq
-        run: ${{ github.workspace }}/.ci/ubuntu/gha-setup.sh toxiproxy
+        # Note: not using toxiproxy yet
+        # run: ${{ github.workspace }}/.ci/ubuntu/gha-setup.sh toxiproxy
+        run: ${{ github.workspace }}/.ci/ubuntu/gha-setup.sh
       - name: Test
         run: dotnet test ${{ github.workspace }}/Build.csproj --no-restore --no-build --logger "console;verbosity=detailed" /p:AltCover=true
       - name: Check for errors in RabbitMQ logs
         run: ${{ github.workspace}}/.ci/ubuntu/gha-log-check.sh
-      - name: Maybe collect toxiproxy logs
-        if: failure()
-        run: docker logs rabbitmq-amqp-dotnet-client-toxiproxy > ${{ github.workspace }}/.ci/ubuntu/log/toxiproxy.log
+      # Note: not using toxiproxy yet
+      # - name: Maybe collect toxiproxy logs
+      #   if: failure()
+      #   run: docker logs rabbitmq-amqp-dotnet-client-toxiproxy > ${{ github.workspace }}/.ci/ubuntu/log/toxiproxy.log
       - name: Maybe upload RabbitMQ logs
         if: failure()
         uses: actions/upload-artifact@v4

RabbitMQ.AMQP.Client/Impl/AmqpConnection.cs

@@ -198,14 +198,18 @@ private async Task EnsureConnection()
             var open = new Open
             {
                 HostName = $"vhost:{_connectionSettings.VirtualHost}",
-                // Note: when set here, there is no need to set cf.AMQP.MaxFrameSize
-                MaxFrameSize = _connectionSettings.MaxFrameSize,
                 Properties = new Fields()
                 {
                     [new Symbol("connection_name")] = _connectionSettings.ConnectionName,
                 }
             };
 
+            if (_connectionSettings.MaxFrameSize > uint.MinValue)
+            {
+                // Note: when set here, there is no need to set cf.AMQP.MaxFrameSize
+                open.MaxFrameSize = _connectionSettings.MaxFrameSize;
+            }
+
             void onOpened(Amqp.IConnection connection, Open open1)
             {
                 Trace.WriteLine(TraceLevel.Verbose, $"Connection opened. Info: {ToString()}");

RabbitMQ.AMQP.Client/Impl/ConnectionSettings.cs

@@ -145,8 +145,12 @@ public ConnectionSettings(string scheme, string host, int port,
         _virtualHost = virtualHost;
         _saslMechanism = saslMechanism;
 
-        // TODO validate at least 512 bytes
         _maxFrameSize = maxFrameSize;
+        if (_maxFrameSize != uint.MinValue && _maxFrameSize < 512)
+        {
+            throw new ArgumentOutOfRangeException(nameof(maxFrameSize),
+                "maxFrameSize must be greater or equal to 512");
+        }
 
         _tlsSettings = tlsSettings;
 

RabbitMQ.AMQP.Client/Impl/Consts.cs

@@ -6,5 +6,7 @@ public class Consts
     public const string Key = "key";
     public const string Queues = "queues";
     public const string Bindings = "bindings";
-    public const uint DefaultMaxFrameSize = 256 * 1024; // NOTE: from Azure/amqpnetlite
+    // public const uint DefaultMaxFrameSize = uint.MinValue; // NOTE: Azure/amqpnetlite uses 256 * 1024
+    // TODO: change to uint.MinValue when https://github.com/rabbitmq/rabbitmq-server/pull/11843 is merged
+    public const uint DefaultMaxFrameSize = 256 * 1024;
 }