* Don't log an expected exception.

Author: lukebakken

RabbitMQ.AMQP.Client/Impl/AbstractLifeCycle.cs

@@ -47,7 +47,7 @@ protected void ThrowIfClosed()
                 case State.Closing:
                     throw new AmqpNotOpenException("Resource is closing");
                 case State.Reconnecting:
-                    throw new AmqpNotOpenException("Resource is Reconnecting");
+                    throw new AmqpNotOpenException("Resource is reconnecting");
                 case State.Open:
                     break;
                 default:

RabbitMQ.AMQP.Client/Impl/AmqpEnvironment.cs

@@ -46,14 +46,14 @@ public async Task<IConnection> CreateConnectionAsync(IConnectionSettings connect
             return c;
         }
 
-        public async Task<IConnection> CreateConnectionAsync()
+        public Task<IConnection> CreateConnectionAsync()
         {
-            if (ConnectionSettings != null)
+            if (ConnectionSettings is null)
             {
-                return await CreateConnectionAsync(ConnectionSettings).ConfigureAwait(false);
+                throw new ConnectionException("Connection settings are not set");
             }
 
-            throw new ConnectionException("Connection settings are not set");
+            return CreateConnectionAsync(ConnectionSettings);
         }
 
         public ReadOnlyCollection<IConnection> GetConnections() =>

Tests/Rpc/RecoveryRPCTests.cs

@@ -33,11 +33,11 @@ public async Task RpcServerAndClientShouldRecoverAfterKillConnection()
             int messagesReceived = 0;
             IRpcServer rpcServer = await connection.RpcServerBuilder()
                 .RequestQueue(rpcRequestQueueName)
-                .Handler(async (context, message) =>
+                .Handler((context, message) =>
                 {
                     Interlocked.Increment(ref messagesReceived);
                     var reply = context.Message("pong");
-                    return await Task.FromResult(reply);
+                    return Task.FromResult(reply);
                 })
                 .BuildAsync();
 
@@ -62,9 +62,13 @@ public async Task RpcServerAndClientShouldRecoverAfterKillConnection()
                     messagesConfirmed++;
                     Assert.Equal("pong", response.Body());
                 }
+                catch (AmqpNotOpenException)
+                {
+                    await Task.Delay(700);
+                }
                 catch (Exception e)
                 {
-                    _testOutputHelper.WriteLine($"Error sending message: {e.Message}");
+                    _testOutputHelper.WriteLine($"[ERROR] unexpected exception while sending message: {e.Message}");
                     await Task.Delay(700);
                 }