* No more skipped tests

Author: lukebakken

Tests/ConnectionRecoveryTests.cs

@@ -8,12 +8,11 @@
 using System.Threading.Tasks;
 using RabbitMQ.AMQP.Client;
 using RabbitMQ.AMQP.Client.Impl;
+using Xunit;
 using Xunit.Abstractions;
 
 namespace Tests;
 
-using Xunit;
-
 internal class FakeBackOffDelayPolicyDisabled : IBackOffDelayPolicy
 {
     public int Delay()
@@ -53,7 +52,7 @@ public class ConnectionRecoveryTests(ITestOutputHelper testOutputHelper)
     /// The error _must_ be null when the connection is closed normally even the recovery is activated. 
     /// </summary>
     /// <param name="activeRecovery"> If the recovery is enabled.</param>
-    [SkippableTheory]
+    [Theory]
     [InlineData(true)]
     [InlineData(false)]
     public async Task NormalCloseTheStatusShouldBeCorrectAndErrorNull(bool activeRecovery)
@@ -103,12 +102,11 @@ public async Task NormalCloseTheStatusShouldBeCorrectAndErrorNull(bool activeRec
     /// then the connection is closed normally. so the status should be:
     ///  - From Open to Closed
     /// </summary>
-    [SkippableFact]
+    [Fact]
     public async Task UnexpectedCloseTheStatusShouldBeCorrectAndErrorNotNull()
     {
         Assert.Null(_connection);
         Assert.Null(_management);
-        // Skip.If(true, "rabbitmq-dotnet-client-87");
 
         IConnection connection = await AmqpConnection.CreateAsync(
             ConnectionSettingBuilder.Create().ContainerId(_containerId).RecoveryConfiguration(
@@ -177,12 +175,11 @@ public async Task UnexpectedCloseTheStatusShouldBeCorrectAndErrorNotNull()
     /// By default, the backoff is active it will be disabled after some failed attempts.
     /// See the BackOffDelayPolicy class for more details.
     /// </summary>
-    [SkippableFact]
+    [Fact]
     public async Task OverrideTheBackOffWithBackOffDisabled()
     {
         Assert.Null(_connection);
         Assert.Null(_management);
-        // Skip.If(true, "rabbitmq-dotnet-client-87");
 
         IConnection connection = await AmqpConnection.CreateAsync(
             ConnectionSettingBuilder.Create().ContainerId(_containerId).RecoveryConfiguration(
@@ -241,12 +238,11 @@ public async Task OverrideTheBackOffWithBackOffDisabled()
     /// When the topology-recover is Enabled the temp queues should be recovered.
     /// the Queue is a temp queue with the Auto-Delete and Exclusive flag set to true. 
     /// </summary>
-    [SkippableFact]
+    [Fact]
     public async Task RecoveryTopologyShouldRecoverTheTempQueues()
     {
         Assert.Null(_connection);
         Assert.Null(_management);
-        // Skip.If(true, "rabbitmq-dotnet-client-87");
 
         string queueName = $"temp-queue-should-recover-{true}";
         IConnection connection = await AmqpConnection.CreateAsync(
@@ -290,12 +286,11 @@ public async Task RecoveryTopologyShouldRecoverTheTempQueues()
     /// When the topology-recover is  Disabled the temp queues should not be recovered.
     /// the Queue is a temp queue with the Auto-Delete and Exclusive flag set to true. 
     /// </summary>
-    [SkippableFact]
+    [Fact]
     public async Task RecoveryTopologyShouldNotRecoverTheTempQueues()
     {
         Assert.Null(_connection);
         Assert.Null(_management);
-        // Skip.If(true, "rabbitmq-dotnet-client-87");
 
         string queueName = $"temp-queue-should-recover-{false}";
         IConnection connection = await AmqpConnection.CreateAsync(
@@ -328,14 +323,13 @@ public async Task RecoveryTopologyShouldNotRecoverTheTempQueues()
         Assert.Equal(0, topologyListener.QueueCount());
     }
 
-    [SkippableTheory]
+    [Theory]
     [InlineData(true)]
     [InlineData(false)]
     public async Task RecoveryTopologyShouldRecoverExchanges(bool topologyEnabled)
     {
         Assert.Null(_connection);
         Assert.Null(_management);
-        // Skip.If(true, "rabbitmq-dotnet-client-87");
 
         const string exchangeName = "exchange-should-recover";
         IConnection connection = await AmqpConnection.CreateAsync(
@@ -388,14 +382,13 @@ public async Task RecoveryTopologyShouldRecoverExchanges(bool topologyEnabled)
         connection.Dispose();
     }
 
-    [SkippableTheory]
+    [Theory]
     [InlineData(true)]
     [InlineData(false)]
     public async Task RecoveryTopologyShouldRecoverBindings(bool topologyEnabled)
     {
         Assert.Null(_connection);
         Assert.Null(_management);
-        // Skip.If(true, "rabbitmq-dotnet-client-87");
 
         IConnection connection = await AmqpConnection.CreateAsync(
             ConnectionSettingBuilder.Create()
@@ -472,12 +465,11 @@ await SystemUtils.WaitUntilBindingsBetweenExchangeAndQueueDontExistAsync("exchan
     ///
     /// Only at the end the queue will be removed and bindings should be zero.
     /// </summary>
-    [SkippableFact]
+    [Fact]
     public async Task RemoveAQueueShouldRemoveTheBindings()
     {
         Assert.Null(_connection);
         Assert.Null(_management);
-        // Skip.If(true, "rabbitmq-dotnet-client-87");
 
         IConnection connection = await AmqpConnection.CreateAsync(
             ConnectionSettingBuilder.Create()
@@ -535,12 +527,11 @@ await SystemUtils.WaitUntilBindingsBetweenExchangeAndQueueDontExistAsync("e-remo
         await connection.CloseAsync();
     }
 
-    [SkippableFact]
+    [Fact]
     public async Task RemoveAnExchangeShouldRemoveTheBindings()
     {
         Assert.Null(_connection);
         Assert.Null(_management);
-        // Skip.If(true, "rabbitmq-dotnet-client-87");
 
         IConnection connection = await AmqpConnection.CreateAsync(
             ConnectionSettingBuilder.Create()
@@ -603,12 +594,11 @@ await SystemUtils.WaitUntilBindingsBetweenExchangeAndQueueDontExistAsync(
     /// <summary>
     /// This test is specific to check if the bindings are removed when a destination exchange is removed.
     /// </summary>
-    [SkippableFact]
+    [Fact]
     public async Task RemoveAnExchangeBoundToAnotherExchangeShouldRemoveTheBindings()
     {
         Assert.Null(_connection);
         Assert.Null(_management);
-        // Skip.If(true, "rabbitmq-dotnet-client-87");
 
         IConnection connection = await AmqpConnection.CreateAsync(
             ConnectionSettingBuilder.Create()