Remove default value (#145)

This PR aims to stop implicitly defaulting queue type to classic when creating/declaring a queue, allowing the broker to apply the vhost’s default queue type when the client does not explicitly set one.

Changes:

Removed QueueType getter from IQueueSpecification and AmqpQueueSpecification (and corresponding API tracking entries).
Updated DeclareAsync() logic intended to apply mandatory settings for quorum/stream queues.
Fixes: #146
---------

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>

Author: Gsantomaggio

RabbitMQ.AMQP.Client/IEntities.cs

@@ -61,7 +61,6 @@ public interface IQueueSpecification : IEntityInfoSpecification<IQueueInfo>
         public Dictionary<object, object> QueueArguments { get; }
         IQueueSpecification Arguments(Dictionary<object, object> queueArguments);
 
-        public QueueType QueueType { get; }
         IQueueSpecification Type(QueueType queueType);
 
         IQueueSpecification DeadLetterExchange(string dlx);

RabbitMQ.AMQP.Client/Impl/AmqpQueueSpecification.cs

@@ -180,26 +180,17 @@ public IQueueSpecification Arguments(Dictionary<object, object> queueArguments)
 
         public Dictionary<object, object> QueueArguments => _queueArguments;
 
+        /// <summary>
+        /// <param name="queueType">The type of the queue</param>
+        /// If not set, the default is empty, which means  the declaration will create a classic queue.
+        /// <returns>The current <see cref="IQueueSpecification"/></returns>
+        /// </summary>
         public IQueueSpecification Type(QueueType queueType)
         {
             _queueArguments["x-queue-type"] = queueType.ToString().ToLower();
             return this;
         }
 
-        public QueueType QueueType
-        {
-            get
-            {
-                if (!_queueArguments.ContainsKey("x-queue-type"))
-                {
-                    return QueueType.CLASSIC;
-                }
-
-                string type = (string)_queueArguments["x-queue-type"];
-                return (QueueType)Enum.Parse(typeof(QueueType), type.ToUpperInvariant());
-            }
-        }
-
         public IQueueSpecification DeadLetterExchange(string dlx)
         {
             _queueArguments["x-dead-letter-exchange"] = dlx;
@@ -307,7 +298,7 @@ public IQueueSpecification MessageTtl(TimeSpan ttl)
 
         public async Task<IQueueInfo> DeclareAsync()
         {
-            if (QueueType is QueueType.QUORUM or QueueType.STREAM)
+            if (_queueArguments["x-queue-type"] is QueueType.QUORUM or QueueType.STREAM)
             {
                 // mandatory arguments for quorum queues and streams
                 Exclusive(false).AutoDelete(false);

RabbitMQ.AMQP.Client/PublicAPI.Unshipped.txt

@@ -488,7 +488,6 @@ RabbitMQ.AMQP.Client.Impl.AmqpQueueSpecification.OverflowStrategy(RabbitMQ.AMQP.
 RabbitMQ.AMQP.Client.Impl.AmqpQueueSpecification.PurgeAsync() -> System.Threading.Tasks.Task<ulong>!
 RabbitMQ.AMQP.Client.Impl.AmqpQueueSpecification.QueueArguments.get -> System.Collections.Generic.Dictionary<object!, object!>!
 RabbitMQ.AMQP.Client.Impl.AmqpQueueSpecification.QueueName.get -> string!
-RabbitMQ.AMQP.Client.Impl.AmqpQueueSpecification.QueueType.get -> RabbitMQ.AMQP.Client.QueueType
 RabbitMQ.AMQP.Client.Impl.AmqpQueueSpecification.Quorum() -> RabbitMQ.AMQP.Client.IQuorumQueueSpecification!
 RabbitMQ.AMQP.Client.Impl.AmqpQueueSpecification.SingleActiveConsumer(bool singleActiveConsumer) -> RabbitMQ.AMQP.Client.IQueueSpecification!
 RabbitMQ.AMQP.Client.Impl.AmqpQueueSpecification.Stream() -> RabbitMQ.AMQP.Client.IStreamSpecification!
@@ -688,7 +687,6 @@ RabbitMQ.AMQP.Client.IQueueSpecification.OverflowStrategy(RabbitMQ.AMQP.Client.O
 RabbitMQ.AMQP.Client.IQueueSpecification.PurgeAsync() -> System.Threading.Tasks.Task<ulong>!
 RabbitMQ.AMQP.Client.IQueueSpecification.QueueArguments.get -> System.Collections.Generic.Dictionary<object!, object!>!
 RabbitMQ.AMQP.Client.IQueueSpecification.QueueName.get -> string!
-RabbitMQ.AMQP.Client.IQueueSpecification.QueueType.get -> RabbitMQ.AMQP.Client.QueueType
 RabbitMQ.AMQP.Client.IQueueSpecification.Quorum() -> RabbitMQ.AMQP.Client.IQuorumQueueSpecification!
 RabbitMQ.AMQP.Client.IQueueSpecification.SingleActiveConsumer(bool singleActiveConsumer) -> RabbitMQ.AMQP.Client.IQueueSpecification!
 RabbitMQ.AMQP.Client.IQueueSpecification.Stream() -> RabbitMQ.AMQP.Client.IStreamSpecification!