* Remove the rest of the use of Debug.Assert

Author: lukebakken

RabbitMQ.AMQP.Client/Impl/AmqpPublisher.cs

@@ -62,8 +62,10 @@ void OnAttached(ILink argLink, Attach argAttach)
                 _senderLink = await attachCompletedTcs.Task.WaitAsync(waitSpan)
                     .ConfigureAwait(false);
 
-                // TODO this assertion may not be valid
-                System.Diagnostics.Debug.Assert(Object.ReferenceEquals(_senderLink, tmpSenderLink));
+                if (false == Object.ReferenceEquals(_senderLink, tmpSenderLink))
+                {
+                    // TODO log this case?
+                }
 
                 if (_senderLink is null)
                 {
@@ -117,12 +119,13 @@ public async Task<PublishResult> PublishAsync(IMessage message, CancellationToke
 
                 void OutcomeCallback(ILink sender, Message inMessage, Outcome outcome, object state)
                 {
+                    // Note: sometimes `message` is null 🤔
                     System.Diagnostics.Debug.Assert(Object.ReferenceEquals(this, state));
 
-                    // TODO this assertion may not be valid
-                    System.Diagnostics.Debug.Assert(Object.ReferenceEquals(_senderLink, sender));
-                    // Note: sometimes `message` is null 🤔
-                    // System.Diagnostics.Debug.Assert(Object.ReferenceEquals(nativeMessage, message));
+                    if (false == Object.ReferenceEquals(_senderLink, sender))
+                    {
+                        // TODO log this case?
+                    }
 
                     PublishOutcome publishOutcome;
                     switch (outcome)

RabbitMQ.AMQP.Client/Impl/AmqpSessionManagement.cs

@@ -41,8 +41,8 @@ void OnBegin(ISession session, Begin peerBegin)
                 }
 
                 rv = new Session(_amqpConnection.NativeConnection, GetDefaultBegin(), OnBegin);
+                // TODO cancellation token
                 ISession awaitedSession = await sessionBeginTcs.Task.WaitAsync(TimeSpan.FromSeconds(5)).ConfigureAwait(false);
-                System.Diagnostics.Debug.Assert(Object.ReferenceEquals(rv, awaitedSession));
                 _sessions.Add(rv);
             }