* Wrap up equality comparison.

Author: lukebakken

RabbitMQ.AMQP.Client/ConnectionSettings.cs

@@ -485,6 +485,42 @@ public ConnectionSettingsViaUris(IEnumerable<Uri> uris,
             }
         }
 
+        public override bool Equals(object? obj)
+        {
+            if (obj is null)
+            {
+                return false;
+            }
+
+            if (base.Equals(obj) && (obj is ConnectionSettingsViaUris other))
+            {
+                for (int i = 0; i < _uris.Count; i++)
+                {
+                    Uri thisUri = _uris[i];
+                    Uri otherUri = other._uris[i];
+                    if (false == thisUri.Equals(otherUri))
+                    {
+                        return false;
+                    }
+                }
+
+                return true;
+            }
+
+            return false;
+        }
+
+        public override int GetHashCode()
+        {
+            int baseHashCode = base.GetHashCode();
+            int hashCode = baseHashCode;
+            for (int i = 0; i < _uris.Count; i++)
+            {
+                hashCode ^= _uris[i].GetHashCode();
+            }
+            return hashCode;
+        }
+
         internal override Address Address
         {
             get

RabbitMQ.AMQP.Client/PublicAPI.Unshipped.txt

@@ -14,6 +14,8 @@ override RabbitMQ.AMQP.Client.BackOffDelayPolicy.ToString() -> string!
 override RabbitMQ.AMQP.Client.ConnectionSettings.Equals(object? obj) -> bool
 override RabbitMQ.AMQP.Client.ConnectionSettings.GetHashCode() -> int
 override RabbitMQ.AMQP.Client.ConnectionSettings.ToString() -> string!
+override RabbitMQ.AMQP.Client.ConnectionSettingsViaUris.Equals(object? obj) -> bool
+override RabbitMQ.AMQP.Client.ConnectionSettingsViaUris.GetHashCode() -> int
 override RabbitMQ.AMQP.Client.Error.ToString() -> string!
 override RabbitMQ.AMQP.Client.Impl.AmqpConnection.CloseAsync() -> System.Threading.Tasks.Task!
 override RabbitMQ.AMQP.Client.Impl.AmqpConnection.OpenAsync() -> System.Threading.Tasks.Task!

Tests/ConnectionTests/ConnectionSettingsTests.cs

@@ -220,6 +220,68 @@ public void ConnectionSettingsViaBuilderWithUris()
         Assert.Equal(scheme, a2.Scheme);
     }
 
+    [Fact]
+    public void ConnectionSettingsWithEqualUris()
+    {
+        const string scheme = "amqps";
+        const string host = "rabbitmq-host.foo.baz.com";
+        string user = RandomString(10);
+        string pass = RandomString(10);
+        string containerId = RandomString(10);
+
+        var uri0_0 = new Uri($"{scheme}://{user}:{pass}@{host}:5681/%2Ffrazzle");
+        var uri0_1 = new Uri($"{scheme}://{user}:{pass}@{host}:5681/%2Ffrazzle");
+
+        var uri1_0 = new Uri($"{scheme}://{user}:{pass}@{host}:5691/%2Ffrazzle");
+        var uri1_1 = new Uri($"{scheme}://{user}:{pass}@{host}:5691/%2Ffrazzle");
+
+        var uri2_0 = new Uri($"{scheme}://{user}:{pass}@{host}:5677/%2Ffrazzle");
+        var uri2_1 = new Uri($"{scheme}://{user}:{pass}@{host}:5677/%2Ffrazzle");
+
+        List<Uri> uris0 = [uri0_0, uri1_0, uri2_0];
+        ConnectionSettingsBuilder connectionSettingsBuilder0 = ConnectionSettingsBuilder.Create()
+            .Uris(uris0)
+            .ContainerId(containerId);
+        ConnectionSettings connectionSettings0 = connectionSettingsBuilder0.Build();
+
+        List<Uri> uris1 = [uri0_1, uri1_1, uri2_1];
+        ConnectionSettingsBuilder connectionSettingsBuilder1 = ConnectionSettingsBuilder.Create()
+            .Uris(uris1)
+            .ContainerId(containerId);
+        ConnectionSettings connectionSettings1 = connectionSettingsBuilder1.Build();
+        Assert.Equal(connectionSettings0, connectionSettings1);
+        Assert.Equal(connectionSettings0.GetHashCode(), connectionSettings1.GetHashCode());
+    }
+
+    [Fact]
+    public void ConnectionSettingsWithUrisNotEqual()
+    {
+        const string scheme = "amqps";
+        const string host = "rabbitmq-host.foo.baz.com";
+        string user = RandomString(10);
+        string pass = RandomString(10);
+        string containerId = RandomString(10);
+
+        var uri0 = new Uri($"{scheme}://{user}:{pass}@{host}:5681/%2Ffrazzle");
+        var uri1 = new Uri($"{scheme}://{user}:{pass}@{host}:5691/%2Ffrazzle");
+        var uri2_0 = new Uri($"{scheme}://{user}:{pass}@{host}:5671/%2Ffrazzle");
+        var uri2_1 = new Uri($"{scheme}://{user}:{pass}@{host}:5677/%2Ffrazzle");
+
+        List<Uri> uris0 = [uri0, uri1, uri2_0];
+        ConnectionSettingsBuilder connectionSettingsBuilder0 = ConnectionSettingsBuilder.Create()
+            .Uris(uris0)
+            .ContainerId(containerId);
+        ConnectionSettings connectionSettings0 = connectionSettingsBuilder0.Build();
+
+        List<Uri> uris1 = [uri0, uri1, uri2_1];
+        ConnectionSettingsBuilder connectionSettingsBuilder1 = ConnectionSettingsBuilder.Create()
+            .Uris(uris1)
+            .ContainerId(containerId);
+        ConnectionSettings connectionSettings1 = connectionSettingsBuilder1.Build();
+        Assert.NotEqual(connectionSettings0, connectionSettings1);
+        Assert.NotEqual(connectionSettings0.GetHashCode(), connectionSettings1.GetHashCode());
+    }
+
     [Fact]
     public void ConnectionSettingsViaUrisThrowsWithDifferentVirtualHosts()
     {