Skip to content

rename replicas to members #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2024
Merged

rename replicas to members #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaab1a9
rename replicas to members
Gsantomaggio Nov 11, 2024
0959715
rename replicas to members
Gsantomaggio Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RabbitMQ.AMQP.Client/IEntitiesInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public interface IQueueInfo : IEntityInfo
string Leader();

// TODO IEnumerable? ICollection?
List<string> Replicas();
List<string> Members();

ulong MessageCount();

Expand Down
2 changes: 1 addition & 1 deletion RabbitMQ.AMQP.Client/Impl/AmqpQueueSpecification.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public string Leader()
return _leader;
}

public List<string> Replicas()
public List<string> Members()
{
return _replicas;
}
Expand Down
4 changes: 2 additions & 2 deletions RabbitMQ.AMQP.Client/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,9 +504,9 @@ RabbitMQ.AMQP.Client.Impl.DefaultQueueInfo.ConsumerCount() -> uint
RabbitMQ.AMQP.Client.Impl.DefaultQueueInfo.Durable() -> bool
RabbitMQ.AMQP.Client.Impl.DefaultQueueInfo.Exclusive() -> bool
RabbitMQ.AMQP.Client.Impl.DefaultQueueInfo.Leader() -> string!
RabbitMQ.AMQP.Client.Impl.DefaultQueueInfo.Members() -> System.Collections.Generic.List<string!>!
RabbitMQ.AMQP.Client.Impl.DefaultQueueInfo.MessageCount() -> ulong
RabbitMQ.AMQP.Client.Impl.DefaultQueueInfo.Name() -> string!
RabbitMQ.AMQP.Client.Impl.DefaultQueueInfo.Replicas() -> System.Collections.Generic.List<string!>!
RabbitMQ.AMQP.Client.Impl.DefaultQueueInfo.Type() -> RabbitMQ.AMQP.Client.QueueType
RabbitMQ.AMQP.Client.Impl.FieldNotSetException
RabbitMQ.AMQP.Client.Impl.FieldNotSetException.FieldNotSetException() -> void
Expand Down Expand Up @@ -610,9 +610,9 @@ RabbitMQ.AMQP.Client.IQueueInfo.ConsumerCount() -> uint
RabbitMQ.AMQP.Client.IQueueInfo.Durable() -> bool
RabbitMQ.AMQP.Client.IQueueInfo.Exclusive() -> bool
RabbitMQ.AMQP.Client.IQueueInfo.Leader() -> string!
RabbitMQ.AMQP.Client.IQueueInfo.Members() -> System.Collections.Generic.List<string!>!
RabbitMQ.AMQP.Client.IQueueInfo.MessageCount() -> ulong
RabbitMQ.AMQP.Client.IQueueInfo.Name() -> string!
RabbitMQ.AMQP.Client.IQueueInfo.Replicas() -> System.Collections.Generic.List<string!>!
RabbitMQ.AMQP.Client.IQueueInfo.Type() -> RabbitMQ.AMQP.Client.QueueType
RabbitMQ.AMQP.Client.IQueueSpecification
RabbitMQ.AMQP.Client.IQueueSpecification.Arguments(System.Collections.Generic.Dictionary<object!, object!>! queueArguments) -> RabbitMQ.AMQP.Client.IQueueSpecification!
Expand Down
4 changes: 2 additions & 2 deletions Tests/Management/ManagementTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,11 @@ public async Task DeclareQueueWithQueueInfoValidation(

if (type == QueueType.CLASSIC)
{
Assert.Single(queueInfo.Replicas());
Assert.Single(queueInfo.Members());
}
else
{
Assert.Equal(SystemUtils.ClusterSize, queueInfo.Replicas().Count);
Assert.Equal(SystemUtils.ClusterSize, queueInfo.Members().Count);
}

Assert.NotNull(queueInfo.Leader());
Expand Down