File tree Expand file tree Collapse file tree 3 files changed +4
-8
lines changed
main/java/com/rabbitmq/client/amqp/impl
test/java/com/rabbitmq/client/amqp/impl Expand file tree Collapse file tree 3 files changed +4
-8
lines changed Original file line number Diff line number Diff line change 2424 cache : ' maven'
2525 - name : Start broker
2626 run : ci/start-broker.sh
27- env :
28- RABBITMQ_IMAGE : pivotalrabbitmq/rabbitmq:pr-14110-otp27
2927 - name : Start toxiproxy
3028 run : ci/start-toxiproxy.sh
3129 - name : Display Java version
Original file line number Diff line number Diff line change @@ -263,8 +263,7 @@ static boolean supportSetToken(String brokerVersion) {
263263 }
264264
265265 static boolean supportSqlFilterExpressions (String brokerVersion ) {
266- // TODO should be 4.2
267- return is4_1_OrMore (brokerVersion );
266+ return is4_2_OrMore (brokerVersion );
268267 }
269268
270269 static final class ObservationConnectionInfo implements ObservationCollector .ConnectionInfo {
Original file line number Diff line number Diff line change 2121import static com .rabbitmq .client .amqp .Management .QueueType .STREAM ;
2222import static com .rabbitmq .client .amqp .impl .Assertions .assertThat ;
2323import static com .rabbitmq .client .amqp .impl .TestConditions .BrokerVersion .RABBITMQ_4_1_0 ;
24+ import static com .rabbitmq .client .amqp .impl .TestConditions .BrokerVersion .RABBITMQ_4_2_0 ;
2425import static com .rabbitmq .client .amqp .impl .TestUtils .sync ;
2526import static com .rabbitmq .client .amqp .impl .TestUtils .waitUntilStable ;
2627import static java .nio .charset .StandardCharsets .*;
@@ -471,8 +472,7 @@ void filterExpressionStringModifier() {
471472 }
472473
473474 @ Test
474- // TODO should be 4.2
475- @ BrokerVersionAtLeast (RABBITMQ_4_1_0 )
475+ @ BrokerVersionAtLeast (RABBITMQ_4_2_0 )
476476 void sqlFilterExpressionsShouldFilterMessages () {
477477 publish (1 , m -> m .subject ("abc 123" ));
478478 publish (1 , m -> m .subject ("foo bar" ));
@@ -486,8 +486,7 @@ void sqlFilterExpressionsShouldFilterMessages() {
486486 }
487487
488488 @ Test
489- // TODO should be 4.2
490- @ BrokerVersionAtLeast (RABBITMQ_4_1_0 )
489+ @ BrokerVersionAtLeast (RABBITMQ_4_2_0 )
491490 void incorrectFilterShouldThrowException () {
492491 assertThatThrownBy (
493492 () ->
You can’t perform that action at this time.
0 commit comments