Skip to content

Commit ab30117

Browse files
committed
Mark direct reply-to supported for RabbitMQ 4.2+
1 parent b504a0a commit ab30117

File tree

4 files changed

+3
-10
lines changed

4 files changed

+3
-10
lines changed

.github/workflows/test-pr.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ jobs:
2323
cache: 'maven'
2424
- name: Start broker
2525
run: ci/start-broker.sh
26-
env:
27-
RABBITMQ_IMAGE: pivotalrabbitmq/rabbitmq:pr-14474-otp28
2826
- name: Start toxiproxy
2927
run: ci/start-toxiproxy.sh
3028
- name: Display Java version

src/main/java/com/rabbitmq/client/amqp/impl/AmqpConnection.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -872,9 +872,7 @@ boolean setTokenSupported() {
872872
}
873873

874874
boolean directReplyToSupported() {
875-
// TODO use flag when version for direct reply-to is known
876-
return true;
877-
// return this.directReplyToSupported;
875+
return this.directReplyToSupported;
878876
}
879877

880878
long id() {

src/main/java/com/rabbitmq/client/amqp/impl/AmqpRpcClient.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ final class AmqpRpcClient implements RpcClient {
8383
this.correlationIdExtractor = builder.correlationIdExtractor();
8484
}
8585
AmqpConsumerBuilder consumerBuilder = (AmqpConsumerBuilder) this.connection.consumerBuilder();
86+
LOGGER.debug("Using direct reply-to: {}", this.connection.directReplyToSupported());
8687
this.consumer =
8788
(AmqpConsumer)
8889
consumerBuilder

src/main/java/com/rabbitmq/client/amqp/impl/Utils.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -239,10 +239,6 @@ static boolean is4_2_OrMore(String brokerVersion) {
239239
return atLeastVersion(brokerVersion, "4.2.0");
240240
}
241241

242-
static boolean is4_3_OrMore(String brokerVersion) {
243-
return atLeastVersion(brokerVersion, "4.3.0");
244-
}
245-
246242
private static boolean atLeastVersion(String brokerVersion, String expectedVersion) {
247243
try {
248244
return versionCompare(currentVersion(brokerVersion), expectedVersion) >= 0;
@@ -265,7 +261,7 @@ static boolean supportSqlFilterExpressions(String brokerVersion) {
265261
}
266262

267263
static boolean supportDirectReplyTo(String brokerVersion) {
268-
return is4_3_OrMore(brokerVersion);
264+
return is4_2_OrMore(brokerVersion);
269265
}
270266

271267
static final class ObservationConnectionInfo implements ObservationCollector.ConnectionInfo {

0 commit comments

Comments
 (0)