Add test for negative small long

Author: acogoluegnes

src/main/qpid/org/apache/qpid/protonj2/codec/decoders/ProtonDecoder.java

@@ -621,7 +621,7 @@ public Long readLong(ProtonBuffer buffer, DecoderState state) throws DecodeExcep
 
         switch (encodingCode) {
             case EncodingCodes.SMALLLONG:
-                return (long) buffer.readByte() & 0xff;
+                return (long) buffer.readByte();
             case EncodingCodes.LONG:
                 return buffer.readLong();
             case EncodingCodes.NULL:
@@ -637,7 +637,7 @@ public long readLong(ProtonBuffer buffer, DecoderState state, long defaultValue)
 
         switch (encodingCode) {
             case EncodingCodes.SMALLLONG:
-                return (long) buffer.readByte() & 0xff;
+                return buffer.readByte();
             case EncodingCodes.LONG:
                 return buffer.readLong();
             case EncodingCodes.NULL:

src/main/qpid/org/apache/qpid/protonj2/codec/decoders/ProtonStreamDecoder.java

@@ -645,7 +645,7 @@ public Long readLong(InputStream stream, StreamDecoderState state) throws Decode
 
         switch (encodingCode) {
             case EncodingCodes.SMALLLONG:
-                return Long.valueOf(ProtonStreamUtils.readByte(stream) & 0xffl);
+                return (long) ProtonStreamUtils.readByte(stream);
             case EncodingCodes.LONG:
                 return ProtonStreamUtils.readLong(stream);
             case EncodingCodes.NULL:
@@ -661,7 +661,7 @@ public long readLong(InputStream stream, StreamDecoderState state, long defaultV
 
         switch (encodingCode) {
             case EncodingCodes.SMALLLONG:
-                return ProtonStreamUtils.readByte(stream) & 0xffl;
+                return ProtonStreamUtils.readByte(stream);
             case EncodingCodes.LONG:
                 return ProtonStreamUtils.readLong(stream);
             case EncodingCodes.NULL:

src/main/qpid/org/apache/qpid/protonj2/codec/decoders/primitives/Long8TypeDecoder.java

@@ -32,7 +32,7 @@ public final class Long8TypeDecoder extends LongTypeDecoder {
 
     @Override
     public Long readValue(ProtonBuffer buffer, DecoderState state) throws DecodeException {
-        return (long) buffer.readByte() & 0xff;
+        return (long) buffer.readByte() & (byte) 0xff;
     }
 
     @Override

src/test/java/com/rabbitmq/client/amqp/impl/AmqpTest.java

@@ -737,6 +737,37 @@ void queuePurgeOnNonExistingQueueShouldThrowException(TestInfo info) {
         .hasMessageContaining(q);
   }
 
+  @Test
+  void types(TestInfo info) {
+    Management management = connection.management();
+    String q = TestUtils.name(info);
+    management.queue(q).exclusive(true).declare();
+    Sync publishSync = sync();
+    Publisher.Callback callback =
+        context -> {
+          if (context.status() == Publisher.Status.ACCEPTED) {
+            publishSync.down();
+          }
+        };
+    Publisher publisher = connection.publisherBuilder().queue(q).build();
+    publisher.publish(publisher.message().property("key1", -1L), callback);
+    assertThat(publishSync).completes();
+    AtomicReference<Message> message = new AtomicReference<>();
+    Sync consumeSync = sync();
+    connection
+        .consumerBuilder()
+        .queue(q)
+        .messageHandler(
+            (ctx, msg) -> {
+              message.set(msg);
+              ctx.accept();
+              consumeSync.down();
+            })
+        .build();
+    assertThat(consumeSync).completes();
+    assertThat(message.get()).hasProperty("key1", -1L);
+  }
+
   private static String uuid() {
     return UUID.randomUUID().toString();
   }