improving AddressHelper utility functions

Author: DanielePalaia

examples/getting_started/main.py

@@ -1,5 +1,8 @@
 # type: ignore
+
+
 from rabbitmq_amqp_python_client import (
+    AddressHelper,
     BindingSpecification,
     Connection,
     Event,
@@ -8,15 +11,13 @@
     MessageAck,
     MessagingHandler,
     QuorumQueueSpecification,
-    exchange_address,
-    queue_address,
 )
 
 
 class MyMessageHandler(MessagingHandler):
 
     def __init__(self):
-        super().__init__(auto_accept=False, auto_settle=False)
+        super().__init__(auto_accept=False)
         self._count = 0
 
     def on_message(self, event: Event):
@@ -45,13 +46,16 @@ def on_message(self, event: Event):
 
         if self._count == 100:
             print("closing receiver")
-            event.receiver.close()
-            event.connection.close()
+            # if you want you can add cleanup operations here
+            # event.receiver.close()
+            # event.connection.close()
 
     def on_connection_closed(self, event: Event):
+        # if you want you can add cleanup operations here
         print("connection closed")
 
     def on_link_closed(self, event: Event) -> None:
+        # if you want you can add cleanup operations here
         print("link closed")
 
 
@@ -91,9 +95,9 @@ def main() -> None:
         )
     )
 
-    addr = exchange_address(exchange_name, routing_key)
+    addr = AddressHelper.exchange_address(exchange_name, routing_key)
 
-    addr_queue = queue_address(queue_name)
+    addr_queue = AddressHelper.queue_address(queue_name)
 
     print("create a publisher and publish a test message")
     publisher = connection.publisher(addr)
@@ -102,7 +106,7 @@ def main() -> None:
     messages_purged = management.purge_queue(queue_name)
 
     print("messages purged: " + str(messages_purged))
-    management.close()
+    # management.close()
 
     # publish 10 messages
     for i in range(messages_to_publish):
@@ -121,22 +125,22 @@ def main() -> None:
         pass
 
     print("cleanup")
-    # once we finish consuming we close the connection so we need to create a new one
-    connection = create_connection()
+    consumer.close()
+    # once we finish consuming if we close the connection we need to create a new one
+    # connection = create_connection()
+    # management = connection.management()
 
-    management = connection.management()
     print("unbind")
     management.unbind(bind_name)
 
     print("delete queue")
-    # management.delete_queue(queue_name)
+    management.delete_queue(queue_name)
 
     print("delete exchange")
     management.delete_exchange(exchange_name)
 
     print("closing connections")
     management.close()
-    # consumer.close()
     print("after management closing")
     connection.close()
     print("after connection closing")

rabbitmq_amqp_python_client/__init__.py

@@ -1,6 +1,6 @@
 from importlib import metadata
 
-from .address_helper import exchange_address, queue_address
+from .address_helper import AddressHelper
 from .common import ExchangeType, QueueType
 from .connection import Connection
 from .consumer import Consumer
@@ -41,8 +41,6 @@
     "BindingSpecification",
     "QueueType",
     "Publisher",
-    "exchange_address",
-    "queue_address",
     "Message",
     "Consumer",
     "MessagingHandler",
@@ -51,4 +49,5 @@
     "MessageAck",
     "symbol",
     "ExchangeType",
+    "AddressHelper",
 ]

rabbitmq_amqp_python_client/address_helper.py

@@ -1,7 +1,7 @@
 from .entities import BindingSpecification
 
 
-def is_unreserved(char: str) -> bool:
+def _is_unreserved(char: str) -> bool:
     # According to RFC 3986, unreserved characters are A-Z, a-z, 0-9, '-', '.', '_', and '~'
     return char.isalnum() or char in "-._~"
 
@@ -12,7 +12,7 @@ def encode_path_segment(input_string: str) -> str:
     # Iterate over each character in the input string
     for char in input_string:
         # Check if the character is an unreserved character
-        if is_unreserved(char):
+        if _is_unreserved(char):
             encoded.append(char)  # Append as is
         else:
             # Encode character to %HH format
@@ -21,49 +21,54 @@ def encode_path_segment(input_string: str) -> str:
     return "".join(encoded)
 
 
-def exchange_address(exchange_name: str, routing_key: str = "") -> str:
-    if routing_key == "":
-        path = "/exchanges/" + encode_path_segment(exchange_name)
-    else:
-        path = (
-            "/exchanges/"
-            + encode_path_segment(exchange_name)
-            + "/"
-            + encode_path_segment(routing_key)
-        )
-
-    return path
-
+class AddressHelper:
 
-def queue_address(queue_name: str) -> str:
-    path = "/queues/" + encode_path_segment(queue_name)
-
-    return path
+    @staticmethod
+    def exchange_address(exchange_name: str, routing_key: str = "") -> str:
+        if routing_key == "":
+            path = "/exchanges/" + encode_path_segment(exchange_name)
+        else:
+            path = (
+                "/exchanges/"
+                + encode_path_segment(exchange_name)
+                + "/"
+                + encode_path_segment(routing_key)
+            )
 
+        return path
 
-def purge_queue_address(queue_name: str) -> str:
-    path = "/queues/" + encode_path_segment(queue_name) + "/messages"
+    @staticmethod
+    def queue_address(queue_name: str) -> str:
+        path = "/queues/" + encode_path_segment(queue_name)
 
-    return path
+        return path
 
+    @staticmethod
+    def purge_queue_address(queue_name: str) -> str:
+        path = "/queues/" + encode_path_segment(queue_name) + "/messages"
 
-def path_address() -> str:
-    path = "/bindings"
+        return path
 
-    return path
+    @staticmethod
+    def path_address() -> str:
+        path = "/bindings"
 
+        return path
 
-def binding_path_with_exchange_queue(bind_specification: BindingSpecification) -> str:
-    binding_path_wth_exchange_queue_key = (
-        "/bindings"
-        + "/"
-        + "src="
-        + encode_path_segment(bind_specification.source_exchange)
-        + ";"
-        + "dstq="
-        + encode_path_segment(bind_specification.destination_queue)
-        + ";key="
-        + encode_path_segment(bind_specification.binding_key)
-        + ";args="
-    )
-    return binding_path_wth_exchange_queue_key
+    @staticmethod
+    def binding_path_with_exchange_queue(
+        bind_specification: BindingSpecification,
+    ) -> str:
+        binding_path_wth_exchange_queue_key = (
+            "/bindings"
+            + "/"
+            + "src="
+            + encode_path_segment(bind_specification.source_exchange)
+            + ";"
+            + "dstq="
+            + encode_path_segment(bind_specification.destination_queue)
+            + ";key="
+            + encode_path_segment(bind_specification.binding_key)
+            + ";args="
+        )
+        return binding_path_wth_exchange_queue_key

rabbitmq_amqp_python_client/connection.py

@@ -32,7 +32,9 @@ def management(self) -> Management:
     # closes the connection to the AMQP 1.0 server.
     def close(self) -> None:
         logger.debug("Closing connection")
+        print("closing connection")
         self._conn.close()
+        print("after closing connection")
 
     def publisher(self, destination: str) -> Publisher:
         publisher = Publisher(self._conn, destination)

rabbitmq_amqp_python_client/management.py

@@ -2,13 +2,7 @@
 import uuid
 from typing import Any, Optional, Union
 
-from .address_helper import (
-    binding_path_with_exchange_queue,
-    exchange_address,
-    path_address,
-    purge_queue_address,
-    queue_address,
-)
+from .address_helper import AddressHelper
 from .common import CommonValues, QueueType
 from .entities import (
     BindingSpecification,
@@ -113,7 +107,7 @@ def declare_exchange(
         body["internal"] = exchange_specification.is_internal
         body["arguments"] = exchange_specification.arguments  # type: ignore
 
-        path = exchange_address(exchange_specification.name)
+        path = AddressHelper.exchange_address(exchange_specification.name)
 
         self.request(
             body,
@@ -146,7 +140,7 @@ def declare_queue(
         elif isinstance(queue_specification, StreamSpecification):
             body = self._declare_stream(queue_specification)
 
-        path = queue_address(queue_specification.name)
+        path = AddressHelper.queue_address(queue_specification.name)
 
         self.request(
             body,
@@ -255,7 +249,7 @@ def _declare_stream(
 
     def delete_exchange(self, exchange_name: str) -> None:
         logger.debug("delete_exchange operation called")
-        path = exchange_address(exchange_name)
+        path = AddressHelper.exchange_address(exchange_name)
 
         self.request(
             None,
@@ -268,7 +262,7 @@ def delete_exchange(self, exchange_name: str) -> None:
 
     def delete_queue(self, queue_name: str) -> None:
         logger.debug("delete_queue operation called")
-        path = queue_address(queue_name)
+        path = AddressHelper.queue_address(queue_name)
 
         self.request(
             None,
@@ -302,7 +296,7 @@ def bind(self, bind_specification: BindingSpecification) -> str:
         body["destination_queue"] = bind_specification.destination_queue
         body["arguments"] = {}  # type: ignore
 
-        path = path_address()
+        path = AddressHelper.path_address()
 
         self.request(
             body,
@@ -313,7 +307,9 @@ def bind(self, bind_specification: BindingSpecification) -> str:
             ],
         )
 
-        binding_path_with_queue = binding_path_with_exchange_queue(bind_specification)
+        binding_path_with_queue = AddressHelper.binding_path_with_exchange_queue(
+            bind_specification
+        )
         return binding_path_with_queue
 
     def unbind(self, binding_exchange_queue_path: str) -> None:
@@ -329,7 +325,7 @@ def unbind(self, binding_exchange_queue_path: str) -> None:
 
     def purge_queue(self, queue_name: str) -> int:
         logger.debug("purge_queue operation called")
-        path = purge_queue_address(queue_name)
+        path = AddressHelper.purge_queue_address(queue_name)
 
         response = self.request(
             None,
@@ -344,7 +340,7 @@ def purge_queue(self, queue_name: str) -> int:
 
     def queue_info(self, queue_name: str) -> QueueInfo:
         logger.debug("queue_info operation called")
-        path = queue_address(queue_name)
+        path = AddressHelper.queue_address(queue_name)
 
         message = self.request(
             None,

rabbitmq_amqp_python_client/qpid/proton/_handlers.py

@@ -712,7 +712,7 @@ def __init__(
         self,
         prefetch: int = 10,
         auto_accept: bool = False,
-        auto_settle: bool = False,
+        auto_settle: bool = True,
         peer_close_is_error: bool = False,
     ) -> None:
         self.handlers = []

rabbitmq_amqp_python_client/qpid/proton/_utils.py

@@ -553,7 +553,7 @@ def close(self) -> None:
         finally:
             self.conn.free()
             # Nothing left to block on.  Allow reactor to clean up.
-            self.run()
+            # self.run()   # why is this necessary here?
             if self.conn:
                 self.conn.handler = None  # break cyclical reference
                 self.conn = None