refactor

the stream consumer options and the stream filter options. This implementation is similar to the
golang implementation. So the idea is to have the same API ( as much as possible ) for all the amqp 1.0. clients.
Add a new class StreamFilterOptions to configure only the filtering and leave the StreamConsumerOptions for offset
and other future implementations

Signed-off-by: Gabriele Santomaggio <[email protected]>

Author: Gsantomaggio

examples/streams/example_with_streams.py

@@ -10,7 +10,7 @@
     Event,
     Message,
     OffsetSpecification,
-    StreamOptions,
+    StreamConsumerOptions,
     StreamSpecification,
 )
 
@@ -104,9 +104,7 @@ def main() -> None:
         message_handler=MyMessageHandler(),
         # can be first, last, next or an offset long
         # you can also specify stream filters with methods: apply_filters and filter_match_unfiltered
-        stream_filter_options=StreamOptions(
-            offset_specification=OffsetSpecification.first, filters=["banana"]
-        ),
+        stream_consumer_options=StreamConsumerOptions(offset_specification=OffsetSpecification.first),
     )
     print(
         "create a consumer and consume the test message - press control + c to terminate to consume"

rabbitmq_amqp_python_client/__init__.py

@@ -13,7 +13,7 @@
     OAuth2Options,
     OffsetSpecification,
     RecoveryConfiguration,
-    StreamOptions,
+    StreamConsumerOptions,
 )
 from .environment import Environment
 from .exceptions import (
@@ -85,7 +85,7 @@
     "CurrentUserStore",
     "PKCS12Store",
     "ConnectionClosed",
-    "StreamOptions",
+    "StreamConsumerOptions",
     "OffsetSpecification",
     "OutcomeState",
     "Environment",

rabbitmq_amqp_python_client/connection.py

@@ -18,7 +18,7 @@
 from .entities import (
     OAuth2Options,
     RecoveryConfiguration,
-    StreamOptions,
+    StreamConsumerOptions,
 )
 from .exceptions import (
     ArgumentOutOfRangeException,
@@ -363,7 +363,7 @@ def publisher(self, destination: str = "") -> Publisher:
             ArgumentOutOfRangeException: If destination address format is invalid
         """
         if destination != "":
-            if validate_address(destination) is False:
+            if not validate_address(destination):
                 raise ArgumentOutOfRangeException(
                     "destination address must start with /queues or /exchanges"
                 )
@@ -376,7 +376,7 @@ def consumer(
         self,
         destination: str,
         message_handler: Optional[MessagingHandler] = None,
-        stream_filter_options: Optional[StreamOptions] = None,
+        stream_consumer_options: Optional[StreamConsumerOptions] = None,
         credit: Optional[int] = None,
     ) -> Consumer:
         """
@@ -385,7 +385,7 @@ def consumer(
         Args:
             destination: The address to consume from
             message_handler: Optional handler for processing messages
-            stream_filter_options: Optional configuration for stream consumption
+            stream_consumer_options: Optional configuration for stream consumption
             credit: Optional credit value for flow control
 
         Returns:
@@ -394,12 +394,12 @@ def consumer(
         Raises:
             ArgumentOutOfRangeException: If destination address format is invalid
         """
-        if validate_address(destination) is False:
+        if not validate_address(destination):
             raise ArgumentOutOfRangeException(
                 "destination address must start with /queues or /exchanges"
             )
         consumer = Consumer(
-            self._conn, destination, message_handler, stream_filter_options, credit
+            self._conn, destination, message_handler, stream_consumer_options, credit
         )
         self._consumers.append(consumer)
         return consumer

rabbitmq_amqp_python_client/consumer.py

@@ -2,7 +2,7 @@
 from typing import Literal, Optional, Union, cast
 
 from .amqp_consumer_handler import AMQPMessagingHandler
-from .entities import StreamOptions
+from .entities import StreamConsumerOptions
 from .options import (
     ReceiverOptionUnsettled,
     ReceiverOptionUnsettledWithFilters,
@@ -29,7 +29,7 @@ class Consumer:
         _conn (BlockingConnection): The underlying connection to RabbitMQ
         _addr (str): The address to consume from
         _handler (Optional[MessagingHandler]): Optional message handling callback
-        _stream_options (Optional[StreamOptions]): Configuration for stream consumption
+        _stream_options (Optional[StreamConsumerOptions]): Configuration for stream consumption
         _credit (Optional[int]): Flow control credit value
     """
 
@@ -38,7 +38,7 @@ def __init__(
         conn: BlockingConnection,
         addr: str,
         handler: Optional[AMQPMessagingHandler] = None,
-        stream_options: Optional[StreamOptions] = None,
+        stream_options: Optional[StreamConsumerOptions] = None,
         credit: Optional[int] = None,
     ):
         """

rabbitmq_amqp_python_client/entities.py

@@ -149,7 +149,26 @@ class ExchangeToExchangeBindingSpecification:
     binding_key: Optional[str] = None
 
 
-class StreamOptions:
+class StreamFilterOptions:
+    values: Optional[list[str]] = (None,)
+    match_unfiltered: bool = (False,)
+    application_properties: dict = (field(default_factory=dict),)
+    sql: str = ""
+
+    def __init__(
+        self,
+        values: Optional[list[str]] = None,
+        match_unfiltered: bool = False,
+        application_properties: Optional[dict] = None,
+        sql: str = "",
+    ):
+        self.values = values
+        self.match_unfiltered = match_unfiltered
+        self.application_properties = application_properties
+        self.sql = sql
+
+
+class StreamConsumerOptions:
     """
     Configuration options for stream queues.
 
@@ -167,23 +186,30 @@ class StreamOptions:
     def __init__(
         self,
         offset_specification: Optional[Union[OffsetSpecification, int]] = None,
-        filters: Optional[list[str]] = None,
-        filter_match_unfiltered: bool = False,
+        filter_options: Optional[StreamFilterOptions] = None,
     ):
 
-        if offset_specification is None and filters is None:
+        self.streamFilterOptions = filter_options
+
+        if offset_specification is None and self.streamFilterOptions is None:
             raise ValidationCodeException(
                 "At least one between offset_specification and filters must be set when setting up filtering"
             )
         self._filter_set: Dict[symbol, Described] = {}
         if offset_specification is not None:
             self._offset(offset_specification)
 
-        if filters is not None:
-            self._filter_values(filters)
-
-        if filter_match_unfiltered is True:
-            self._filter_match_unfiltered(filter_match_unfiltered)
+        if (
+            self.streamFilterOptions is not None
+            and self.streamFilterOptions.values is not None
+        ):
+            self._filter_values(self.streamFilterOptions.values)
+
+        if (
+            self.streamFilterOptions is not None
+            and self.streamFilterOptions.match_unfiltered
+        ):
+            self._filter_match_unfiltered(self.streamFilterOptions.match_unfiltered)
 
     def _offset(self, offset_specification: Union[OffsetSpecification, int]) -> None:
         """

rabbitmq_amqp_python_client/options.py

@@ -1,4 +1,4 @@
-from .entities import StreamOptions
+from .entities import StreamConsumerOptions
 from .qpid.proton._data import (  # noqa: E402
     PropertyDict,
     symbol,
@@ -68,7 +68,7 @@ def test(self, link: Link) -> bool:
 
 
 class ReceiverOptionUnsettledWithFilters(Filter):  # type: ignore
-    def __init__(self, addr: str, filter_options: StreamOptions):
+    def __init__(self, addr: str, filter_options: StreamConsumerOptions):
         super().__init__(filter_options.filter_set())
         self._addr = addr
 

rabbitmq_amqp_python_client/qpid/proton/_message.py

@@ -117,7 +117,7 @@ def __init__(
         self._msg = pn_message()
         self.instructions = None
         self.annotations = None
-        self.properties = None
+        self.application_properties = None
         self.body = body
         self.inferred = inferred
 
@@ -149,7 +149,7 @@ def _check_property_keys(self) -> None:
         # We cannot make changes to the dict while iterating, so we
         # must save and make the changes afterwards
         changed_keys = []
-        for k in self.properties.keys():
+        for k in self.application_properties.keys():
             if isinstance(k, str):
                 # strings and their subclasses
                 if type(k) is symbol or type(k) is char:
@@ -169,9 +169,12 @@ def _check_property_keys(self) -> None:
                 )
         # Make the key changes
         for old_key, new_key in changed_keys:
-            self.properties[new_key] = self.properties.pop(old_key)
+            self.application_properties[new_key] = self.application_properties.pop(
+                old_key
+            )
 
     def _pre_encode(self) -> None:
+
         inst = Data(pn_message_instructions(self._msg))
         ann = Data(pn_message_annotations(self._msg))
         props = Data(pn_message_properties(self._msg))
@@ -184,9 +187,9 @@ def _pre_encode(self) -> None:
         if self.annotations is not None:
             ann.put_object(self.annotations)
         props.clear()
-        if self.properties is not None:
+        if self.application_properties is not None:
             self._check_property_keys()
-            props.put_object(self.properties)
+            props.put_object(self.application_properties)
         body.clear()
         if self.body is not None:
             body.put_object(self.body)
@@ -206,9 +209,9 @@ def _post_decode(self) -> None:
         else:
             self.annotations = None
         if props.next():
-            self.properties = props.get_object()
+            self.application_properties = props.get_object()
         else:
-            self.properties = None
+            self.application_properties = None
         if body.next():
             self.body = body.get_object()
         else:
@@ -222,7 +225,7 @@ def clear(self) -> None:
         pn_message_clear(self._msg)
         self.instructions = None
         self.annotations = None
-        self.properties = None
+        self.application_properties = None
         self.body = None
 
     @property
@@ -641,7 +644,7 @@ def __repr__(self) -> str:
             "reply_to_group_id",
             "instructions",
             "annotations",
-            "properties",
+            "application_properties",
             "body",
         ):
             value = getattr(self, attr)