Check server version when opening the connection

Author: Zerpet

poetry.lock

@@ -10,6 +10,7 @@ readme = "README.md"
 python = "^3.9"
 python-qpid-proton = "^0.39.0"
 typing-extensions = "^4.13.0"
+packaging = "^23.0"
 
 
 [tool.poetry.group.dev.dependencies]

pyproject.toml

@@ -10,6 +10,8 @@
     Union,
 )
 
+from packaging import version
+
 import typing_extensions
 
 from .address_helper import validate_address
@@ -166,6 +168,50 @@ def _create_connection(self) -> None:
                 password=self._password,
             )
 
+        self._validate_server_properties()
+
+    def _validate_server_properties(self) -> None:
+        """
+        Validate the server properties returned in the connection handshake.
+        
+        Checks that the server is RabbitMQ and the version is >= 4.0.0.
+        
+        Raises:
+            ValidationCodeException: If server is not RabbitMQ or version < 4.0.0
+        """
+        if self._conn is None or self._conn.conn is None:
+            raise ValidationCodeException("Connection not established")
+        
+        remote_props = self._conn.conn.remote_properties
+        if remote_props is None:
+            raise ValidationCodeException("No remote properties received from server")
+        
+        # Check if server is RabbitMQ
+        product = remote_props.get("product")
+        if product != "RabbitMQ":
+            raise ValidationCodeException(
+                f"Connection to non-RabbitMQ server detected. "
+                f"Expected 'RabbitMQ', got '{product}'"
+            )
+        
+        # Check server version is >= 4.0.0
+        server_version = remote_props.get("version")
+        if server_version is None:
+            raise ValidationCodeException("Server version not provided")
+        
+        try:
+            if version.parse(str(server_version)) < version.parse("4.0.0"):
+                raise ValidationCodeException(
+                    f"The AMQP client library requires RabbitMQ 4.0.0 or higher. "
+                    f"Server version: {server_version}"
+                )
+        except Exception as e:
+            raise ValidationCodeException(
+                f"Failed to parse server version '{server_version}': {e}"
+            )
+        
+        logger.debug(f"Connected to RabbitMQ server version {server_version}")
+
     def dial(self) -> None:
         """
         Establish a connection to the AMQP server.

rabbitmq_amqp_python_client/connection.py

@@ -482,7 +482,7 @@ def remote_desired_capabilities(self):
         return c and SymbolList(c)
 
     @property
-    def remote_properties(self):
+    def remote_properties(self) -> Optional[Data]:
         """
         The properties specified by the remote peer for this connection.
 

rabbitmq_amqp_python_client/qpid/proton/_endpoints.py

@@ -465,6 +465,11 @@ def __init__(
                     lambda: not (self.conn.state & Endpoint.REMOTE_UNINIT),
                     msg="Opening connection",
                 )
+                self.wait(
+                    lambda: (self.conn.state & Endpoint.REMOTE_ACTIVE),
+                    timeout=10,
+                    msg="Connection opened",
+                )
 
             except ConnectionException:
                 if self.conn is not None:

rabbitmq_amqp_python_client/qpid/proton/_utils.py

@@ -0,0 +1,293 @@
+"""
+Unit tests for server validation functionality in the Connection class.
+These tests use mocks to avoid external dependencies.
+
+To run these tests:
+    pytest tests/test_server_validation.py -v
+
+Or to run a specific test:
+    pytest tests/test_server_validation.py::TestServerValidation::test_validate_server_properties_success_exact_version -v
+"""
+
+import pytest
+from unittest.mock import Mock, MagicMock
+
+from rabbitmq_amqp_python_client.connection import Connection
+from rabbitmq_amqp_python_client.exceptions import ValidationCodeException
+
+
+class TestServerValidation:
+    """Test cases for the _validate_server_properties method."""
+
+    def setup_method(self):
+        """Set up test fixtures."""
+        self.connection = Connection.__new__(Connection)
+        # Initialize required attributes that would normally be set in __init__
+        self.connection._conn = None
+        self.connection._addr = "amqp://localhost:5672"
+        self.connection._addrs = None
+        self.connection._conf_ssl_context = None
+        self.connection._managements = []
+        self.connection._recovery_configuration = None
+        self.connection._ssl_domain = None
+        self.connection._connections = []
+        self.connection._index = -1
+        self.connection._publishers = []
+        self.connection._consumers = []
+        self.connection._oauth2_options = None
+
+    def test_validate_server_properties_success_exact_version(self):
+        """Test successful validation with exact minimum version 4.0.0."""
+        # Create mock objects
+        mock_blocking_conn = Mock()
+        mock_proton_conn = Mock()
+        mock_remote_props = {
+            "product": "RabbitMQ",
+            "version": "4.0.0"
+        }
+        
+        mock_proton_conn.remote_properties = mock_remote_props
+        mock_blocking_conn.conn = mock_proton_conn
+        self.connection._conn = mock_blocking_conn
+        
+        # Should not raise any exception
+        self.connection._validate_server_properties()
+
+    def test_validate_server_properties_success_higher_version(self):
+        """Test successful validation with version higher than minimum."""
+        # Create mock objects
+        mock_blocking_conn = Mock()
+        mock_proton_conn = Mock()
+        mock_remote_props = {
+            "product": "RabbitMQ",
+            "version": "4.1.2"
+        }
+        
+        mock_proton_conn.remote_properties = mock_remote_props
+        mock_blocking_conn.conn = mock_proton_conn
+        self.connection._conn = mock_blocking_conn
+        
+        # Should not raise any exception
+        self.connection._validate_server_properties()
+
+    def test_validate_server_properties_no_connection(self):
+        """Test validation fails when connection is None."""
+        self.connection._conn = None
+        
+        with pytest.raises(ValidationCodeException) as exc_info:
+            self.connection._validate_server_properties()
+        
+        assert "Connection not established" in str(exc_info.value)
+
+    def test_validate_server_properties_no_proton_connection(self):
+        """Test validation fails when proton connection is None."""
+        mock_blocking_conn = Mock()
+        mock_blocking_conn.conn = None
+        self.connection._conn = mock_blocking_conn
+        
+        with pytest.raises(ValidationCodeException) as exc_info:
+            self.connection._validate_server_properties()
+        
+        assert "Connection not established" in str(exc_info.value)
+
+    def test_validate_server_properties_no_remote_properties(self):
+        """Test validation fails when remote_properties is None."""
+        mock_blocking_conn = Mock()
+        mock_proton_conn = Mock()
+        mock_proton_conn.remote_properties = None
+        mock_blocking_conn.conn = mock_proton_conn
+        self.connection._conn = mock_blocking_conn
+        
+        with pytest.raises(ValidationCodeException) as exc_info:
+            self.connection._validate_server_properties()
+        
+        assert "No remote properties received from server" in str(exc_info.value)
+
+    def test_validate_server_properties_wrong_product(self):
+        """Test validation fails when server is not RabbitMQ."""
+        mock_blocking_conn = Mock()
+        mock_proton_conn = Mock()
+        mock_remote_props = {
+            "product": "Apache ActiveMQ",
+            "version": "4.0.0"
+        }
+        
+        mock_proton_conn.remote_properties = mock_remote_props
+        mock_blocking_conn.conn = mock_proton_conn
+        self.connection._conn = mock_blocking_conn
+        
+        with pytest.raises(ValidationCodeException) as exc_info:
+            self.connection._validate_server_properties()
+        
+        error_msg = str(exc_info.value)
+        assert "Connection to non-RabbitMQ server detected" in error_msg
+        assert "Expected 'RabbitMQ', got 'Apache ActiveMQ'" in error_msg
+
+    def test_validate_server_properties_missing_product(self):
+        """Test validation fails when product property is missing."""
+        mock_blocking_conn = Mock()
+        mock_proton_conn = Mock()
+        mock_remote_props = {
+            "version": "4.0.0"
+            # Missing "product" key
+        }
+        
+        mock_proton_conn.remote_properties = mock_remote_props
+        mock_blocking_conn.conn = mock_proton_conn
+        self.connection._conn = mock_blocking_conn
+        
+        with pytest.raises(ValidationCodeException) as exc_info:
+            self.connection._validate_server_properties()
+        
+        error_msg = str(exc_info.value)
+        assert "Connection to non-RabbitMQ server detected" in error_msg
+        assert "Expected 'RabbitMQ', got 'None'" in error_msg
+
+    def test_validate_server_properties_missing_version(self):
+        """Test validation fails when version property is missing."""
+        mock_blocking_conn = Mock()
+        mock_proton_conn = Mock()
+        mock_remote_props = {
+            "product": "RabbitMQ"
+            # Missing "version" key
+        }
+        
+        mock_proton_conn.remote_properties = mock_remote_props
+        mock_blocking_conn.conn = mock_proton_conn
+        self.connection._conn = mock_blocking_conn
+        
+        with pytest.raises(ValidationCodeException) as exc_info:
+            self.connection._validate_server_properties()
+        
+        assert "Server version not provided" in str(exc_info.value)
+
+    def test_validate_server_properties_version_too_low(self):
+        """Test validation fails when server version is below 4.0.0."""
+        test_cases = [
+            "3.9.9",
+            "3.12.0", 
+            "2.8.7",
+            "1.0.0"
+        ]
+        
+        for version_str in test_cases:
+            mock_blocking_conn = Mock()
+            mock_proton_conn = Mock()
+            mock_remote_props = {
+                "product": "RabbitMQ",
+                "version": version_str
+            }
+            
+            mock_proton_conn.remote_properties = mock_remote_props
+            mock_blocking_conn.conn = mock_proton_conn
+            self.connection._conn = mock_blocking_conn
+            
+            with pytest.raises(ValidationCodeException) as exc_info:
+                self.connection._validate_server_properties()
+            
+            error_msg = str(exc_info.value)
+            assert "The AMQP client library requires RabbitMQ 4.0.0 or higher" in error_msg
+            assert f"Server version: {version_str}" in error_msg
+
+    def test_validate_server_properties_valid_higher_versions(self):
+        """Test validation succeeds with various higher versions."""
+        valid_versions = [
+            "4.0.0",
+            "4.0.1",
+            "4.1.0",
+            "4.10.15",
+            "5.0.0",
+            "10.2.3",
+            "v4.0.0",      # v prefix should be stripped and accepted
+            "4.0.0.0.0"    # Extra zeroes should be normalized and accepted
+        ]
+        
+        for version_str in valid_versions:
+            mock_blocking_conn = Mock()
+            mock_proton_conn = Mock()
+            mock_remote_props = {
+                "product": "RabbitMQ",
+                "version": version_str
+            }
+            
+            mock_proton_conn.remote_properties = mock_remote_props
+            mock_blocking_conn.conn = mock_proton_conn
+            self.connection._conn = mock_blocking_conn
+            
+            # Should not raise any exception
+            self.connection._validate_server_properties()
+
+    def test_validate_server_properties_invalid_version_format(self):
+        """Test validation handles invalid version formats gracefully."""
+        invalid_versions = [
+            "invalid-version",
+            "4.0.0-alpha",  # Pre-release, should be rejected
+            "",
+        ]
+        
+        for version_str in invalid_versions:
+            mock_blocking_conn = Mock()
+            mock_proton_conn = Mock()
+            mock_remote_props = {
+                "product": "RabbitMQ",
+                "version": version_str
+            }
+            
+            mock_proton_conn.remote_properties = mock_remote_props
+            mock_blocking_conn.conn = mock_proton_conn
+            self.connection._conn = mock_blocking_conn
+            
+            with pytest.raises(ValidationCodeException) as exc_info:
+                self.connection._validate_server_properties()
+            
+            error_msg = str(exc_info.value)
+            # Should either be version too low or parsing error
+            assert ("Failed to parse server version" in error_msg or 
+                   "requires RabbitMQ 4.0.0 or higher" in error_msg)
+
+    def test_validate_server_properties_version_edge_cases(self):
+        """Test validation with edge case version values."""
+        # Test with pre-release versions that should still work
+        edge_case_versions = [
+            "4.0.0-rc1",  # This might work depending on packaging library
+            "4.0.0b1",    # Beta version
+        ]
+        
+        for version_str in edge_case_versions:
+            mock_blocking_conn = Mock()
+            mock_proton_conn = Mock()
+            mock_remote_props = {
+                "product": "RabbitMQ",
+                "version": version_str
+            }
+            
+            mock_proton_conn.remote_properties = mock_remote_props
+            mock_blocking_conn.conn = mock_proton_conn
+            self.connection._conn = mock_blocking_conn
+            
+            try:
+                # Depending on packaging library behavior, this might pass or fail
+                # The important thing is that it doesn't crash
+                self.connection._validate_server_properties()
+            except ValidationCodeException:
+                # This is acceptable for edge cases
+                pass
+
+    def test_validate_server_properties_with_additional_properties(self):
+        """Test validation works when remote_properties has additional fields."""
+        mock_blocking_conn = Mock()
+        mock_proton_conn = Mock()
+        mock_remote_props = {
+            "product": "RabbitMQ",
+            "version": "4.2.1",
+            "platform": "Linux",
+            "information": "Licensed under the MPL 2.0",
+            "copyright": "Copyright (c) 2007-2023 VMware, Inc. or its affiliates."
+        }
+        
+        mock_proton_conn.remote_properties = mock_remote_props
+        mock_blocking_conn.conn = mock_proton_conn
+        self.connection._conn = mock_blocking_conn
+        
+        # Should not raise any exception despite additional properties
+        self.connection._validate_server_properties()