Skip to content

Commit ed5514b

Browse files
author
DanielePalaia
committed
fixing for code review
1 parent 68179ce commit ed5514b

File tree

1 file changed

+25
-9
lines changed

1 file changed

+25
-9
lines changed

tests/test_publisher.py

Lines changed: 25 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,9 @@ def test_publish_queue(connection: Connection) -> None:
3030
accepted = False
3131

3232
try:
33-
publisher = connection.publisher("/queues/" + queue_name)
33+
publisher = connection.publisher(
34+
destination=AddressHelper.queue_address(queue_name)
35+
)
3436
status = publisher.publish(Message(body="test"))
3537
if status.remote_state == OutcomeState.ACCEPTED:
3638
accepted = True
@@ -103,7 +105,9 @@ def test_publish_ssl(connection_ssl: Connection) -> None:
103105
raised = False
104106

105107
try:
106-
publisher = connection_ssl.publisher("/queues/" + queue_name)
108+
publisher = connection_ssl.publisher(
109+
destination=AddressHelper.queue_address(queue_name)
110+
)
107111
publisher.publish(Message(body="test"))
108112
except Exception:
109113
raised = True
@@ -169,11 +173,15 @@ def test_publish_per_message_both_address(connection: Connection) -> None:
169173
management = connection.management()
170174
management.declare_queue(QuorumQueueSpecification(name=queue_name))
171175

172-
message = Message(body="test")
173-
message = AddressHelper.message_to_address_helper(message, "/queues/" + queue_name)
174-
publisher = connection.publisher("/queues/" + queue_name)
176+
publisher = connection.publisher(
177+
destination=AddressHelper.queue_address(queue_name)
178+
)
175179

176180
try:
181+
message = Message(body="test")
182+
message = AddressHelper.message_to_address_helper(
183+
message, AddressHelper.queue_address(queue_name)
184+
)
177185
publisher.publish(message)
178186
except ValidationCodeException:
179187
raised = True
@@ -231,7 +239,9 @@ def test_publish_purge(connection: Connection) -> None:
231239
raised = False
232240

233241
try:
234-
publisher = connection.publisher("/queues/" + queue_name)
242+
publisher = connection.publisher(
243+
destination=AddressHelper.queue_address(queue_name)
244+
)
235245
for i in range(messages_to_publish):
236246
publisher.publish(Message(body="test"))
237247
except Exception:
@@ -271,7 +281,9 @@ def on_disconnected():
271281
connection_test.dial()
272282

273283
if publisher is not None:
274-
publisher = connection_test.publisher("/queues/" + queue_name)
284+
publisher = connection_test.publisher(
285+
destination=AddressHelper.queue_address(queue_name)
286+
)
275287

276288
nonlocal reconnected
277289
reconnected = True
@@ -290,7 +302,9 @@ def on_disconnected():
290302

291303
management.close()
292304

293-
publisher = connection_test.publisher("/queues/" + queue_name)
305+
publisher = connection_test.publisher(
306+
destination=AddressHelper.queue_address(queue_name)
307+
)
294308
while True:
295309

296310
for i in range(messages_to_publish):
@@ -346,7 +360,9 @@ def test_queue_info_for_stream_with_validations(connection: Connection) -> None:
346360

347361
print("before creating publisher")
348362

349-
publisher = connection.publisher("/queues/" + stream_name)
363+
publisher = connection.publisher(
364+
destination=AddressHelper.queue_address(stream_name)
365+
)
350366

351367
print("after creating publisher")
352368

0 commit comments

Comments
 (0)