Update package references

lukebakken · lukebakken · commit 01a4db9b89e2 · 2023-08-16T11:22:14.000-07:00
Fix XUnit build warnings
diff --git a/projects/Benchmarks/Benchmarks.csproj b/projects/Benchmarks/Benchmarks.csproj
@@ -15,7 +15,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="BenchmarkDotNet" Version="0.13.5" />
+    <PackageReference Include="BenchmarkDotNet" Version="0.13.7" />
     <PackageReference Include="Ductus.FluentDocker" Version="2.10.59" />
   </ItemGroup>
 
diff --git a/projects/RabbitMQ.Client/RabbitMQ.Client.csproj b/projects/RabbitMQ.Client/RabbitMQ.Client.csproj
@@ -57,7 +57,6 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="7.0.1" PrivateAssets="all" />
     <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" PrivateAssets="all" />
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
     <PackageReference Include="MinVer" Version="4.3.0" PrivateAssets="all" />
diff --git a/projects/Unit/TestAuth.cs b/projects/Unit/TestAuth.cs
@@ -51,7 +51,7 @@ public void TestAuthFailure()
             try
             {
                 connFactory.CreateConnection();
-                Assert.True(false, "Exception caused by authentication failure expected");
+                Assert.Fail("Exception caused by authentication failure expected");
             }
             catch (BrokerUnreachableException bue)
             {
diff --git a/projects/Unit/TestConnectionBlocked.cs b/projects/Unit/TestConnectionBlocked.cs
@@ -70,7 +70,7 @@ public void TestConnectionBlockedNotification()
 
                 if (!_notified)
                 {
-                    Assert.True(false, "Unblock notification not received.");
+                    Assert.Fail("Unblock notification not received.");
                 }
             }
             finally
@@ -92,7 +92,7 @@ public void TestDisposeOnBlockedConnectionDoesNotHang()
 
                 if (!_connDisposed.Wait(TimeSpan.FromSeconds(20)))
                 {
-                    Assert.True(false, "Dispose must have finished within 20 seconds after starting");
+                    Assert.Fail("Dispose must have finished within 20 seconds after starting");
                 }
             }
             finally
diff --git a/projects/Unit/TestConnectionRecovery.cs b/projects/Unit/TestConnectionRecovery.cs
@@ -476,7 +476,7 @@ public void TestCreateChannelOnClosedAutorecoveringConnectionDoesNotHang()
                 WaitForShutdown(c);
                 Assert.False(c.IsOpen);
                 c.CreateChannel();
-                Assert.True(false, "Expected an exception");
+                Assert.Fail("Expected an exception");
             }
             catch (AlreadyClosedException)
             {
@@ -785,7 +785,7 @@ public void TestRecoveryWithTopologyDisabled()
                 CloseAndWaitForRecovery(conn);
                 Assert.True(ch.IsOpen);
                 ch.QueueDeclarePassive(s);
-                Assert.True(false, "Expected an exception");
+                Assert.Fail("Expected an exception");
             }
             catch (OperationInterruptedException)
             {
@@ -1015,7 +1015,7 @@ public void TestThatDeletedExchangesDontReappearOnRecovery()
                 CloseAndWaitForRecovery();
                 Assert.True(_channel.IsOpen);
                 _channel.ExchangeDeclarePassive(x);
-                Assert.True(false, "Expected an exception");
+                Assert.Fail("Expected an exception");
             }
             catch (OperationInterruptedException e)
             {
@@ -1065,7 +1065,7 @@ public void TestThatDeletedQueuesDontReappearOnRecovery()
                 CloseAndWaitForRecovery();
                 Assert.True(_channel.IsOpen);
                 _channel.QueueDeclarePassive(q);
-                Assert.True(false, "Expected an exception");
+                Assert.Fail("Expected an exception");
             }
             catch (OperationInterruptedException e)
             {
diff --git a/projects/Unit/TestFloodPublishing.cs b/projects/Unit/TestFloodPublishing.cs
@@ -72,7 +72,7 @@ public async Task TestUnthrottledFloodPublishingAsync()
                     {
                         if (args.Initiator != ShutdownInitiator.Application)
                         {
-                            Assert.True(false, "Unexpected connection shutdown!");
+                            Assert.Fail("Unexpected connection shutdown!");
                         }
                     };
 
diff --git a/projects/Unit/TestHeartbeats.cs b/projects/Unit/TestHeartbeats.cs
@@ -153,7 +153,7 @@ private void CheckInitiator(ShutdownEventArgs evt)
                 string s = string.Format("Shutdown: {0}, initiated by: {1}",
                                       evt, evt.Initiator);
                 Console.WriteLine(s);
-                Assert.True(false, s);
+                Assert.Fail(s);
             }
         }
 
diff --git a/projects/Unit/TestPublishSharedChannel.cs b/projects/Unit/TestPublishSharedChannel.cs
@@ -66,7 +66,7 @@ public async Task MultiThreadPublishOnSharedChannel()
                 {
                     if (args.Initiator != ShutdownInitiator.Application)
                     {
-                        Assert.True(false, "Unexpected connection shutdown!");
+                        Assert.Fail("Unexpected connection shutdown!");
                     }
                 };
 
diff --git a/projects/Unit/Unit.csproj b/projects/Unit/Unit.csproj
@@ -20,20 +20,20 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.5.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.1" />
     <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
     <PackageReference Include="PublicApiGenerator" Version="11.0.0" />
-    <PackageReference Include="xunit" Version="2.4.2" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
+    <PackageReference Include="xunit" Version="2.5.0" />
+    <PackageReference Include="xunit.runner.visualstudio" Version="2.5.0">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="Verify.Xunit" Version="19.11.2" />
+    <PackageReference Include="Verify.Xunit" Version="20.8.0" />
     <PackageReference Include="Xunit.SkippableFact" Version="1.4.13" />
   </ItemGroup>
 

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public void TestAuthFailure()`
`51`	`51`	`try`
`52`	`52`	`{`
`53`	`53`	`connFactory.CreateConnection();`
`54`		`- Assert.True(false, "Exception caused by authentication failure expected");`
	`54`	`+ Assert.Fail("Exception caused by authentication failure expected");`
`55`	`55`	`}`
`56`	`56`	`catch (BrokerUnreachableException bue)`
`57`	`57`	`{`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ public void TestConnectionBlockedNotification()`
`70`	`70`
`71`	`71`	`if (!_notified)`
`72`	`72`	`{`
`73`		`- Assert.True(false, "Unblock notification not received.");`
	`73`	`+ Assert.Fail("Unblock notification not received.");`
`74`	`74`	`}`
`75`	`75`	`}`
`76`	`76`	`finally`
`@@ -92,7 +92,7 @@ public void TestDisposeOnBlockedConnectionDoesNotHang()`
`92`	`92`
`93`	`93`	`if (!_connDisposed.Wait(TimeSpan.FromSeconds(20)))`
`94`	`94`	`{`
`95`		`- Assert.True(false, "Dispose must have finished within 20 seconds after starting");`
	`95`	`+ Assert.Fail("Dispose must have finished within 20 seconds after starting");`
`96`	`96`	`}`
`97`	`97`	`}`
`98`	`98`	`finally`
Original file line number	Diff line number	Diff line change
`@@ -476,7 +476,7 @@ public void TestCreateChannelOnClosedAutorecoveringConnectionDoesNotHang()`
`476`	`476`	`WaitForShutdown(c);`
`477`	`477`	`Assert.False(c.IsOpen);`
`478`	`478`	`c.CreateChannel();`
`479`		`- Assert.True(false, "Expected an exception");`
	`479`	`+ Assert.Fail("Expected an exception");`
`480`	`480`	`}`
`481`	`481`	`catch (AlreadyClosedException)`
`482`	`482`	`{`
`@@ -785,7 +785,7 @@ public void TestRecoveryWithTopologyDisabled()`
`785`	`785`	`CloseAndWaitForRecovery(conn);`
`786`	`786`	`Assert.True(ch.IsOpen);`
`787`	`787`	`ch.QueueDeclarePassive(s);`
`788`		`- Assert.True(false, "Expected an exception");`
	`788`	`+ Assert.Fail("Expected an exception");`
`789`	`789`	`}`
`790`	`790`	`catch (OperationInterruptedException)`
`791`	`791`	`{`
`@@ -1015,7 +1015,7 @@ public void TestThatDeletedExchangesDontReappearOnRecovery()`
`1015`	`1015`	`CloseAndWaitForRecovery();`
`1016`	`1016`	`Assert.True(_channel.IsOpen);`
`1017`	`1017`	`_channel.ExchangeDeclarePassive(x);`
`1018`		`- Assert.True(false, "Expected an exception");`
	`1018`	`+ Assert.Fail("Expected an exception");`
`1019`	`1019`	`}`
`1020`	`1020`	`catch (OperationInterruptedException e)`
`1021`	`1021`	`{`
`@@ -1065,7 +1065,7 @@ public void TestThatDeletedQueuesDontReappearOnRecovery()`
`1065`	`1065`	`CloseAndWaitForRecovery();`
`1066`	`1066`	`Assert.True(_channel.IsOpen);`
`1067`	`1067`	`_channel.QueueDeclarePassive(q);`
`1068`		`- Assert.True(false, "Expected an exception");`
	`1068`	`+ Assert.Fail("Expected an exception");`
`1069`	`1069`	`}`
`1070`	`1070`	`catch (OperationInterruptedException e)`
`1071`	`1071`	`{`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ public async Task TestUnthrottledFloodPublishingAsync()`
`72`	`72`	`{`
`73`	`73`	`if (args.Initiator != ShutdownInitiator.Application)`
`74`	`74`	`{`
`75`		`- Assert.True(false, "Unexpected connection shutdown!");`
	`75`	`+ Assert.Fail("Unexpected connection shutdown!");`
`76`	`76`	`}`
`77`	`77`	`};`
`78`	`78`
Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ private void CheckInitiator(ShutdownEventArgs evt)`
`153`	`153`	`string s = string.Format("Shutdown: {0}, initiated by: {1}",`
`154`	`154`	`evt, evt.Initiator);`
`155`	`155`	`Console.WriteLine(s);`
`156`		`- Assert.True(false, s);`
	`156`	`+ Assert.Fail(s);`
`157`	`157`	`}`
`158`	`158`	`}`
`159`	`159`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ public async Task MultiThreadPublishOnSharedChannel()`
`66`	`66`	`{`
`67`	`67`	`if (args.Initiator != ShutdownInitiator.Application)`
`68`	`68`	`{`
`69`		`- Assert.True(false, "Unexpected connection shutdown!");`
	`69`	`+ Assert.Fail("Unexpected connection shutdown!");`
`70`	`70`	`}`
`71`	`71`	`};`
`72`	`72`