Complete pipes when closing

lukebakken · lukebakken · commit 0a9e405773fe · 2023-03-01T09:43:39.000-08:00
diff --git a/projects/RabbitMQ.Client/client/impl/SocketFrameHandler.cs b/projects/RabbitMQ.Client/client/impl/SocketFrameHandler.cs
@@ -216,6 +216,8 @@ public void Close()
                     {
                         _channelWriter.Complete();
                         _writerTask?.GetAwaiter().GetResult();
+                        _pipeWriter.Complete();
+                        _pipeReader.Complete();
                     }
                     catch
                     {
@@ -250,6 +252,10 @@ public bool TryReadFrame(out InboundFrame frame)
 
         public void SendHeader()
         {
+            /*
+             * Note: this stream is deliberately not disposed
+             * https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1264#discussion_r1100742748
+             */
 #if NET
             _pipeWriter.AsStream().Write(ProtocolHeader);
 #else

Original file line number	Diff line number	Diff line change
`@@ -216,6 +216,8 @@ public void Close()`
`216`	`216`	`{`
`217`	`217`	`_channelWriter.Complete();`
`218`	`218`	`_writerTask?.GetAwaiter().GetResult();`
	`219`	`+ _pipeWriter.Complete();`
	`220`	`+ _pipeReader.Complete();`
`219`	`221`	`}`
`220`	`222`	`catch`
`221`	`223`	`{`
`@@ -250,6 +252,10 @@ public bool TryReadFrame(out InboundFrame frame)`
`250`	`252`
`251`	`253`	`public void SendHeader()`
`252`	`254`	`{`
	`255`	`+ /*`
	`256`	`+ * Note: this stream is deliberately not disposed`
	`257`	`+ * https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1264#discussion_r1100742748`
	`258`	`+ */`
`253`	`259`	`#if NET`
`254`	`260`	`_pipeWriter.AsStream().Write(ProtocolHeader);`
`255`	`261`	`#else`