Skip to content

Commit 1bd65c3

Browse files
Merge pull request #240 from rabbitmq/rabbitmq-dotnet-client-239
Add a few more ConfigureAwaits to avoid deadlocks on WinForms / ASP.NET
2 parents 81ac200 + 41478cc commit 1bd65c3

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

projects/client/RabbitMQ.Client/src/client/impl/SocketFrameHandler.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ static class TaskExtensions
5454
{
5555
public static async Task TimeoutAfter(this Task task, int millisecondsTimeout)
5656
{
57-
if (task == await Task.WhenAny(task, Task.Delay(millisecondsTimeout)))
57+
if (task == await Task.WhenAny(task, Task.Delay(millisecondsTimeout)).ConfigureAwait(false))
5858
await task;
5959
else
6060
throw new TimeoutException();

projects/client/RabbitMQ.Client/src/client/impl/TcpClientAdapter.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@ public TcpClientAdapter(Socket socket)
2626

2727
public virtual async Task ConnectAsync(string host, int port)
2828
{
29-
var adds = await System.Net.Dns.GetHostAddressesAsync(host);
29+
var adds = await Dns.GetHostAddressesAsync(host).ConfigureAwait(false);
3030
var ep = adds.First();
3131
#if CORECLR
3232
await sock.ConnectAsync(ep, port);
3333
#else
3434
sock.Connect(ep, port);
35-
await System.Threading.Tasks.Task.FromResult (false);
35+
await Task.FromResult(false);
3636
#endif
3737
}
3838

0 commit comments

Comments
 (0)