Use ConcurrentDictionary.TryAdd instead of

IDictionary.Add

IDictionary.Add throws if the key is already present which makes it
fail when adding the same binding more than once.

[#141934415]

Author: kjnilsson

projects/client/RabbitMQ.Client/src/client/impl/AutorecoveringConnection.cs

@@ -73,7 +73,7 @@ public class AutorecoveringConnection : IConnection, IRecoverable
 
         protected List<AutorecoveringModel> m_models = new List<AutorecoveringModel>();
 
-        protected IDictionary<RecordedBinding, byte> m_recordedBindings =
+        protected ConcurrentDictionary<RecordedBinding, byte> m_recordedBindings =
             new ConcurrentDictionary<RecordedBinding, byte>();
 
         protected List<EventHandler<ConnectionBlockedEventArgs>> m_recordedBlockedEventHandlers =
@@ -463,7 +463,7 @@ public void DeleteRecordedBinding(RecordedBinding rb)
         {
             lock (m_recordedEntitiesLock)
             {
-                m_recordedBindings.Remove(rb);
+                ((IDictionary<RecordedBinding, int>)m_recordedBindings).Remove(rb);
             }
         }
 
@@ -493,7 +493,7 @@ public void DeleteRecordedExchange(string name)
                 var bs = m_recordedBindings.Keys.Where(b => name.Equals(b.Destination));
                 foreach (RecordedBinding b in bs)
                 {
-                    m_recordedBindings.Remove(b);
+                    DeleteRecordedBinding(b);
                     MaybeDeleteRecordedAutoDeleteExchange(b.Source);
                 }
             }
@@ -509,7 +509,7 @@ public void DeleteRecordedQueue(string name)
                 var bs = m_recordedBindings.Keys.Where(b => name.Equals(b.Destination));
                 foreach (RecordedBinding b in bs)
                 {
-                    m_recordedBindings.Remove(b);
+                    DeleteRecordedBinding(b);
                     MaybeDeleteRecordedAutoDeleteExchange(b.Source);
                 }
             }
@@ -568,7 +568,7 @@ public void RecordBinding(RecordedBinding rb)
         {
             lock (m_recordedEntitiesLock)
             {
-                m_recordedBindings.Add(rb, 0);
+                m_recordedBindings.TryAdd(rb, 0);
             }
         }