Skip to content

Commit 20cc528

Browse files
lukebakkenlukebakken
authored
Merge pull request #746 from rabbitmq/rabbitmq-dotnet-client-745
Always sign builds
2 parents a00801c + c8a669c commit 20cc528

File tree

10 files changed

+17
-106
lines changed

10 files changed

+17
-106
lines changed

‎.gitignore

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ TestResult.xml
2121
.paket/paket.exe
2222
/paket-files/*
2323
/NuGet
24-
rabbit-mock.snk
2524
.vscode/
2625
*.lock.json
2726

@@ -123,4 +122,3 @@ projects/client/Unit*/TestResult.xml
123122
# Vim
124123
.sw?
125124
.*.sw?
126-
rabbit.snk

‎RabbitMQDotNetClient.sln

Lines changed: 9 additions & 78 deletions
Original file line numberDiff line numberDiff line change
@@ -12,99 +12,30 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
1212
Directory.Build.props = Directory.Build.props
1313
EndProjectSection
1414
EndProject
15-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "RabbitMQ.Client", "projects\client\RabbitMQ.Client\RabbitMQ.Client.csproj", "{8C554257-5ECC-45DB-873D-560BFBB74EC8}"
15+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "RabbitMQ.Client", "projects\client\RabbitMQ.Client\RabbitMQ.Client.csproj", "{8C554257-5ECC-45DB-873D-560BFBB74EC8}"
1616
EndProject
17-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Unit", "projects\client\Unit\Unit.csproj", "{B8FAC024-CC03-4067-9FFC-02846FB8AE48}"
17+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Unit", "projects\client\Unit\Unit.csproj", "{B8FAC024-CC03-4067-9FFC-02846FB8AE48}"
1818
EndProject
19-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Apigen", "projects\client\Apigen\Apigen.csproj", "{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}"
19+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Apigen", "projects\client\Apigen\Apigen.csproj", "{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}"
2020
EndProject
2121
Global
2222
GlobalSection(SolutionConfigurationPlatforms) = preSolution
2323
Debug|Any CPU = Debug|Any CPU
24-
Debug|x64 = Debug|x64
25-
Debug|x86 = Debug|x86
26-
DebugNoTest|Any CPU = DebugNoTest|Any CPU
27-
DebugNoTest|x64 = DebugNoTest|x64
28-
DebugNoTest|x86 = DebugNoTest|x86
2924
Release|Any CPU = Release|Any CPU
30-
Release|x64 = Release|x64
31-
Release|x86 = Release|x86
32-
SignedRelease|Any CPU = SignedRelease|Any CPU
33-
SignedRelease|x64 = SignedRelease|x64
34-
SignedRelease|x86 = SignedRelease|x86
3525
EndGlobalSection
3626
GlobalSection(ProjectConfigurationPlatforms) = postSolution
3727
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
3828
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.Debug|Any CPU.Build.0 = Debug|Any CPU
39-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.Debug|x64.ActiveCfg = Debug|Any CPU
40-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.Debug|x64.Build.0 = Debug|Any CPU
41-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.Debug|x86.ActiveCfg = Debug|Any CPU
42-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.Debug|x86.Build.0 = Debug|Any CPU
43-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.DebugNoTest|Any CPU.ActiveCfg = Debug|Any CPU
44-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.DebugNoTest|Any CPU.Build.0 = Debug|Any CPU
45-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.DebugNoTest|x64.ActiveCfg = Debug|Any CPU
46-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.DebugNoTest|x64.Build.0 = Debug|Any CPU
47-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.DebugNoTest|x86.ActiveCfg = Debug|Any CPU
48-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.DebugNoTest|x86.Build.0 = Debug|Any CPU
49-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.Release|Any CPU.ActiveCfg = Release|Any CPU
50-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.Release|Any CPU.Build.0 = Release|Any CPU
51-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.Release|x64.ActiveCfg = Release|Any CPU
52-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.Release|x64.Build.0 = Release|Any CPU
53-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.Release|x86.ActiveCfg = Release|Any CPU
54-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.Release|x86.Build.0 = Release|Any CPU
55-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.SignedRelease|Any CPU.ActiveCfg = Release|Any CPU
56-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.SignedRelease|Any CPU.Build.0 = Release|Any CPU
57-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.SignedRelease|x64.ActiveCfg = Release|Any CPU
58-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.SignedRelease|x64.Build.0 = Release|Any CPU
59-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.SignedRelease|x86.ActiveCfg = Release|Any CPU
60-
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.SignedRelease|x86.Build.0 = Release|Any CPU
29+
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.Release|Any CPU.ActiveCfg = Debug|Any CPU
30+
{8C554257-5ECC-45DB-873D-560BFBB74EC8}.Release|Any CPU.Build.0 = Debug|Any CPU
6131
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
6232
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.Debug|Any CPU.Build.0 = Debug|Any CPU
63-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.Debug|x64.ActiveCfg = Debug|Any CPU
64-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.Debug|x64.Build.0 = Debug|Any CPU
65-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.Debug|x86.ActiveCfg = Debug|Any CPU
66-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.Debug|x86.Build.0 = Debug|Any CPU
67-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.DebugNoTest|Any CPU.ActiveCfg = Debug|Any CPU
68-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.DebugNoTest|x64.ActiveCfg = Debug|Any CPU
69-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.DebugNoTest|x64.Build.0 = Debug|Any CPU
70-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.DebugNoTest|x86.ActiveCfg = Debug|Any CPU
71-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.DebugNoTest|x86.Build.0 = Debug|Any CPU
72-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.Release|Any CPU.ActiveCfg = Release|Any CPU
73-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.Release|Any CPU.Build.0 = Release|Any CPU
74-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.Release|x64.ActiveCfg = Release|Any CPU
75-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.Release|x64.Build.0 = Release|Any CPU
76-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.Release|x86.ActiveCfg = Release|Any CPU
77-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.Release|x86.Build.0 = Release|Any CPU
78-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.SignedRelease|Any CPU.ActiveCfg = Release|Any CPU
79-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.SignedRelease|Any CPU.Build.0 = Release|Any CPU
80-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.SignedRelease|x64.ActiveCfg = Release|Any CPU
81-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.SignedRelease|x64.Build.0 = Release|Any CPU
82-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.SignedRelease|x86.ActiveCfg = Release|Any CPU
83-
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.SignedRelease|x86.Build.0 = Release|Any CPU
33+
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.Release|Any CPU.ActiveCfg = Debug|Any CPU
34+
{B8FAC024-CC03-4067-9FFC-02846FB8AE48}.Release|Any CPU.Build.0 = Debug|Any CPU
8435
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
8536
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.Debug|Any CPU.Build.0 = Debug|Any CPU
86-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.Debug|x64.ActiveCfg = Debug|Any CPU
87-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.Debug|x64.Build.0 = Debug|Any CPU
88-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.Debug|x86.ActiveCfg = Debug|Any CPU
89-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.Debug|x86.Build.0 = Debug|Any CPU
90-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.DebugNoTest|Any CPU.ActiveCfg = Debug|Any CPU
91-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.DebugNoTest|Any CPU.Build.0 = Debug|Any CPU
92-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.DebugNoTest|x64.ActiveCfg = Debug|Any CPU
93-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.DebugNoTest|x64.Build.0 = Debug|Any CPU
94-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.DebugNoTest|x86.ActiveCfg = Debug|Any CPU
95-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.DebugNoTest|x86.Build.0 = Debug|Any CPU
96-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.Release|Any CPU.ActiveCfg = Release|Any CPU
97-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.Release|Any CPU.Build.0 = Release|Any CPU
98-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.Release|x64.ActiveCfg = Release|Any CPU
99-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.Release|x64.Build.0 = Release|Any CPU
100-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.Release|x86.ActiveCfg = Release|Any CPU
101-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.Release|x86.Build.0 = Release|Any CPU
102-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.SignedRelease|Any CPU.ActiveCfg = Release|Any CPU
103-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.SignedRelease|Any CPU.Build.0 = Release|Any CPU
104-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.SignedRelease|x64.ActiveCfg = Release|Any CPU
105-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.SignedRelease|x64.Build.0 = Release|Any CPU
106-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.SignedRelease|x86.ActiveCfg = Release|Any CPU
107-
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.SignedRelease|x86.Build.0 = Release|Any CPU
37+
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.Release|Any CPU.ActiveCfg = Debug|Any CPU
38+
{B416DDB7-5E3E-4A20-B5A9-C6E518E203A2}.Release|Any CPU.Build.0 = Debug|Any CPU
10839
EndGlobalSection
10940
GlobalSection(SolutionProperties) = preSolution
11041
HideSolutionNode = FALSE

‎appveyor.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,13 @@ skip_tags: true
66
skip_branch_with_pr: true
77
image: Visual Studio 2019
88

9-
environment:
10-
SNKSECRET:
11-
secure: C8FL0UTKVN8YcMW1wdssabbkSWMIrpJTqgUNeI2NfQw=
12-
139
cache:
1410
# Note: this must match the $rabbitmq_installer_path and $erlang_installer_path values in
1511
# tools\appveyor\install.ps1
1612
- "%HOMEDRIVE%%HOMEPATH%\\rabbitmq-server-3.8.2.exe"
1713
- "%HOMEDRIVE%%HOMEPATH%\\otp_win64_22.2.exe"
1814

1915
install:
20-
- IF DEFINED SNKSECRET (nuget install secure-file -ExcludeVersion)
21-
- IF DEFINED SNKSECRET (secure-file\tools\secure-file -decrypt %APPVEYOR_BUILD_FOLDER%\rabbit.snk.enc -secret %SNKSECRET%) ELSE (ECHO This Is A Pull Request Build)
22-
- IF NOT DEFINED SNKSECRET (copy "rabbit.snk.prbuilds" "rabbit.snk") ELSE (ECHO Using The Release Key File)
2316
- ps: .\tools\appveyor\install.ps1
2417

2518
build_script:

‎projects/client/RabbitMQ.Client/RabbitMQ.Client.csproj

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
<IncludeSymbols>true</IncludeSymbols>
2525
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
2626
<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
27+
<AssemblyOriginatorKeyFile>../rabbit.snk</AssemblyOriginatorKeyFile>
28+
<SignAssembly>true</SignAssembly>
2729
</PropertyGroup>
2830
<ItemGroup>
2931
<Compile Remove="build\**\*" />
@@ -38,26 +40,9 @@
3840
<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
3941
<DefineConstants>$(DefineConstants);CORECLR</DefineConstants>
4042
</PropertyGroup>
41-
<PropertyGroup Condition=" '$(Configuration)' == 'SignedRelease' ">
42-
<DelaySign>true</DelaySign>
43-
<OutputType>Library</OutputType>
44-
<Optimize>true</Optimize>
45-
<AssemblyOriginatorKeyFile>../../../rabbit.snk</AssemblyOriginatorKeyFile>
46-
<SignAssembly>true</SignAssembly>
47-
</PropertyGroup>
4843
<ItemGroup>
4944
<PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.0" PrivateAssets="All" />
5045
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
5146
<PackageReference Include="System.Memory" Version="4.5.3" />
5247
</ItemGroup>
53-
<ItemGroup Condition=" '$(Configuration)' == 'SignedRelease' ">
54-
<AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleToAttribute">
55-
<_Parameter1>Unit, PublicKey=00240000048000009400000006020000002400005253413100040000010001008d20ec856aeeb8c3153a77faa2d80e6e43b5db93224a20cc7ae384f65f142e89730e2ff0fcc5d578bbe96fa98a7196c77329efdee4579b3814c0789e5a39b51df6edd75b602a33ceabdfcf19a3feb832f31d8254168cd7ba5700dfbca301fbf8db614ba41ba18474de0a5f4c2d51c995bc3636c641c8cbe76f45717bfcb943b5</_Parameter1>
56-
</AssemblyAttribute>
57-
</ItemGroup>
58-
<ItemGroup Condition=" '$(Configuration)' != 'SignedRelease' ">
59-
<AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleToAttribute">
60-
<_Parameter1>Unit</_Parameter1>
61-
</AssemblyAttribute>
62-
</ItemGroup>
6348
</Project>

‎projects/client/RabbitMQ.Client/src/client/properties/AssemblyInfo.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
//---------------------------------------------------------------------------
4040

4141
using System.Reflection;
42+
using System.Runtime.CompilerServices;
4243

4344
[assembly: AssemblyTitle("RabbitMQ Client Library for .NET")]
4445
[assembly: AssemblyDescription("See https://rabbitmq.com")]
@@ -49,4 +50,5 @@
4950
[assembly: AssemblyTrademark("")]
5051
[assembly: AssemblyCulture("")]
5152

52-
[assembly: AssemblyVersion("4.0.0")]
53+
[assembly: AssemblyVersion("4.0.0")]
54+
[assembly: InternalsVisibleTo("Unit, PublicKey=00240000048000009400000006020000002400005253413100040000010001008d20ec856aeeb8c3153a77faa2d80e6e43b5db93224a20cc7ae384f65f142e89730e2ff0fcc5d578bbe96fa98a7196c77329efdee4579b3814c0789e5a39b51df6edd75b602a33ceabdfcf19a3feb832f31d8254168cd7ba5700dfbca301fbf8db614ba41ba18474de0a5f4c2d51c995bc3636c641c8cbe76f45717bfcb943b5")]

‎projects/client/Unit/Unit.csproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
<GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
1111
<GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
1212
<GenerateAssemblyCopyrightAttribute>false</GenerateAssemblyCopyrightAttribute>
13+
<AssemblyOriginatorKeyFile>../rabbit.snk</AssemblyOriginatorKeyFile>
14+
<SignAssembly>true</SignAssembly>
1315
</PropertyGroup>
1416
<ItemGroup>
1517
<ProjectReference Include="../RabbitMQ.Client/RabbitMQ.Client.csproj" />

‎projects/client/Unit/src/unit/APIApproval.Approve.approved.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
[assembly: System.Runtime.CompilerServices.InternalsVisibleTo("Unit")]
1+
[assembly: System.Runtime.CompilerServices.InternalsVisibleTo(@"Unit, PublicKey=00240000048000009400000006020000002400005253413100040000010001008d20ec856aeeb8c3153a77faa2d80e6e43b5db93224a20cc7ae384f65f142e89730e2ff0fcc5d578bbe96fa98a7196c77329efdee4579b3814c0789e5a39b51df6edd75b602a33ceabdfcf19a3feb832f31d8254168cd7ba5700dfbca301fbf8db614ba41ba18474de0a5f4c2d51c995bc3636c641c8cbe76f45717bfcb943b5")]
22
namespace RabbitMQ.Client
33
{
44
public class AmqpTcpEndpoint

‎projects/client/rabbit.snk

596 Bytes
Binary file not shown.

‎rabbit.snk.enc

-608 Bytes
Binary file not shown.

‎rabbit.snk.prbuilds

-596 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)