Skip to content

Commit 47b4d22

Browse files
author
Emile Joubert
committed
Report likely authentication failures during connection start
1 parent a6bead0 commit 47b4d22

File tree

3 files changed

+184
-7
lines changed

3 files changed

+184
-7
lines changed

‎projects/client/RabbitMQ.Client/src/client/exceptions/ConnectionException.cs

Lines changed: 71 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
1+
// This source code is dual-licensed under the Apache License, version
2+
// 2.0, and the Mozilla Public License, version 1.1.
3+
//
4+
// The APL v2.0:
5+
//
6+
//---------------------------------------------------------------------------
7+
// Copyright (C) 2007-2010 LShift Ltd., Cohesive Financial
8+
// Technologies LLC., and Rabbit Technologies Ltd.
9+
//
10+
// Licensed under the Apache License, Version 2.0 (the "License");
11+
// you may not use this file except in compliance with the License.
12+
// You may obtain a copy of the License at
13+
//
14+
// http://www.apache.org/licenses/LICENSE-2.0
15+
//
16+
// Unless required by applicable law or agreed to in writing, software
17+
// distributed under the License is distributed on an "AS IS" BASIS,
18+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
19+
// See the License for the specific language governing permissions and
20+
// limitations under the License.
21+
//---------------------------------------------------------------------------
22+
//
23+
// The MPL v1.1:
24+
//
25+
//---------------------------------------------------------------------------
26+
// The contents of this file are subject to the Mozilla Public License
27+
// Version 1.1 (the "License"); you may not use this file except in
28+
// compliance with the License. You may obtain a copy of the License at
29+
// http://www.rabbitmq.com/mpl.html
30+
//
31+
// Software distributed under the License is distributed on an "AS IS"
32+
// basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See the
33+
// License for the specific language governing rights and limitations
34+
// under the License.
35+
//
36+
// The Original Code is The RabbitMQ .NET Client.
37+
//
38+
// The Initial Developers of the Original Code are LShift Ltd,
39+
// Cohesive Financial Technologies LLC, and Rabbit Technologies Ltd.
40+
//
41+
// Portions created before 22-Nov-2008 00:00:00 GMT by LShift Ltd,
42+
// Cohesive Financial Technologies LLC, or Rabbit Technologies Ltd
43+
// are Copyright (C) 2007-2008 LShift Ltd, Cohesive Financial
44+
// Technologies LLC, and Rabbit Technologies Ltd.
45+
//
46+
// Portions created by LShift Ltd are Copyright (C) 2007-2010 LShift
47+
// Ltd. Portions created by Cohesive Financial Technologies LLC are
48+
// Copyright (C) 2007-2010 Cohesive Financial Technologies
49+
// LLC. Portions created by Rabbit Technologies Ltd are Copyright
50+
// (C) 2007-2010 Rabbit Technologies Ltd.
51+
//
52+
// All Rights Reserved.
53+
//
54+
// Contributor(s): ______________________________________.
55+
//
56+
//---------------------------------------------------------------------------
57+
using System;
58+
using System.Security.Authentication;
59+
60+
namespace RabbitMQ.Client.Exceptions
61+
{
62+
/// <summary> Thrown when the likely cause is an
63+
/// authentication failure. </summary>
64+
public class ConnectionException : InvalidCredentialException
65+
{
66+
public ConnectionException(String msg, Exception inner)
67+
: base(msg, inner)
68+
{
69+
}
70+
}
71+
}

‎projects/client/RabbitMQ.Client/src/client/impl/ConnectionBase.cs

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -986,13 +986,21 @@ public void Open(bool insist)
986986
m_clientProperties = new Hashtable(m_factory.ClientProperties);
987987

988988
// FIXME: check that PLAIN is supported.
989-
// FIXME: parse out locales properly!
990-
ConnectionTuneDetails connectionTune =
991-
m_model0.ConnectionStartOk(m_clientProperties,
992-
"PLAIN",
993-
Encoding.UTF8.GetBytes("\0" + m_factory.UserName +
994-
"\0" + m_factory.Password),
995-
"en_US");
989+
// FIXME: parse out locales properly!
990+
ConnectionTuneDetails connectionTune = default(ConnectionTuneDetails);
991+
try
992+
{
993+
connectionTune =
994+
m_model0.ConnectionStartOk(m_clientProperties,
995+
"PLAIN",
996+
Encoding.UTF8.GetBytes("\0" + m_factory.UserName +
997+
"\0" + m_factory.Password),
998+
"en_US");
999+
}
1000+
catch (OperationInterruptedException e)
1001+
{
1002+
throw new ConnectionException("Likely authentication failure during connection start", e);
1003+
}
9961004

9971005
ushort channelMax = (ushort) NegotiatedMaxValue(m_factory.RequestedChannelMax,
9981006
connectionTune.m_channelMax);

‎projects/client/Unit/src/unit/TestAuth.cs

Lines changed: 98 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
1+
// This source code is dual-licensed under the Apache License, version
2+
// 2.0, and the Mozilla Public License, version 1.1.
3+
//
4+
// The APL v2.0:
5+
//
6+
//---------------------------------------------------------------------------
7+
// Copyright (C) 2007-2010 LShift Ltd., Cohesive Financial
8+
// Technologies LLC., and Rabbit Technologies Ltd.
9+
//
10+
// Licensed under the Apache License, Version 2.0 (the "License");
11+
// you may not use this file except in compliance with the License.
12+
// You may obtain a copy of the License at
13+
//
14+
// http://www.apache.org/licenses/LICENSE-2.0
15+
//
16+
// Unless required by applicable law or agreed to in writing, software
17+
// distributed under the License is distributed on an "AS IS" BASIS,
18+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
19+
// See the License for the specific language governing permissions and
20+
// limitations under the License.
21+
//---------------------------------------------------------------------------
22+
//
23+
// The MPL v1.1:
24+
//
25+
//---------------------------------------------------------------------------
26+
// The contents of this file are subject to the Mozilla Public License
27+
// Version 1.1 (the "License"); you may not use this file except in
28+
// compliance with the License. You may obtain a copy of the License at
29+
// http://www.rabbitmq.com/mpl.html
30+
//
31+
// Software distributed under the License is distributed on an "AS IS"
32+
// basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See the
33+
// License for the specific language governing rights and limitations
34+
// under the License.
35+
//
36+
// The Original Code is The RabbitMQ .NET Client.
37+
//
38+
// The Initial Developers of the Original Code are LShift Ltd,
39+
// Cohesive Financial Technologies LLC, and Rabbit Technologies Ltd.
40+
//
41+
// Portions created before 22-Nov-2008 00:00:00 GMT by LShift Ltd,
42+
// Cohesive Financial Technologies LLC, or Rabbit Technologies Ltd
43+
// are Copyright (C) 2007-2008 LShift Ltd, Cohesive Financial
44+
// Technologies LLC, and Rabbit Technologies Ltd.
45+
//
46+
// Portions created by LShift Ltd are Copyright (C) 2007-2010 LShift
47+
// Ltd. Portions created by Cohesive Financial Technologies LLC are
48+
// Copyright (C) 2007-2010 Cohesive Financial Technologies
49+
// LLC. Portions created by Rabbit Technologies Ltd are Copyright
50+
// (C) 2007-2010 Rabbit Technologies Ltd.
51+
//
52+
// All Rights Reserved.
53+
//
54+
// Contributor(s): ______________________________________.
55+
//
56+
//---------------------------------------------------------------------------
57+
using NUnit.Framework;
58+
59+
using System;
60+
using System.IO;
61+
using System.Text;
62+
using System.Collections;
63+
64+
using RabbitMQ.Client;
65+
using RabbitMQ.Client.Impl;
66+
using RabbitMQ.Client.Exceptions;
67+
using RabbitMQ.Util;
68+
69+
namespace RabbitMQ.Client.Unit
70+
{
71+
[TestFixture]
72+
public class TestAuth
73+
{
74+
75+
[Test]
76+
public void TestAuthFailure()
77+
{
78+
ConnectionFactory connFactory = new ConnectionFactory();
79+
connFactory.UserName = "guest";
80+
connFactory.Password = "incorrect-password";
81+
82+
try
83+
{
84+
connFactory.CreateConnection();
85+
Assert.Fail("Exception caused by authentication failure expected");
86+
}
87+
catch (BrokerUnreachableException bue)
88+
{
89+
foreach (Object failureReason in bue.ConnectionErrors.Values)
90+
{
91+
Assert.IsInstanceOfType(typeof(ConnectionException), failureReason);
92+
Assert.That(((ConnectionException)failureReason).Message.ToLower().Contains("auth"));
93+
}
94+
}
95+
}
96+
}
97+
}
98+

0 commit comments

Comments
 (0)