Skip to content

Commit 4a0e861

Browse files
author
Simon MacMullen
committed
Merge bug22986 into amqp_0_9_1
2 parents d3f84b1 + c99e304 commit 4a0e861

File tree

8 files changed

+39
-15
lines changed

8 files changed

+39
-15
lines changed

docs/specs/amqp0-8.stripped.xml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -456,10 +456,18 @@ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
456456
<field name="delivery tag" domain="delivery tag"/>
457457
<field name="requeue" type="bit"/>
458458
</method>
459-
<method name="recover" index="100">
459+
<method name="recover-async" index="100">
460460
<chassis name="server" implement="MUST"/>
461461
<field name="requeue" type="bit"/>
462462
</method>
463+
<method name="recover" synchronous="1" index="110">
464+
<response name="recover-ok"/>
465+
<chassis name="server" implement="MAY"/>
466+
<field name="requeue" domain="bit"/>
467+
</method>
468+
<method name="recover-ok" index="111">
469+
<chassis name="client" implement="MAY"/>
470+
</method>
463471
</class>
464472
<class name="file" handler="channel" index="70">
465473
<chassis name="server" implement="MAY"/>

docs/specs/amqp0-9-1.stripped.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,8 @@ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
423423
<chassis name="server" implement="MAY"/>
424424
<field name="requeue" domain="bit"/>
425425
</method>
426-
<method name="recover" index="110">
426+
<method name="recover" synchronous="1" index="110">
427+
<response name="recover-ok"/>
427428
<chassis name="server" implement="MUST"/>
428429
<field name="requeue" domain="bit"/>
429430
</method>

docs/specs/amqp0-9.stripped.xml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -486,10 +486,18 @@ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
486486
<field name="delivery-tag" domain="delivery-tag"/>
487487
<field name="requeue" domain="bit"/>
488488
</method>
489-
<method name="recover" index="100">
489+
<method name="recover-async" index="100">
490490
<chassis name="server" implement="MUST"/>
491491
<field name="requeue" domain="bit"/>
492492
</method>
493+
<method name="recover" synchronous="1" index="110">
494+
<response name="recover-ok"/>
495+
<chassis name="server" implement="MAY"/>
496+
<field name="requeue" domain="bit"/>
497+
</method>
498+
<method name="recover-ok" index="111">
499+
<chassis name="client" implement="MAY"/>
500+
</method>
493501
</class>
494502
<class name="file" handler="channel" index="70">
495503
<chassis name="server" implement="MAY"/>

docs/specs/qpid-amqp.0-8.stripped.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,7 @@ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
454454
<field name="delivery tag" domain="delivery tag"/>
455455
<field name="requeue" type="bit"/>
456456
</method>
457-
<method name="recover" index="100">
457+
<method name="recover" synchronous="1" index="100">
458458
<chassis name="server" implement="MUST"/>
459459
<field name="requeue" type="bit"/>
460460
<response name="recover-ok"/>

docs/wikipages/data.ApiOverview.txt

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -58,26 +58,28 @@ protocol variant. At the time of writing, the library supports:
5858

5959
- [code Protocols.DefaultProtocol]: An alias to one of the other
6060
protocols. At the time of writing, [b the default protocol is [code
61-
AMQP_0_8]].
61+
AMQP_0_9_1]].
6262

63-
- [code Protocols.AMQP_0_8]: Standard, unmodified AMQP 0-8 protocol,
64-
including [code access.request].
63+
- [code Protocols.AMQP_0_8]: Standard AMQP 0-8 protocol, including
64+
[code access.request], [code basic.recover-async] and [code queue.unbind].
6565

6666
- [code Protocols.AMQP_0_8_QPID]: AMQP 0-8 as extended by QPid's 0-8
6767
M1 release, without [code access.request] and with extra parameters
6868
available on certain methods.
6969

70-
- [code Protocols.AMQP_0_9]: Standard, unmodified AMQP 0-9 protocol,
71-
including [code access.request], but excluding the [code Message]
72-
content-class and other areas of the specification marked "work in
73-
progress".
70+
- [code Protocols.AMQP_0_9]: Standard AMQP 0-9 protocol, including
71+
[code access.request] and [code basic.recover-async], but excluding
72+
the [code Message] content-class and other areas of the specification
73+
marked "work in progress".
74+
75+
- [code Protocols.AMQP_0_9_1]: Standard AMQP 0-9-1 protocol.
7476

7577
The [code Protocols] class also contains some convenience functions
7678
for retrieving an IProtocol from a string, from the environment or
7779
from a .NET XML configuration file. The protocol names permitted are
7880
the same as the static instance variables on class [code Protocols],
79-
that is, [code AMQP_0_8], [code AMQP_0_8_QPID], [code AMQP_0_9], and
80-
[code DefaultProtocol].
81+
that is, [code AMQP_0_8], [code AMQP_0_8_QPID], [code AMQP_0_9],
82+
[code AMQP_0_9_1] and [code DefaultProtocol].
8183

8284
The following code binds [code p] to the [code Protocols.AMQP_0_9]
8385
instance by looking it up dynamically:
@@ -131,7 +133,7 @@ All factory properties have default values. The default value for a property wil
131133
- username: [code "guest"]
132134
- password: [code "guest"]
133135
- virtual-host: [code "/"]
134-
- protocol: [code AMQP 0.8]
136+
- protocol: [code AMQP 0-9-1]
135137
- hostname: [code localhost]
136138
- port: [code 5672]
137139

docs/wikipages/meta.ApiOverview.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
owner:
2-
timestamp: Mon, 05 Jul 2010 13:15:32 GMT
2+
timestamp: Wed, 04 Aug 2010 14:28:29 GMT
33
author:
44
editgroup:
55
viewgroup:

projects/client/RabbitMQ.Client/src/client/api/IModel.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -366,6 +366,10 @@ void BasicReject(ulong deliveryTag,
366366
///<summary>(Spec method)</summary>
367367
void BasicRecover(bool requeue);
368368

369+
///<summary>(Spec method)</summary>
370+
[AmqpUnsupported("RabbitMQ.Client.Framing.v0_8qpid")]
371+
void BasicRecoverAsync(bool requeue);
372+
369373
///<summary>(Spec method) Retrieve an individual message, if
370374
///one is available; returns null if the server answers that
371375
///no messages are currently available. See also

projects/client/RabbitMQ.Client/src/client/impl/ModelBase.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -805,6 +805,7 @@ public abstract void BasicReject(ulong deliveryTag,
805805
bool requeue);
806806

807807
public abstract void BasicRecover(bool requeue);
808+
public abstract void BasicRecoverAsync(bool requeue);
808809

809810
public abstract void TxSelect();
810811
public abstract void TxCommit();

0 commit comments

Comments
 (0)