Remove non-public members from IProtocol

Author: bording

projects/client/RabbitMQ.Client/src/client/api/ConnectionFactory.cs

@@ -493,7 +493,7 @@ public IConnection CreateConnection(IEndpointResolver endpointResolver, string c
                 }
                 else
                 {
-                    IProtocol protocol = Protocols.DefaultProtocol;
+                    var protocol = new RabbitMQ.Client.Framing.Protocol();
                     conn = protocol.CreateConnection(this, false, endpointResolver.SelectOne(CreateFrameHandler), clientProvidedName);
                 }
             }

projects/client/RabbitMQ.Client/src/client/api/IProtocol.cs

@@ -73,36 +73,5 @@ public interface IProtocol
         /// Retrieve the protocol's revision (if specified).
         /// </summary>
         int Revision { get; }
-
-        /// <summary>
-        /// Construct a connection from a given set of parameters,
-        /// a frame handler, and no automatic recovery.
-        /// The "insist" parameter is passed on to the AMQP connection.open method.
-        /// </summary>
-        IConnection CreateConnection(IConnectionFactory factory, bool insist, IFrameHandler frameHandler);
-
-        /// <summary>
-        /// Construct a connection from a given set of parameters,
-        /// a frame handler, and automatic recovery settings.
-        /// </summary>
-        IConnection CreateConnection(ConnectionFactory factory, IFrameHandler frameHandler, bool automaticRecoveryEnabled);
-
-        /// <summary>
-        /// Construct a connection from a given set of parameters,
-        /// a frame handler, a client-provided name, and no automatic recovery.
-        /// The "insist" parameter is passed on to the AMQP connection.open method.
-        /// </summary>
-        IConnection CreateConnection(IConnectionFactory factory, bool insist, IFrameHandler frameHandler, string clientProvidedName);
-
-        /// <summary>
-        /// Construct a connection from a given set of parameters,
-        /// a frame handler, a client-provided name, and automatic recovery settings.
-        /// </summary>
-        IConnection CreateConnection(ConnectionFactory factory, IFrameHandler frameHandler, bool automaticRecoveryEnabled, string clientProvidedName);
-
-        /// <summary>
-        /// Construct a protocol model atop a given session.
-        /// </summary>
-        IModel CreateModel(ISession session);
     }
 }

projects/client/Unit/src/unit/APIApproval.Approve.approved.txt

@@ -440,11 +440,6 @@ namespace RabbitMQ.Client
         int MajorVersion { get; }
         int MinorVersion { get; }
         int Revision { get; }
-        RabbitMQ.Client.IConnection CreateConnection(RabbitMQ.Client.ConnectionFactory factory, RabbitMQ.Client.Impl.IFrameHandler frameHandler, bool automaticRecoveryEnabled);
-        RabbitMQ.Client.IConnection CreateConnection(RabbitMQ.Client.IConnectionFactory factory, bool insist, RabbitMQ.Client.Impl.IFrameHandler frameHandler);
-        RabbitMQ.Client.IConnection CreateConnection(RabbitMQ.Client.ConnectionFactory factory, RabbitMQ.Client.Impl.IFrameHandler frameHandler, bool automaticRecoveryEnabled, string clientProvidedName);
-        RabbitMQ.Client.IConnection CreateConnection(RabbitMQ.Client.IConnectionFactory factory, bool insist, RabbitMQ.Client.Impl.IFrameHandler frameHandler, string clientProvidedName);
-        RabbitMQ.Client.IModel CreateModel(RabbitMQ.Client.Impl.ISession session);
     }
     public interface IRecoverable
     {