Skip to content

Commit 4da85c8

Browse files
committed
Simplifying configuration
1 parent 50ad871 commit 4da85c8

File tree

3 files changed

+8
-45
lines changed

3 files changed

+8
-45
lines changed

projects/RabbitMQ.Client.OpenTelemetry/RabbitMQOpenTelemetryConfiguration.cs

Lines changed: 0 additions & 19 deletions
This file was deleted.

projects/RabbitMQ.Client.OpenTelemetry/TraceProviderBuilderExtensions.cs

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -5,34 +5,17 @@
55
using System.Text;
66
using OpenTelemetry.Context.Propagation;
77
using RabbitMQ.Client;
8-
using RabbitMQ.Client.OpenTelemetry;
98

109
namespace OpenTelemetry.Trace
1110
{
1211
public static class OpenTelemetryExtensions
1312
{
14-
public static TracerProviderBuilder AddRabbitMQInstrumentation(this TracerProviderBuilder builder,
15-
RabbitMQOpenTelemetryConfiguration configuration = null)
13+
public static TracerProviderBuilder AddRabbitMQInstrumentation(this TracerProviderBuilder builder)
1614
{
17-
if (configuration == null)
18-
{
19-
configuration = RabbitMQOpenTelemetryConfiguration.Default;
20-
}
21-
22-
RabbitMQActivitySource.UseRoutingKeyAsOperationName = configuration.UseRoutingKeyAsOperationName;
15+
RabbitMQActivitySource.UseRoutingKeyAsOperationName = true;
2316
RabbitMQActivitySource.ContextExtractor = OpenTelemetryContextExtractor;
2417
RabbitMQActivitySource.ContextInjector = OpenTelemetryContextInjector;
25-
26-
if (configuration.IncludeSubscribers)
27-
{
28-
builder.AddSource(RabbitMQActivitySource.SubscriberSourceName);
29-
}
30-
31-
if (configuration.IncludePublishers)
32-
{
33-
builder.AddSource(RabbitMQActivitySource.PublisherSourceName);
34-
}
35-
18+
builder.AddSource("RabbitMQ.Client.*");
3619
return builder;
3720
}
3821

projects/Test/SequentialIntegration/TestOpenTelemetry.cs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
using OpenTelemetry.Trace;
4141
using RabbitMQ.Client;
4242
using RabbitMQ.Client.Events;
43-
using RabbitMQ.Client.OpenTelemetry;
4443
using Xunit;
4544
using Xunit.Abstractions;
4645
using Xunit.Sdk;
@@ -90,7 +89,7 @@ public async Task TestPublisherAndConsumerActivityTags(bool useRoutingKeyAsOpera
9089
{
9190
var exportedItems = new List<Activity>();
9291
using (var tracer = Sdk.CreateTracerProviderBuilder()
93-
.AddRabbitMQInstrumentation(new RabbitMQOpenTelemetryConfiguration())
92+
.AddRabbitMQInstrumentation()
9493
.AddInMemoryExporter(exportedItems)
9594
.Build())
9695
{
@@ -145,7 +144,7 @@ public async Task TestPublisherAndConsumerActivityTagsAsync(bool useRoutingKeyAs
145144
{
146145
var exportedItems = new List<Activity>();
147146
using (var tracer = Sdk.CreateTracerProviderBuilder()
148-
.AddRabbitMQInstrumentation(new RabbitMQOpenTelemetryConfiguration())
147+
.AddRabbitMQInstrumentation()
149148
.AddInMemoryExporter(exportedItems)
150149
.Build())
151150
{
@@ -201,7 +200,7 @@ public async Task TestPublisherWithPublicationAddressAndConsumerActivityTagsAsyn
201200
{
202201
var exportedItems = new List<Activity>();
203202
using (var tracer = Sdk.CreateTracerProviderBuilder()
204-
.AddRabbitMQInstrumentation(new RabbitMQOpenTelemetryConfiguration())
203+
.AddRabbitMQInstrumentation()
205204
.AddInMemoryExporter(exportedItems)
206205
.Build())
207206
{
@@ -258,7 +257,7 @@ public async Task TestPublisherWithCachedStringsAndConsumerActivityTagsAsync(boo
258257
{
259258
var exportedItems = new List<Activity>();
260259
using (var tracer = Sdk.CreateTracerProviderBuilder()
261-
.AddRabbitMQInstrumentation(new RabbitMQOpenTelemetryConfiguration())
260+
.AddRabbitMQInstrumentation()
262261
.AddInMemoryExporter(exportedItems)
263262
.Build())
264263
{
@@ -316,7 +315,7 @@ public async Task TestPublisherAndBasicGetActivityTags(bool useRoutingKeyAsOpera
316315
{
317316
var exportedItems = new List<Activity>();
318317
using (var tracer = Sdk.CreateTracerProviderBuilder()
319-
.AddRabbitMQInstrumentation(new RabbitMQOpenTelemetryConfiguration())
318+
.AddRabbitMQInstrumentation()
320319
.AddInMemoryExporter(exportedItems)
321320
.Build())
322321
{

0 commit comments

Comments
 (0)