Fix bug I introduced

Author: lukebakken

projects/RabbitMQ.Client/client/api/ConnectionFactory.cs

@@ -189,7 +189,7 @@ public sealed class ConnectionFactory : ConnectionFactoryBase, IAsyncConnectionF
 
         // just here to hold the value that was set through the setter
         private Uri _uri;
-        private ArrayPool<byte> _memoryPool;
+        private ArrayPool<byte> _memoryPool = ArrayPool<byte>.Shared;
 
         /// <summary>
         /// The memory pool used for allocating buffers. Default is <see cref="MemoryPool{T}.Shared"/>.

projects/RabbitMQ.Client/client/impl/Connection.cs

@@ -132,6 +132,10 @@ public Connection(IConnectionFactory factory, bool insist, IFrameHandler frameHa
                 string clientProvidedName = null)
             : this(factory, insist, frameHandler, clientProvidedName)
         {
+            if (memoryPool == null)
+            {
+                throw new ArgumentNullException(nameof(memoryPool));
+            }
             _memoryPool = memoryPool;
         }
 

projects/Unit/APIApproval.Approve.verified.txt

@@ -78,7 +78,6 @@ namespace RabbitMQ.Client
         public static readonly System.TimeSpan DefaultConnectionTimeout;
         public static readonly System.TimeSpan DefaultHeartbeat;
         public ConnectionFactory() { }
-        public ConnectionFactory(System.Buffers.ArrayPool<byte> memoryPool) { }
         public System.Security.Authentication.SslProtocols AmqpUriSslProtocols { get; set; }
         public System.Collections.Generic.IList<RabbitMQ.Client.IAuthMechanismFactory> AuthMechanisms { get; set; }
         public bool AutomaticRecoveryEnabled { get; set; }
@@ -91,7 +90,7 @@ namespace RabbitMQ.Client
         public System.Func<System.Collections.Generic.IEnumerable<RabbitMQ.Client.AmqpTcpEndpoint>, RabbitMQ.Client.IEndpointResolver> EndpointResolverFactory { get; set; }
         public System.TimeSpan HandshakeContinuationTimeout { get; set; }
         public string HostName { get; set; }
-        public System.Buffers.ArrayPool<byte> MemoryPool { get; }
+        public System.Buffers.ArrayPool<byte> MemoryPool { get; set; }
         public System.TimeSpan NetworkRecoveryInterval { get; set; }
         public string Password { get; set; }
         public int Port { get; set; }