Calculate heartbeat writer interval in ms

michaelklishin · michaelklishin · commit 57433a19d33e · 2015-04-24T18:42:38.000+03:00
Seconds and integer division provided
lower-than-expected precision which
matters a great deal with low values.
diff --git a/projects/client/RabbitMQ.Client/src/client/impl/Connection.cs b/projects/client/RabbitMQ.Client/src/client/impl/Connection.cs
@@ -235,7 +235,7 @@ public ushort Heartbeat
                 m_heartbeat = value;
                 // timers fire at half the interval to avoid race
                 // conditions
-                m_heartbeatTimeSpan = TimeSpan.FromSeconds(value / 2);
+                m_heartbeatTimeSpan = TimeSpan.FromMilliseconds((value * 1000) / 2.0);
                 m_frameHandler.Timeout = (value * 1000) / 2;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -235,7 +235,7 @@ public ushort Heartbeat`
`235`	`235`	`m_heartbeat = value;`
`236`	`236`	`// timers fire at half the interval to avoid race`
`237`	`237`	`// conditions`
`238`		`- m_heartbeatTimeSpan = TimeSpan.FromSeconds(value / 2);`
	`238`	`+ m_heartbeatTimeSpan = TimeSpan.FromMilliseconds((value * 1000) / 2.0);`
`239`	`239`	`m_frameHandler.Timeout = (value * 1000) / 2;`
`240`	`240`	`}`
`241`	`241`	`}`