Use parametrized IDictionary instead of Dictionary where we can

Author: michaelklishin

projects/client/RabbitMQ.Client/src/client/api/ConnectionFactory.cs

@@ -320,7 +320,7 @@ protected virtual IConnection CreateConnection(int maxRedirects,
         ///each endpoint tried.</summary>
         public virtual IConnection CreateConnection(int maxRedirects)
         {
-            Dictionary<AmqpTcpEndpoint, int> connectionAttempts = new Dictionary<AmqpTcpEndpoint, int>();
+            IDictionary<AmqpTcpEndpoint, int> connectionAttempts = new Dictionary<AmqpTcpEndpoint, int>();
             Dictionary<AmqpTcpEndpoint, Exception> connectionErrors = new Dictionary<AmqpTcpEndpoint, Exception>();
             IConnection conn = CreateConnection(maxRedirects,
                                                 connectionAttempts,

projects/client/RabbitMQ.Client/src/client/content/MapWireFormatting.cs

@@ -60,7 +60,7 @@ public static IDictionary<string, object> ReadMap(NetworkBinaryReader reader) {
                 throw new ProtocolViolationException(message);
             }
 
-            Dictionary<string, object> table = new Dictionary<string, object>(entryCount);
+            IDictionary<string, object> table = new Dictionary<string, object>(entryCount);
             for (int entryIndex = 0; entryIndex < entryCount; entryIndex++) {
                 string key = StreamWireFormatting.ReadUntypedString(reader);
                 object value = StreamWireFormatting.ReadObject(reader);

projects/client/RabbitMQ.Client/src/client/exceptions/BrokerUnreachableException.cs

@@ -58,7 +58,7 @@ namespace RabbitMQ.Client.Exceptions {
     ///</remarks>
     public class BrokerUnreachableException: IOException
     {
-        private Dictionary<AmqpTcpEndpoint, int> m_connectionAttempts;
+        private IDictionary<AmqpTcpEndpoint, int> m_connectionAttempts;
         private Dictionary<AmqpTcpEndpoint, Exception> m_connectionErrors;
 
         ///<summary>A map from AmqpTcpEndpoint to int, counting the
@@ -78,7 +78,7 @@ public class BrokerUnreachableException: IOException
         ///maps as per the description of the ConnectionAttempts and
         ///ConnectionErrors properties. The inner exception is associated
         ///with only one connection attempt.</summary>
-        public BrokerUnreachableException(Dictionary<AmqpTcpEndpoint, int> connectionAttempts,
+        public BrokerUnreachableException(IDictionary<AmqpTcpEndpoint, int> connectionAttempts,
                                           Dictionary<AmqpTcpEndpoint, Exception> connectionErrors,
                                           Exception Inner)
             : base("None of the specified endpoints were reachable", Inner)

projects/client/RabbitMQ.Client/src/client/impl/ConnectionBase.cs

@@ -910,7 +910,7 @@ public static IDictionary<string, object> DefaultClientProperties()
                     System.Reflection.Assembly.GetAssembly(typeof(ConnectionBase));
             string version = assembly.GetName().Version.ToString();
             //TODO: Get the rest of this data from the Assembly Attributes
-            Dictionary<string, object> table = new Dictionary<string, object>();
+            IDictionary<string, object> table = new Dictionary<string, object>();
             table["product"] = Encoding.UTF8.GetBytes("RabbitMQ");
             table["version"] = Encoding.UTF8.GetBytes(version);
             table["platform"] = Encoding.UTF8.GetBytes(".NET");

projects/client/RabbitMQ.Client/src/client/impl/WireFormatting.cs

@@ -118,7 +118,7 @@ public static decimal ReadDecimal(NetworkBinaryReader reader)
         /// <returns>A <seealso cref="System.Collections.Generic.IDictionary{TKey,TValue}"/>.</returns>
         public static IDictionary<string, object> ReadTable(NetworkBinaryReader reader)
         {
-            Dictionary<string, object> table = new Dictionary<string, object>();
+            IDictionary<string, object> table = new Dictionary<string, object>();
             long tableLength = reader.ReadUInt32();
 
             Stream backingStream = reader.BaseStream;