additional client properties can now be specified via ConnectionFactory.ClientProperties

Author: Vlad Ionescu

projects/client/RabbitMQ.Client/src/client/api/ConnectionFactory.cs

@@ -80,7 +80,7 @@ namespace RabbitMQ.Client
     ///     factory.VirtualHost = ConnectionFactory.DefaultVHost;
     ///     factory.Protocol = Protocols.FromEnvironment();
     ///     factory.HostName = hostName;
-    //      factory.PortNumber = AmqpTcpEndpoint.UseDefaultPort;
+    ///     factory.PortNumber = AmqpTcpEndpoint.UseDefaultPort;
     ///     //
     ///     IConnection conn = factory.CreateConnection();
     ///     //
@@ -126,6 +126,10 @@ public class ConnectionFactory
         /// seconds, with zero meaning none (value: 0)</summary>
         public const ushort DefaultHeartbeat = 0; // PLEASE KEEP THIS MATCHING THE DOC ABOVE
 
+        /// <summary>Default value for extra client properties to be sent to
+        /// the server (value: empty Hashtable)
+        public static readonly IDictionary DefaultClientProperties = new Hashtable(); // PLEASE KEEP THIS MATCHING THE DOC ABOVE
+
         /// <summary>Username to use when authenticating to the server</summary>
         public string UserName = DefaultUser;
 
@@ -144,6 +148,10 @@ public class ConnectionFactory
         /// <summary>Heartbeat setting to request (in seconds)</summary>
         public ushort RequestedHeartbeat = DefaultHeartbeat;
 
+        /// <summary>Dictionary of extra client properties to be sent to the
+        /// server</summary>
+        public IDictionary ClientProperties = DefaultClientProperties;
+
         ///<summary>Ssl options setting</summary>
         public SslOption Ssl = new SslOption();
 

projects/client/RabbitMQ.Client/src/client/api/ConnectionParameters.cs

@@ -116,6 +116,10 @@ public interface IConnection: IDisposable
         ///(0 for disabled), in seconds.</summary>
         ushort Heartbeat { get; }
 
+        ///<summary>The client properties that has been sent to the
+        ///server.</summary>
+        IDictionary ClientProperties { get; }
+
         ///<summary>Returns the known hosts that came back from the
         ///broker in the connection.open-ok method at connection
         ///startup time. Null until the connection is completely open

projects/client/RabbitMQ.Client/src/client/api/IConnection.cs

@@ -93,6 +93,7 @@ public abstract class ConnectionBase : IConnection
         public IFrameHandler m_frameHandler;
         public uint m_frameMax = 0;
         public ushort m_heartbeat = 0;
+        public IDictionary m_clientProperties;
         public AmqpTcpEndpoint[] m_knownHosts = null;
 
         public MainSession m_session0;
@@ -250,6 +251,18 @@ public ushort Heartbeat
             }
         }
 
+        public IDictionary ClientProperties
+        {
+            get
+            {
+                return m_clientProperties;
+            }
+            set
+            {
+                m_clientProperties = value;
+            }
+        }
+
         public AmqpTcpEndpoint[] KnownHosts
         {
             get { return m_knownHosts; }
@@ -896,9 +909,12 @@ public void OnCallbackException(CallbackExceptionEventArgs args)
             }
         }
 
-        public IDictionary BuildClientPropertiesTable()
+        private static IDictionary BuildClientPropertiesTable(
+                IDictionary extraClientProperties)
         {
-            string version = this.GetType().Assembly.GetName().Version.ToString();
+            System.Reflection.Assembly assembly =
+                    System.Reflection.Assembly.GetAssembly(typeof(ConnectionBase));
+            string version = assembly.GetName().Version.ToString();
             //TODO: Get the rest of this data from the Assembly Attributes
             Hashtable table = new Hashtable();
             table["product"] = Encoding.UTF8.GetBytes("RabbitMQ");
@@ -910,7 +926,7 @@ public IDictionary BuildClientPropertiesTable()
             table["information"] = Encoding.UTF8.GetBytes("Licensed under the MPL.  " +
                                                           "See http://www.rabbitmq.com/");
 
-            foreach(DictionaryEntry de in Parameters.ClientProperties)
+            foreach(DictionaryEntry de in extraClientProperties)
                 table[de.Key] = de.Value;
 
             return table;
@@ -957,10 +973,12 @@ public void Open(bool insist)
                                                            serverVersion.Minor);
             }
 
+            ClientProperties = BuildClientPropertiesTable(m_factory.ClientProperties);
+
             // FIXME: check that PLAIN is supported.
             // FIXME: parse out locales properly!
             ConnectionTuneDetails connectionTune =
-                m_model0.ConnectionStartOk(BuildClientPropertiesTable(),
+                m_model0.ConnectionStartOk(ClientProperties,
                                            "PLAIN",
                                            Encoding.UTF8.GetBytes("\0" + m_factory.UserName +
                                                                   "\0" + m_factory.Password),