Initial tests for ConnectionFactory#CreateConnection with host lists

Author: michaelklishin

projects/client/RabbitMQ.Client/src/client/impl/AutorecoveringConnection.cs

@@ -783,6 +783,7 @@ protected void RecoverConnectionDelegate()
                     Thread.Sleep(m_factory.NetworkRecoveryInterval);
 #endif
                     // TODO: provide a way to handle these exceptions
+                    System.Diagnostics.Debug.WriteLine(e);                    
                 }
             }
         }

projects/client/RabbitMQ.Client/src/client/impl/ExtensionMethods.cs

@@ -54,7 +54,6 @@ public static class ExtensionMethods
         /// <returns></returns>
         public static T RandomItem<T>(this IList<T> list)
         {
-            System.Diagnostics.Debug.WriteLine("List: {0}", list);
             var n = list.Count;
             if (n == 0)
             {

projects/client/Unit/src/unit/TestConnectionRecovery.cs

@@ -96,6 +96,15 @@ public void TestBasicConnectionRecovery()
             Assert.IsTrue(Conn.IsOpen);
         }
 
+        [Test]
+        public void TestBasicConnectionRecoveryWithHostnameList()
+        {
+            var c = CreateAutorecoveringConnection(new List<string>() { "127.0.0.1", "localhost" });
+            Assert.IsTrue(c.IsOpen);
+            CloseAndWaitForRecovery(c);
+            Assert.IsTrue(c.IsOpen);
+        }
+
         [Test]
         public void TestBasicConnectionRecoveryOnBrokerRestart()
         {
@@ -851,6 +860,11 @@ protected AutorecoveringConnection CreateAutorecoveringConnection()
             return CreateAutorecoveringConnection(RECOVERY_INTERVAL);
         }
 
+        protected AutorecoveringConnection CreateAutorecoveringConnection(IList<string> hostnames)
+        {
+            return CreateAutorecoveringConnection(RECOVERY_INTERVAL, hostnames);
+        }
+
         protected AutorecoveringConnection CreateAutorecoveringConnection(TimeSpan interval)
         {
             var cf = new ConnectionFactory();
@@ -859,6 +873,14 @@ protected AutorecoveringConnection CreateAutorecoveringConnection(TimeSpan inter
             return (AutorecoveringConnection)cf.CreateConnection();
         }
 
+        protected AutorecoveringConnection CreateAutorecoveringConnection(TimeSpan interval, IList<string> hostnames)
+        {
+            var cf = new ConnectionFactory();
+            cf.AutomaticRecoveryEnabled = true;
+            cf.NetworkRecoveryInterval = interval;
+            return (AutorecoveringConnection)cf.CreateConnection(hostnames);
+        }
+
         protected AutorecoveringConnection CreateAutorecoveringConnectionWithTopologyRecoveryDisabled()
         {
             var cf = new ConnectionFactory();