Use IList instead of List where we can

In some cases, we use List#ToArray and List#Sort, which are
not provided by IList. Those were not updated.

Author: michaelklishin

projects/client/Apigen/src/apigen/AmqpClass.cs

@@ -44,8 +44,8 @@
 
 namespace RabbitMQ.Client.Apigen {
     public class AmqpClass: AmqpEntity {
-        public List<AmqpMethod> m_Methods;
-        public List<AmqpField> m_Fields;
+        public IList<AmqpMethod> m_Methods;
+        public IList<AmqpField> m_Fields;
 
         public AmqpClass(XmlNode n)
             : base(n)

projects/client/Apigen/src/apigen/AmqpMethod.cs

@@ -44,8 +44,8 @@
 
 namespace RabbitMQ.Client.Apigen {
     public class AmqpMethod: AmqpEntity {
-        public List<AmqpField> m_Fields;
-        public List<string> m_ResponseMethods;
+        public IList<AmqpField> m_Fields;
+        public IList<string> m_ResponseMethods;
 
         public AmqpMethod(XmlNode n)
             : base(n)

projects/client/Apigen/src/apigen/Apigen.cs

@@ -120,8 +120,8 @@ public static string MangleConstant(string name) {
             return MangleClass(name);
         }
 
-        public static List<string> IdentifierParts(string name) {
-            List<string> result = new List<string>();
+        public static IList<string> IdentifierParts(string name) {
+            IList<string> result = new List<string>();
             foreach (String s1 in name.Split(new Char[] { '-' })) {
                 foreach (String s2 in s1.Split(new Char[] { ' ' })) {
                     result.Add(s2);
@@ -173,9 +173,9 @@ public static string MangleMethodClass(AmqpClass c, AmqpMethod m) {
         public bool m_emitComments = false;
 
         public Type m_modelType = typeof(RabbitMQ.Client.Impl.IFullModel);
-        public List<Type> m_modelTypes = new List<Type>();
-        public List<KeyValuePair<string, int>> m_constants = new List<KeyValuePair<string, int>>();
-        public List<AmqpClass> m_classes = new List<AmqpClass>();
+        public IList<Type> m_modelTypes = new List<Type>();
+        public IList<KeyValuePair<string, int>> m_constants = new List<KeyValuePair<string, int>>();
+        public IList<AmqpClass> m_classes = new List<AmqpClass>();
         public Dictionary<string, string> m_domains = new Dictionary<string, string>();
 
         public static Dictionary<string, string> m_primitiveTypeMap;
@@ -232,7 +232,7 @@ public void Usage() {
             Environment.Exit(1);
         }
 
-        public Apigen(List<string> args) {
+        public Apigen(IList<string> args) {
             while (args.Count > 0 && ((string) args[0]).StartsWith("/")) {
                 HandleOption((string) args[0]);
                 args.RemoveAt(0);
@@ -800,7 +800,7 @@ public Attribute Attribute(IEnumerable<object> attributes, Type t) {
         public void EmitModelImplementation() {
             EmitLine("  public class Model: RabbitMQ.Client.Impl.ModelBase {");
             EmitLine("    public Model(RabbitMQ.Client.Impl.ISession session): base(session) {}");
-            List<MethodInfo> asynchronousHandlers = new List<MethodInfo>();
+            IList<MethodInfo> asynchronousHandlers = new List<MethodInfo>();
             foreach (Type t in m_modelTypes) {
                 foreach (MethodInfo method in t.GetMethods()) {
                     if (method.DeclaringType.Namespace != null &&
@@ -1098,7 +1098,7 @@ public void EmitModelMethod(MethodInfo method) {
             EmitLine("    }");
         }
 
-        public void EmitAsynchronousHandlers(List<MethodInfo> asynchronousHandlers) {
+        public void EmitAsynchronousHandlers(IList<MethodInfo> asynchronousHandlers) {
             EmitLine("    public override bool DispatchAsynchronous(RabbitMQ.Client.Impl.Command cmd) {");
             EmitLine("      RabbitMQ.Client.Impl.MethodBase __method = (RabbitMQ.Client.Impl.MethodBase) cmd.Method;");
             EmitLine("      switch ((__method.ProtocolClassId << 16) | __method.ProtocolMethodId) {");

projects/client/RabbitMQ.Client/src/client/impl/Command.cs

@@ -88,7 +88,7 @@ public static void CheckEmptyFrameSize() {
         public MethodBase m_method;
         public ContentHeaderBase m_header;
         public byte[] m_body0;
-        public List<byte[]> m_bodyN;
+        public IList<byte[]> m_bodyN;
 
         public MethodBase Method { get { return m_method; } }
         public ContentHeaderBase Header { get { return m_header; } }

projects/client/RabbitMQ.Client/src/util/SynchronizedList.cs

@@ -7,7 +7,7 @@
     [Serializable]
     internal class SynchronizedList<T> : IList<T>
     {
-        private readonly List<T> list;
+        private readonly IList<T> list;
         private readonly object root;
 
         public int Count
@@ -41,7 +41,7 @@ public T this[int index]
             }
         }
 
-        internal SynchronizedList(List<T> list)
+        internal SynchronizedList(IList<T> list)
         {
             this.list = list;
             this.root = ((ICollection)list).SyncRoot;

projects/examples/wcf/Test/DuplexTest/Order.cs

@@ -49,7 +49,7 @@ namespace RabbitMQ.ServiceModel.Test.DuplexTest
     public class Order
     {
         private Guid m_id;
-        private List<Pizza> m_items;
+        private IList<Pizza> m_items;
         private DateTime m_ordered;
 
         public Order()
@@ -67,7 +67,7 @@ public Guid Id
         }
 
         [DataMember]
-        public List<Pizza> Items
+        public IList<Pizza> Items
         {
             get { return m_items; }
             set { m_items = value; }

projects/examples/wcf/Test/Program.cs

@@ -71,7 +71,7 @@ static void Main(string[] args)
 #endif
 
             int passed = 0, failed = 0;
-            List<ITestCase> tests = new List<ITestCase>();
+            IList<ITestCase> tests = new List<ITestCase>();
             tests.Add(new OneWayTest.OneWayTest());
             tests.Add(new TwoWayTest.TwoWayTest());
             tests.Add(new SessionTest.SessionTest());

projects/examples/wcf/Test/SessionTest/Cart.cs

@@ -55,9 +55,9 @@ public Cart()
         }
 
         private Guid m_id;
-        private List<CartItem> m_items;
+        private IList<CartItem> m_items;
 
-        private List<CartItem> Items {
+        private IList<CartItem> Items {
             get { return m_items; }
             set { m_items = value; }
         }