Merge pull request #178 from rabbitmq/rabbitmq-dotnet-client-176

CreateConnection should select from the provided hostnames

Author: michaelklishin

projects/client/RabbitMQ.Client/src/client/api/ConnectionFactory.cs

@@ -419,7 +419,9 @@ public IConnection CreateConnection(IList<string> hostnames, String clientProvid
                 else
                 {
                     IProtocol protocol = Protocols.DefaultProtocol;
-                    conn = protocol.CreateConnection(this, false, CreateFrameHandler(), clientProvidedName);
+                    var selectedHost = this.HostnameSelector.NextFrom(hostnames);
+                    var endPoint = AmqpTcpEndpoint.Parse(selectedHost);
+                    conn = protocol.CreateConnection(this, false, CreateFrameHandler(endPoint), clientProvidedName);
                 }
             }
             catch (Exception e)

projects/client/Unit/src/unit/TestConnectionFactory.cs

@@ -85,5 +85,18 @@ public void TestCreateConnectionParsesHostNameWithPort()
             Assert.AreEqual(5672, conn.Endpoint.Port);
         }
 
+        [Test]
+        public void TestCreateConnectionWithoutAutoRecoverySelectsAHostFromTheList()
+        {
+            var cf = new ConnectionFactory();
+            cf.AutomaticRecoveryEnabled = false;
+            cf.HostName = "not_localhost";
+            cf.Port = 1234;
+            var conn = cf.CreateConnection(new System.Collections.Generic.List<string> { "localhost" }, "oregano");
+            conn.Close();
+            conn.Dispose();
+            Assert.AreEqual("not_localhost", cf.HostName);
+            Assert.AreEqual("localhost", conn.Endpoint.HostName);       
+	}
     }
 }