0-9-1 improvements

No more branching on protocol version for connection open and consistent exceptions
Better apigen attribute comments

Author: Emile Joubert

projects/client/RabbitMQ.Client/src/client/api/ConnectionFactory.cs

@@ -324,14 +324,7 @@ public virtual IConnection CreateConnection(int maxRedirects)
         ///No broker-originated redirects are permitted.</summary>
         public virtual IConnection CreateConnection()
         {
-            if (Protocol.SupportsRedirect)
-            {
-                return CreateConnection(0);
-            }
-            else
-            {
-                return Protocol.CreateConnection(this, false, Protocol.CreateFrameHandler(Endpoint));
-            }
+            return CreateConnection(0);
         }
     }
 }

projects/client/RabbitMQ.Client/src/client/api/IModel.cs

@@ -763,7 +763,9 @@ public AmqpApigenAttribute(string namespaceName)
     ///<summary>Causes the API generator to ignore the attributed method.</summary>
     ///
     ///<remarks>Mostly used to declare convenience overloads of
-    ///various AMQP methods in the IModel interface. The API
+    ///various AMQP methods in the IModel interface. Also used
+    ///to omit an autogenerated implementation of a method which
+    ///is not required for one protocol version. The API
     ///autogeneration process should of course not attempt to produce
     ///an implementation of the convenience methods, as they will be
     ///implemented by hand with sensible defaults, delegating to the

projects/client/RabbitMQ.Client/src/client/api/IProtocol.cs

@@ -74,8 +74,6 @@ public interface IProtocol
         string ApiName { get; }
         ///<summary>Retrieve the protocol's default TCP port</summary>
         int DefaultPort { get; }
-        ///<summary>Whether redirect is supported</summary>
-        bool SupportsRedirect { get; }
 
         ///<summary>Construct a frame handler for a given endpoint.</summary>
         IFrameHandler CreateFrameHandler(AmqpTcpEndpoint endpoint);

projects/client/RabbitMQ.Client/src/client/impl/AbstractProtocolBase.cs

@@ -65,10 +65,6 @@ public abstract class AbstractProtocolBase: IProtocol {
         public abstract int Revision { get; }
         public abstract string ApiName { get; }
         public abstract int DefaultPort { get; }
-        public virtual bool SupportsRedirect
-        {
-            get { return true; }
-        }
 
         public abstract IFrameHandler CreateFrameHandler(AmqpTcpEndpoint endpoint);
         public abstract IConnection CreateConnection(ConnectionFactory factory,

projects/client/RabbitMQ.Client/src/client/impl/ModelBase.cs

@@ -945,14 +945,6 @@ public abstract void _Private_ConnectionOpen(string virtualHost,
                                                      string capabilities,
                                                      bool insist);
 
-        public void HandleConnectionOpenOk()
-        {
-            ConnectionOpenContinuation k = (ConnectionOpenContinuation)m_continuationQueue.Next();
-            k.m_redirect = false;
-            k.m_host = null;
-            k.HandleCommand(null); // release the continuation.
-        }
-
         public void HandleConnectionOpenOk(string knownHosts)
         {
             ConnectionOpenContinuation k = (ConnectionOpenContinuation)m_continuationQueue.Next();

projects/client/RabbitMQ.Client/src/client/impl/v0_9_1/ProtocolBase.cs

@@ -61,11 +61,6 @@
 namespace RabbitMQ.Client.Framing.Impl.v0_9_1 {
     public abstract class ProtocolBase: AbstractProtocolBase {
 
-        public override bool SupportsRedirect
-        {
-            get { return false; }
-        }
-
         public override IFrameHandler CreateFrameHandler(AmqpTcpEndpoint endpoint) {
             return new SocketFrameHandler_0_9(endpoint);
         }

projects/client/Unit/src/unit/TestAuth.cs

@@ -93,9 +93,6 @@ public void TestAuthFailure()
                         failureReason);
                 }              
             }
-            catch (PossibleAuthenticationFailureException)
-            {
-            }
         }
     }
 }