CreateConnection should select from the provided hostnames when autorecovery is off

Author: kjnilsson

projects/client/RabbitMQ.Client/src/client/api/ConnectionFactory.cs

@@ -419,7 +419,9 @@ public IConnection CreateConnection(IList<string> hostnames, String clientProvid
                 else
                 {
                     IProtocol protocol = Protocols.DefaultProtocol;
-                    conn = protocol.CreateConnection(this, false, CreateFrameHandler(), clientProvidedName);
+                    var selectedHost = this.HostnameSelector.NextFrom(hostnames);
+                    var endPoint = AmqpTcpEndpoint.Parse(selectedHost);
+                    conn = protocol.CreateConnection(this, false, CreateFrameHandler(endPoint), clientProvidedName);
                 }
             }
             catch (Exception e)

projects/client/Unit/src/unit/TestConnectionFactory.cs

@@ -68,5 +68,19 @@ public void TestProperties()
             Assert.AreEqual(cf.HostName, h);
             Assert.AreEqual(cf.Port, p);
         }
+
+        [Test]
+        public void TestCreateConnectionWithoutAutoRecoverySelectsAHostFromTheList()
+        {
+            var cf = new ConnectionFactory();
+            cf.AutomaticRecoveryEnabled = false;
+            cf.HostName = "not_localhost";
+            cf.Port = 1234;
+            var conn = cf.CreateConnection(new System.Collections.Generic.List<string> { "localhost" }, "oregano");
+            conn.Close();
+            conn.Dispose();
+            Assert.AreEqual("not_localhost", cf.HostName);
+            Assert.AreEqual("localhost", conn.Endpoint.HostName);
+        }
     }
 }